Make better code structure for border handlers

Sine Striker

2023-12-13 a51b5688e1c33d3ce96b48c869603b00f908f513

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
#include "quickwindowagent_p.h"
 
#include <QtQuick/QQuickPaintedItem>
#include <QtQuick/private/qquickitem_p.h>
 
#include <QWKCore/private/eventobserver_p.h>
 
namespace QWK {
 
    class BorderItem : public QQuickPaintedItem, public EventObserver {
        Q_OBJECT
    public:
        explicit BorderItem(QQuickItem *parent, AbstractWindowContext *context);
        ~BorderItem() override;
 
        void updateGeometry();
 
    public:
        void paint(QPainter *painter) override;
        void itemChange(ItemChange change, const ItemChangeData &data) override;
 
    protected:
        bool observe(QEvent *event) override;
 
        AbstractWindowContext *context;
 
    private:
        void _q_windowActivityChanged();
    };
 
    BorderItem::BorderItem(QQuickItem *parent, AbstractWindowContext *context)
        : QQuickPaintedItem(parent), context(context) {
        setAntialiasing(true);   // ### FIXME: do we need to enable or disable this?
        setMipmap(true);         // ### FIXME: do we need to enable or disable this?
        setFillColor({});        // Will improve the performance a little bit.
        setOpaquePainting(true); // Will also improve the performance, we don't draw
                                 // semi-transparent borders of course.
 
        auto parentPri = QQuickItemPrivate::get(parent);
        auto anchors = QQuickItemPrivate::get(this)->anchors();
        anchors->setTop(parentPri->top());
        anchors->setLeft(parentPri->left());
        anchors->setRight(parentPri->right());
 
        setZ(10);
 
        context->addObserver(this);
        connect(window(), &QQuickWindow::activeChanged, this,
                &BorderItem::_q_windowActivityChanged);
        updateGeometry();
    }
 
    BorderItem::~BorderItem() = default;
 
    void BorderItem::updateGeometry() {
        setHeight(context->property("borderThickness").toInt());
    }
 
    void BorderItem::paint(QPainter *painter) {
        QRect rect(QPoint(0, 0), size().toSize());
        QRegion region(rect);
        void *args[] = {
            painter,
            &rect,
            &region,
        };
        context->virtual_hook(AbstractWindowContext::DrawWindows10BorderHook, args);
    }
 
    void BorderItem::itemChange(ItemChange change, const ItemChangeData &data) {
        QQuickPaintedItem::itemChange(change, data);
        switch (change) {
            case ItemVisibleHasChanged:
            case ItemDevicePixelRatioHasChanged: {
                updateGeometry();
                break;
            }
            default:
                break;
        }
    }
 
    bool BorderItem::observe(QEvent *event) {
        switch (event->type()) {
            case QEvent::UpdateRequest: {
                update();
                break;
            }
 
            default:
                break;
        }
        return false;
    }
 
    void BorderItem::_q_windowActivityChanged() {
        update();
    }
 
    void QuickWindowAgentPrivate::setupWindows10BorderWorkaround() {
        // Install painting hook
        auto ctx = context.get();
        if (ctx->property("needBorderPainter").toBool()) {
            std::ignore = new BorderItem(hostWindow->contentItem(), ctx);
        }
    }
 
}
 
#include "quickwindowagent_win.moc"