review of disk strategy linux

gcontini

2020-10-24 7e4e14dde5fbfade46311fbf75386d5371062d7d

 src/library/hw_identifier/identification_strategy.cpp

@@ -22,7 +22,7 @@
   return result;
}

FUNCTION_RETURN IdentificationStrategy::identify_pc(HwIdentifier& pc_id) const {
FUNCTION_RETURN IdentificationStrategy::generate_pc_id(HwIdentifier& pc_id) const {
   vector<array<uint8_t, HW_IDENTIFIER_PROPRIETARY_DATA>> data;
   const vector<HwIdentifier> available_ids = alternative_ids();
   FUNCTION_RETURN result = FUNC_RET_NOT_AVAIL;
@@ -33,7 +33,7 @@
   return result;
}

std::unique_ptr<IdentificationStrategy> IdentificationStrategy::get_strategy(LCC_API_IDENTIFICATION_STRATEGY strategy) {
std::unique_ptr<IdentificationStrategy> IdentificationStrategy::get_strategy(LCC_API_HW_IDENTIFICATION_STRATEGY strategy) {
   unique_ptr<IdentificationStrategy> result;
   switch (strategy) {
      case STRATEGY_DEFAULT:
@@ -45,11 +45,8 @@
      case STRATEGY_IP_ADDRESS:
         result = unique_ptr<IdentificationStrategy>(dynamic_cast<IdentificationStrategy*>(new Ethernet(true)));
         break;
      case STRATEGY_DISK_NUM:
         result = unique_ptr<IdentificationStrategy>(dynamic_cast<IdentificationStrategy*>(new DiskStrategy(true)));
         break;
      case STRATEGY_DISK_LABEL:
         result = unique_ptr<IdentificationStrategy>(dynamic_cast<IdentificationStrategy*>(new DiskStrategy(false)));
      case STRATEGY_DISK:
         result = unique_ptr<IdentificationStrategy>(dynamic_cast<IdentificationStrategy*>(new DiskStrategy()));
         break;
      default:
         throw logic_error("strategy not supported");