sola/qwindowkit.git

			@@ -33,7 +33,17 @@
			#include "qwkglobal_p.h"
			#include "qwkwindowsextra_p.h"

			#if (QT_VERSION >= QT_VERSION_CHECK(6, 6, 0)) && (QT_VERSION <= QT_VERSION_CHECK(6, 6, 1))
			# error Current Qt version has a critical bug which will break QWK functionality. Please upgrade to > 6.6.1 or downgrade to < 6.6.0
			#endif

			namespace QWK {

			enum IconButtonClickLevelFlag {
			IconButtonClicked = 1,
			IconButtonDoubleClicked = 2,
			IconButtonTriggersClose = 4,
			};

			// The thickness of an auto-hide taskbar in pixels.
			static constexpr const quint8 kAutoHideTaskBarThickness = 2;
			@@ -75,6 +85,11 @@

			static void setInternalWindowFrameMargins(QWindow *window, const QMargins &margins) {
			const QVariant marginsVar = QVariant::fromValue(margins);

			// We need to tell Qt we have set a custom margin, because we are hiding
			// the title bar by pretending the whole window is filled by client area,
			// this however confuses Qt's internal logic. We need to do the following
			// hack to let Qt consider the extra margin when changing window geometry.
			window->setProperty("_q_windowsCustomMargins", marginsVar);
			#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
			if (QPlatformWindow *platformWindow = window->handle()) {
			@@ -118,6 +133,36 @@
			SWP_NOACTIVATE \| SWP_NOSIZE \| SWP_NOZORDER \| SWP_NOOWNERZORDER);
			}

			static inline bool isFullScreen(HWND hwnd) {
			RECT windowRect{};
			::GetWindowRect(hwnd, &windowRect);
			// Compare to the full area of the screen, not the work area.
			return (windowRect == getMonitorForWindow(hwnd).rcMonitor);
			}

			static inline bool isMaximized(HWND hwnd) {
			return ::IsZoomed(hwnd);
			}

			static inline bool isMinimized(HWND hwnd) {
			return ::IsIconic(hwnd);
			}

			static inline bool isWindowNoState(HWND hwnd) {
			#if 0
			WINDOWPLACEMENT wp{};
			wp.length = sizeof(wp);
			::GetWindowPlacement(hwnd, &wp);
			return ((wp.showCmd == SW_NORMAL) \|\| (wp.showCmd == SW_RESTORE));
			#else
			if (isFullScreen(hwnd)) {
			return false;
			}
			const auto style = static_cast<DWORD>(::GetWindowLongPtrW(hwnd, GWL_STYLE));
			return (!(style & (WS_MINIMIZE \| WS_MAXIMIZE)));
			#endif
			}

			static inline void bringWindowToFront(HWND hwnd) {
			HWND oldForegroundWindow = ::GetForegroundWindow();
			if (!oldForegroundWindow) {
			@@ -129,7 +174,7 @@
			if (!::IsWindowVisible(hwnd)) {
			::ShowWindow(hwnd, SW_SHOW);
			}
			if (IsMinimized(hwnd)) {
			if (isMinimized(hwnd)) {
			// Restore the window if it is minimized.
			::ShowWindow(hwnd, SW_RESTORE);
			// Once we've been restored, throw us on the active monitor.
			@@ -155,8 +200,8 @@

			[[maybe_unused]] const auto &cleaner =
			qScopeGuard([windowThreadProcessId, currentThreadId]() {
			::AttachThreadInput(windowThreadProcessId, currentThreadId, FALSE); //
			}); // TODO: Remove it
			::AttachThreadInput(windowThreadProcessId, currentThreadId, FALSE);
			});

			::BringWindowToTop(hwnd);
			// Activate the window too. This will force us to the virtual desktop this
			@@ -164,73 +209,6 @@
			::SetActiveWindow(hwnd);
			// Throw us on the active monitor.
			moveWindowToMonitor(hwnd, activeMonitor);
			}

			static inline bool isFullScreen(HWND hwnd) {
			RECT windowRect{};
			::GetWindowRect(hwnd, &windowRect);
			// Compare to the full area of the screen, not the work area.
			return (windowRect == getMonitorForWindow(hwnd).rcMonitor);
			}

			static inline bool isWindowNoState(HWND hwnd) {
			#if 0
			WINDOWPLACEMENT wp{};
			wp.length = sizeof(wp);
			::GetWindowPlacement(hwnd, &wp);
			return ((wp.showCmd == SW_NORMAL) \|\| (wp.showCmd == SW_RESTORE));
			#else
			if (isFullScreen(hwnd)) {
			return false;
			}
			const auto style = static_cast<DWORD>(::GetWindowLongPtrW(hwnd, GWL_STYLE));
			return (!(style & (WS_MINIMIZE \| WS_MAXIMIZE)));
			#endif
			}

			static void syncPaintEventWithDwm() {
			// No need to sync with DWM if DWM composition is disabled.
			if (!isDwmCompositionEnabled()) {
			return;
			}
			const DynamicApis &apis = DynamicApis::instance();
			// Dirty hack to workaround the resize flicker caused by DWM.
			LARGE_INTEGER freq{};
			::QueryPerformanceFrequency(&freq);
			TIMECAPS tc{};
			apis.ptimeGetDevCaps(&tc, sizeof(tc));
			const UINT ms_granularity = tc.wPeriodMin;
			apis.ptimeBeginPeriod(ms_granularity);
			LARGE_INTEGER now0{};
			::QueryPerformanceCounter(&now0);
			// ask DWM where the vertical blank falls
			DWM_TIMING_INFO dti{};
			dti.cbSize = sizeof(dti);
			apis.pDwmGetCompositionTimingInfo(nullptr, &dti);
			LARGE_INTEGER now1{};
			::QueryPerformanceCounter(&now1);
			// - DWM told us about SOME vertical blank
			// - past or future, possibly many frames away
			// - convert that into the NEXT vertical blank
			const auto period = qreal(dti.qpcRefreshPeriod);
			const auto dt = qreal(dti.qpcVBlank - now1.QuadPart);
			const qreal ratio = (dt / period);
			auto w = qreal(0);
			auto m = qreal(0);
			if ((dt > qreal(0)) \|\| qFuzzyIsNull(dt)) {
			w = ratio;
			} else {
			// reach back to previous period
			// - so m represents consistent position within phase
			w = (ratio - qreal(1));
			}
			m = (dt - (period * w));
			if ((m < qreal(0)) \|\| qFuzzyCompare(m, period) \|\| (m > period)) {
			return;
			}
			const qreal m_ms = (qreal(1000) * m / qreal(freq.QuadPart));
			::Sleep(static_cast<DWORD>(std::round(m_ms)));
			apis.ptimeEndPeriod(ms_granularity);
			}

			// Returns false if the menu is canceled
			@@ -244,12 +222,20 @@
			return true;
			}

			const bool maxOrFull = IsMaximized(hWnd) \|\| isFullScreen(hWnd);
			const auto windowStyles = ::GetWindowLongPtrW(hWnd, GWL_STYLE);
			const bool allowMaximize = windowStyles & WS_MAXIMIZEBOX;
			const bool allowMinimize = windowStyles & WS_MINIMIZEBOX;

			const bool maxOrFull = isMaximized(hWnd) \|\| isFullScreen(hWnd);
			::EnableMenuItem(hMenu, SC_CLOSE, (MF_BYCOMMAND \| MFS_ENABLED));
			::EnableMenuItem(hMenu, SC_MAXIMIZE,
			(MF_BYCOMMAND \| ((maxOrFull \|\| fixedSize) ? MFS_DISABLED : MFS_ENABLED)));
			::EnableMenuItem(hMenu, SC_RESTORE,
			(MF_BYCOMMAND \| ((maxOrFull && !fixedSize) ? MFS_ENABLED : MFS_DISABLED)));
			::EnableMenuItem(
			hMenu, SC_MAXIMIZE,
			(MF_BYCOMMAND \|
			((maxOrFull \|\| fixedSize \|\| !allowMaximize) ? MFS_DISABLED : MFS_ENABLED)));
			::EnableMenuItem(
			hMenu, SC_RESTORE,
			(MF_BYCOMMAND \|
			((maxOrFull && !fixedSize && allowMaximize) ? MFS_ENABLED : MFS_DISABLED)));
			// The first menu item should be selected by default if the menu is brought
			// up by keyboard. I don't know how to pre-select a menu item but it seems
			// highlight can do the job. However, there's an annoying issue if we do
			@@ -261,7 +247,8 @@
			// the menu look kind of weird. Currently I don't know how to fix this issue.
			::HiliteMenuItem(hWnd, hMenu, SC_RESTORE,
			(MF_BYCOMMAND \| (selectFirstEntry ? MFS_HILITE : MFS_UNHILITE)));
			::EnableMenuItem(hMenu, SC_MINIMIZE, (MF_BYCOMMAND \| MFS_ENABLED));
			::EnableMenuItem(hMenu, SC_MINIMIZE,
			(MF_BYCOMMAND \| (allowMinimize ? MFS_ENABLED : MFS_DISABLED)));
			::EnableMenuItem(hMenu, SC_SIZE,
			(MF_BYCOMMAND \| ((maxOrFull \|\| fixedSize) ? MFS_DISABLED : MFS_ENABLED)));
			::EnableMenuItem(hMenu, SC_MOVE, (MF_BYCOMMAND \| (maxOrFull ? MFS_DISABLED : MFS_ENABLED)));
			@@ -327,7 +314,6 @@
			case HTBORDER:
			return Win32WindowContext::FixedBorder;
			default:
			Q_UNREACHABLE();
			break;
			}
			return Win32WindowContext::Outside;
			@@ -381,8 +367,8 @@

			static MSG createMessageBlock(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) {
			MSG msg;
			msg.hwnd = hWnd; // re-create MSG structure
			msg.message = message; // time and pt fields ignored
			msg.hwnd = hWnd;
			msg.message = message;
			msg.wParam = wParam;
			msg.lParam = lParam;

			@@ -392,6 +378,8 @@
			if (!isNonClientMessage(message)) {
			::ScreenToClient(hWnd, &msg.pt);
			}

			msg.time = ::GetMessageTime();
			return msg;
			}

			@@ -426,7 +414,7 @@
			}

			// Send to QAbstractEventDispatcher
			bool filterNativeEvent(MSG msg, LRESULT result) {
			static bool filterNativeEvent(MSG msg, LRESULT result) {
			auto dispatcher = QAbstractEventDispatcher::instance();
			QT_NATIVE_EVENT_RESULT_TYPE filterResult = *result;
			if (dispatcher && dispatcher->filterNativeEvent(nativeEventType(), msg, &filterResult)) {
			@@ -437,7 +425,7 @@
			}

			// Send to QWindowSystemInterface
			bool filterNativeEvent(QWindow window, MSG msg, LRESULT *result) {
			static bool filterNativeEvent(QWindow window, MSG msg, LRESULT *result) {
			QT_NATIVE_EVENT_RESULT_TYPE filterResult = *result;
			if (QWindowSystemInterface::handleNativeEvent(window, nativeEventType(), msg,
			&filterResult)) {
			@@ -619,6 +607,7 @@
			// Try hooked procedure and save result
			LRESULT result;
			if (ctx->windowProc(hWnd, message, wParam, lParam, &result)) {
			// https://github.com/stdware/qwindowkit/issues/45
			// Forward the event to user-defined native event filters, there may be some messages
			// that need to be processed by the user.
			std::ignore =
			@@ -649,6 +638,11 @@

			// Save window handle mapping
			g_wndProcHash->insert(hWnd, ctx);

			// Force a WM_NCCALCSIZE message manually to avoid the title bar become visible
			// while Qt is re-creating the window (such as setWindowFlag(s) calls). It has
			// been observed by our users.
			triggerFrameChange(hWnd);
			}

			static inline void removeManagedWindow(HWND hWnd) {
			@@ -693,12 +687,12 @@
			auto hWnd = reinterpret_cast<HWND>(m_windowId);
			#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
			const QPoint nativeGlobalPos =
			QHighDpi::toNativeGlobalPosition(pos, m_windowHandle);
			QHighDpi::toNativeGlobalPosition(pos, m_windowHandle.data());
			#else
			const QPoint nativeGlobalPos = QHighDpi::toNativePixels(pos, m_windowHandle);
			const QPoint nativeGlobalPos = QHighDpi::toNativePixels(pos, m_windowHandle.data());
			#endif
			std::ignore = showSystemMenu_sys(hWnd, qpoint2point(nativeGlobalPos), false,
			m_delegate->isHostSizeFixed(m_host));
			isHostSizeFixed());
			return;
			}

			@@ -713,7 +707,7 @@
			}

			#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDERS)
			case DrawWindows10BorderHook: {
			case DrawWindows10BorderHook_Emulated: {
			if (!m_windowId)
			return;

			@@ -756,7 +750,7 @@
			return;
			}

			case DrawWindows10BorderHook2: {
			case DrawWindows10BorderHook_Native: {
			if (!m_windowId)
			return;

			@@ -811,10 +805,18 @@
			return isSystemBorderEnabled() && !isWin11OrGreater();
			}

			if (key == QStringLiteral("windows-system-border-enabled")) {
			return isSystemBorderEnabled();
			}

			if (key == QStringLiteral("border-thickness")) {
			return m_windowId
			? int(getWindowFrameBorderThickness(reinterpret_cast<HWND>(m_windowId)))
			: 0;
			}

			if (key == QStringLiteral("title-bar-height")) {
			return m_windowId ? int(getTitleBarHeight(reinterpret_cast<HWND>(m_windowId))) : 0;
			}
			return AbstractWindowContext::windowAttribute(key);
			}
			@@ -825,16 +827,10 @@
			lastHitTestResult = WindowPart::Outside;
			lastHitTestResultRaw = HTNOWHERE;

			if (!isSystemBorderEnabled()) {
			m_delegate->setWindowFlags(m_host, m_delegate->getWindowFlags(m_host) \|
			Qt::FramelessWindowHint);
			}

			// If the original window id is valid, remove all resources related
			if (oldWinId) {
			removeManagedWindow(reinterpret_cast<HWND>(oldWinId));
			}

			if (!winId) {
			return;
			}
			@@ -920,17 +916,64 @@
			Q_UNUSED(oldAttribute)

			const auto hwnd = reinterpret_cast<HWND>(m_windowId);
			Q_ASSERT(hwnd);

			const DynamicApis &apis = DynamicApis::instance();
			static constexpr const MARGINS extendedMargins = {-1, -1, -1, -1};
			const auto &extendMargins = [this, &apis, hwnd]() {
			// For some unknown reason, the window background is totally black when the host object
			// is a QWidget. And extending the window frame into the client area seems to fix it
			// magically.
			// We don't need the following HACK for QtQuick windows.
			if (!m_host->isWidgetType()) {
			return;
			}
			// After many times of trying, we found that the Acrylic/Mica/Mica Alt background
			// only appears on the native Win32 window's background, so naturally we want to
			// extend the window frame into the whole client area to be able to let the special
			// material fill the whole window. Previously we are using negative margins because
			// it's widely known that using negative margins will let the window frame fill
			// the whole window and that's indeed what we wanted to do, however, later we found
			// that doing so is causing issues. When the user enabled the "show accent color on
			// window title bar and borders" option on system personalize settings, a 30px bar
			// would appear on window top. It has the same color with the system accent color.
			// Actually it's the original title bar we've already hidden, and it magically
			// appears again when we use negative margins to extend the window frame. And again
			// after some experiments, I found that the title bar won't appear if we don't extend
			// from the top side. In the end I found that we only need to extend from the left
			// side if we extend long enough. In this way we can see the special material even
			// when the host object is a QWidget and the title bar still remain hidden. But even
			// though this solution seems perfect, I really don't know why it works. The following
			// hack is totally based on experiments.
			static constexpr const MARGINS margins = {65536, 0, 0, 0};
			apis.pDwmExtendFrameIntoClientArea(hwnd, &margins);
			};
			const auto &restoreMargins = [this, &apis, hwnd]() {
			auto margins = qmargins2margins(
			m_windowAttributes.value(QStringLiteral("extra-margins")).value<QMargins>());
			windowAttribute(QStringLiteral("extra-margins")).value<QMargins>());
			apis.pDwmExtendFrameIntoClientArea(hwnd, &margins);
			};

			const auto &effectBugWorkaround = [this, hwnd]() {
			// We don't need the following HACK for QWidget windows.
			if (m_host->isWidgetType()) {
			return;
			}
			static QSet<WId> bugWindowSet{};
			if (bugWindowSet.contains(m_windowId)) {
			return;
			}
			bugWindowSet.insert(m_windowId);
			RECT rect{};
			::GetWindowRect(hwnd, &rect);
			::MoveWindow(hwnd, rect.left, rect.top, 1, 1, FALSE);
			::MoveWindow(hwnd, rect.right - 1, rect.bottom - 1, 1, 1, FALSE);
			::MoveWindow(hwnd, rect.left, rect.top, rect.right - rect.left, rect.bottom - rect.top,
			FALSE);
			};

			if (key == QStringLiteral("extra-margins")) {
			auto margins = qmargins2margins(attribute.value<QMargins>());
			return apis.pDwmExtendFrameIntoClientArea(hwnd, &margins) == S_OK;
			return SUCCEEDED(apis.pDwmExtendFrameIntoClientArea(hwnd, &margins));
			}

			if (key == QStringLiteral("dark-mode")) {
			@@ -944,12 +987,9 @@
			} else {
			apis.pAllowDarkModeForApp(enable);
			}
			for (const auto attr : {
			_DWMWA_USE_IMMERSIVE_DARK_MODE_BEFORE_20H1,
			_DWMWA_USE_IMMERSIVE_DARK_MODE,
			}) {
			apis.pDwmSetWindowAttribute(hwnd, attr, &enable, sizeof(enable));
			}
			const auto attr = isWin1020H1OrGreater() ? _DWMWA_USE_IMMERSIVE_DARK_MODE
			: _DWMWA_USE_IMMERSIVE_DARK_MODE_BEFORE_20H1;
			apis.pDwmSetWindowAttribute(hwnd, attr, &enable, sizeof(enable));

			apis.pFlushMenuThemes();
			return true;
			@@ -961,9 +1001,7 @@
			return false;
			}
			if (attribute.toBool()) {
			// We need to extend the window frame into the whole client area to be able
			// to see the blurred window background.
			apis.pDwmExtendFrameIntoClientArea(hwnd, &extendedMargins);
			extendMargins();
			if (isWin1122H2OrGreater()) {
			// Use official DWM API to enable Mica, available since Windows 11 22H2
			// (10.0.22621).
			@@ -987,6 +1025,7 @@
			}
			restoreMargins();
			}
			effectBugWorkaround();
			return true;
			}

			@@ -995,9 +1034,7 @@
			return false;
			}
			if (attribute.toBool()) {
			// We need to extend the window frame into the whole client area to be able
			// to see the blurred window background.
			apis.pDwmExtendFrameIntoClientArea(hwnd, &extendedMargins);
			extendMargins();
			// Use official DWM API to enable Mica Alt, available since Windows 11 22H2
			// (10.0.22621).
			const _DWM_SYSTEMBACKDROP_TYPE backdropType = _DWMSBT_TABBEDWINDOW;
			@@ -1009,6 +1046,7 @@
			sizeof(backdropType));
			restoreMargins();
			}
			effectBugWorkaround();
			return true;
			}

			@@ -1017,9 +1055,7 @@
			return false;
			}
			if (attribute.toBool()) {
			// We need to extend the window frame into the whole client area to be able
			// to see the blurred window background.
			apis.pDwmExtendFrameIntoClientArea(hwnd, &extendedMargins);
			extendMargins();

			const _DWM_SYSTEMBACKDROP_TYPE backdropType = _DWMSBT_TRANSIENTWINDOW;
			apis.pDwmSetWindowAttribute(hwnd, _DWMWA_SYSTEMBACKDROP_TYPE, &backdropType,
			@@ -1056,13 +1092,14 @@

			restoreMargins();
			}
			effectBugWorkaround();
			return true;
			}

			if (key == QStringLiteral("dwm-blur")) {
			// Extending window frame would break this effect for some unknown reason.
			restoreMargins();
			if (attribute.toBool()) {
			// We can't extend the window frame for this effect.
			restoreMargins();
			if (isWin8OrGreater()) {
			ACCENT_POLICY policy{};
			policy.dwAccentState = ACCENT_ENABLE_BLURBEHIND;
			@@ -1095,6 +1132,7 @@
			apis.pDwmEnableBlurBehindWindow(hwnd, &bb);
			}
			}
			effectBugWorkaround();
			return true;
			}
			return false;
			@@ -1257,7 +1295,7 @@
			POINT screenPoint{GET_X_LPARAM(dwScreenPos), GET_Y_LPARAM(dwScreenPos)};
			::ScreenToClient(hWnd, &screenPoint);
			QPoint qtScenePos = QHighDpi::fromNativeLocalPosition(point2qpoint(screenPoint),
			m_windowHandle);
			m_windowHandle.data());
			auto dummy = WindowAgentBase::Unknown;
			if (isInSystemButtons(qtScenePos, &dummy)) {
			// We must record whether the last WM_MOUSELEAVE was filtered, because if
			@@ -1369,20 +1407,42 @@
			// how to avoid doing this.
			// ### FIXME FIXME FIXME
			*result = ::DefWindowProcW(hWnd, WM_NCMOUSEMOVE, wParam, lParam);
			} else if (lastHitTestResultRaw == HTSYSMENU) {
			if (message == WM_NCLBUTTONDOWN) {
			// A message of WM_SYSCOMMAND with SC_MOUSEMENU will be sent by Windows,
			// and the current control flow will be blocked by the menu while
			// Windows will create and execute a new event loop until the menu
			// returns
			iconButtonClickTime = ::GetTickCount64();
			*result = ::DefWindowProcW(hWnd, message, wParam, lParam);
			iconButtonClickTime = 0;
			} else if (message == WM_NCLBUTTONDBLCLK) {
			// A message of WM_SYSCOMMAND with SC_CLOSE will be sent by Windows
			*result = ::DefWindowProcW(hWnd, message, wParam, lParam);
			} else {
			*result = FALSE;
			emulateClientAreaMessage(hWnd, message, wParam, lParam);
			return true;
			}

			if (lastHitTestResultRaw == HTSYSMENU) {
			switch (message) {
			case WM_NCLBUTTONDOWN:
			if (iconButtonClickLevel == 0) {
			// A message of WM_SYSCOMMAND with SC_MOUSEMENU will be sent by
			// Windows, and the current control flow will be blocked by the
			// menu while Windows will create and execute a new event loop
			// until the menu returns
			iconButtonClickTime = ::GetTickCount64();
			*result = ::DefWindowProcW(hWnd, message, wParam, lParam);
			iconButtonClickTime = 0;
			if (iconButtonClickLevel & IconButtonTriggersClose) {
			::PostMessageW(hWnd, WM_SYSCOMMAND, SC_CLOSE, 0);
			}
			if (iconButtonClickLevel & IconButtonDoubleClicked) {
			iconButtonClickLevel = 0;
			}
			// Otherwise, no need to reset `iconButtonClickLevel` if not to
			// close, if it has value, there must be another incoming
			// WM_NCLBUTTONDOWN
			} else {
			iconButtonClickLevel = 0;
			}
			break;
			case WM_NCLBUTTONDBLCLK:
			// A message of WM_SYSCOMMAND with SC_CLOSE will be sent by Windows
			*result = ::DefWindowProcW(hWnd, message, wParam, lParam);
			break;
			default:
			*result = FALSE;
			emulateClientAreaMessage(hWnd, message, wParam, lParam);
			break;
			}
			} else {
			// According to MSDN, we should return non-zero for X button messages to
			@@ -1392,8 +1452,8 @@
			(((message >= WM_NCXBUTTONDOWN) && (message <= WM_NCXBUTTONDBLCLK))
			? TRUE
			: FALSE);
			emulateClientAreaMessage(hWnd, message, wParam, lParam);
			}
			emulateClientAreaMessage(hWnd, message, wParam, lParam);
			return true;
			}
			break;
			@@ -1535,15 +1595,24 @@
			auto clientWidth = RECT_WIDTH(clientRect);
			auto clientHeight = RECT_HEIGHT(clientRect);

			QPoint qtScenePos =
			QHighDpi::fromNativeLocalPosition(point2qpoint(nativeLocalPos), m_windowHandle);
			QPoint qtScenePos = QHighDpi::fromNativeLocalPosition(point2qpoint(nativeLocalPos),
			m_windowHandle.data());

			bool isFixedSize = m_delegate->isHostSizeFixed(m_host);
			bool isTitleBar = isInTitleBarDraggableArea(qtScenePos);
			bool dontOverrideCursor = false; // ### TODO
			int frameSize = getResizeBorderThickness(hWnd);

			bool isFixedWidth = isHostWidthFixed();
			bool isFixedHeight = isHostHeightFixed();
			bool isFixedSize = isHostSizeFixed();
			bool isInLeftBorder = nativeLocalPos.x <= frameSize;
			bool isInTopBorder = nativeLocalPos.y <= frameSize;
			bool isInRightBorder = nativeLocalPos.x > clientWidth - frameSize;
			bool isInBottomBorder = nativeLocalPos.y > clientHeight - frameSize;
			bool isInTitleBar = isInTitleBarDraggableArea(qtScenePos);
			WindowAgentBase::SystemButton sysButtonType = WindowAgentBase::Unknown;
			if (!isFixedSize && isInSystemButtons(qtScenePos, &sysButtonType)) {
			bool isInCaptionButtons = isInSystemButtons(qtScenePos, &sysButtonType);
			static constexpr bool dontOverrideCursor = false; // ### TODO

			if (isInCaptionButtons) {
			// Firstly, we set the hit test result to a default value to be able to detect
			// whether we have changed it or not afterwards.
			*result = HTNOWHERE;
			@@ -1553,29 +1622,41 @@
			// window is not maximized/fullscreen/minimized, of course).
			if (isWindowNoState(hWnd)) {
			static constexpr const quint8 kBorderSize = 2;
			bool isTop = (nativeLocalPos.y <= kBorderSize);
			bool isTop = nativeLocalPos.y <= kBorderSize;
			bool isLeft = nativeLocalPos.x <= kBorderSize;
			bool isRight = (nativeLocalPos.x >= (clientWidth - kBorderSize));
			bool isRight = nativeLocalPos.x > clientWidth - kBorderSize;
			if (isTop \|\| isLeft \|\| isRight) {
			if (dontOverrideCursor) {
			if (isFixedSize \|\| dontOverrideCursor) {
			// The user doesn't want the window to be resized, so we tell
			// Windows we are in the client area so that the controls beneath
			// the mouse cursor can still be hovered or clicked.
			*result = (isTitleBar ? HTCAPTION : HTCLIENT);
			*result = isInTitleBar ? HTCAPTION : HTCLIENT;
			} else {
			if (isTop) {
			if (isLeft) {
			*result = HTTOPLEFT;
			if (isFixedWidth) {
			*result = HTTOP;
			} else if (isFixedHeight) {
			*result = HTLEFT;
			} else {
			*result = HTTOPLEFT;
			}
			} else if (isRight) {
			*result = HTTOPRIGHT;
			if (isFixedWidth) {
			*result = HTTOP;
			} else if (isFixedHeight) {
			*result = HTRIGHT;
			} else {
			*result = HTTOPRIGHT;
			}
			} else {
			*result = HTTOP;
			*result = isFixedHeight ? HTBORDER : HTTOP;
			}
			} else {
			if (isLeft) {
			*result = HTLEFT;
			if (isFixedWidth) {
			*result = HTBORDER;
			} else {
			*result = HTRIGHT;
			*result = isLeft ? HTLEFT : HTRIGHT;
			}
			}
			}
			@@ -1617,10 +1698,8 @@
			// OK, we are not inside any chrome buttons, try to find out which part of the
			// window are we hitting.

			bool max = IsMaximized(hWnd);
			bool max = isMaximized(hWnd);
			bool full = isFullScreen(hWnd);
			int frameSize = getResizeBorderThickness(hWnd);
			bool isTop = (nativeLocalPos.y < frameSize);

			if (isSystemBorderEnabled()) {
			// This will handle the left, right and bottom parts of the frame
			@@ -1632,8 +1711,51 @@
			// outside the window, that is, the three transparent window resize area.
			// Returning HTCLIENT will confuse Windows, we can't put our controls there
			// anyway.
			*result = ((isFixedSize \|\| dontOverrideCursor) ? HTBORDER
			: originalHitTestResult);
			*result = HTNOWHERE; // Make sure we can know we don't set any value
			// explicitly later.
			if (originalHitTestResult == HTCAPTION) {
			} else if (isFixedSize \|\| dontOverrideCursor) {
			*result = HTBORDER;
			} else if (isFixedWidth \|\| isFixedHeight) {
			if (originalHitTestResult == HTTOPLEFT) {
			if (isFixedWidth) {
			*result = HTTOP;
			} else {
			*result = HTLEFT;
			}
			} else if (originalHitTestResult == HTTOPRIGHT) {
			if (isFixedWidth) {
			*result = HTTOP;
			} else {
			*result = HTRIGHT;
			}
			} else if (originalHitTestResult == HTBOTTOMRIGHT) {
			if (isFixedWidth) {
			*result = HTBOTTOM;
			} else {
			*result = HTRIGHT;
			}
			} else if (originalHitTestResult == HTBOTTOMLEFT) {
			if (isFixedWidth) {
			*result = HTBOTTOM;
			} else {
			*result = HTLEFT;
			}
			} else if (originalHitTestResult == HTLEFT \|\|
			originalHitTestResult == HTRIGHT) {
			if (isFixedWidth) {
			*result = HTBORDER;
			}
			} else if (originalHitTestResult == HTTOP \|\|
			originalHitTestResult == HTBOTTOM) {
			if (isFixedHeight) {
			*result = HTBORDER;
			}
			}
			}
			if (*result == HTNOWHERE) {
			*result = originalHitTestResult;
			}
			return true;
			}
			if (full) {
			@@ -1641,7 +1763,7 @@
			return true;
			}
			if (max) {
			*result = (isTitleBar ? HTCAPTION : HTCLIENT);
			*result = isInTitleBar ? HTCAPTION : HTCLIENT;
			return true;
			}
			// At this point, we know that the cursor is inside the client area,
			@@ -1649,16 +1771,25 @@
			// title bar or the drag bar. Apparently, it must be the drag bar or
			// the little border at the top which the user can use to move or
			// resize the window.
			if (isTop) {
			if (isInTopBorder) {
			// Return HTCLIENT instead of HTBORDER here, because the mouse is
			// inside our homemade title bar now, return HTCLIENT to let our
			// title bar can still capture mouse events.
			*result = ((isFixedSize \|\| dontOverrideCursor)
			? (isTitleBar ? HTCAPTION : HTCLIENT)
			: HTTOP);
			*result = [&]() {
			if (isFixedSize \|\| isFixedHeight \|\| dontOverrideCursor \|\|
			(isFixedWidth && (isInLeftBorder \|\| isInRightBorder))) {
			if (isInTitleBar) {
			return HTCAPTION;
			} else {
			return HTCLIENT;
			}
			} else {
			return HTTOP;
			}
			}();
			return true;
			}
			if (isTitleBar) {
			if (isInTitleBar) {
			*result = HTCAPTION;
			return true;
			}
			@@ -1669,58 +1800,86 @@
			*result = HTCLIENT;
			return true;
			}
			if (max) {
			*result = (isTitleBar ? HTCAPTION : HTCLIENT);
			if (max \|\| isFixedSize \|\| dontOverrideCursor) {
			*result = isInTitleBar ? HTCAPTION : HTCLIENT;
			return true;
			}
			if (!isFixedSize) {
			const bool isBottom = (nativeLocalPos.y >= (clientHeight - frameSize));
			// Make the border a little wider to let the user easy to resize on corners.
			const auto scaleFactor = ((isTop \|\| isBottom) ? qreal(2) : qreal(1));
			const int scaledFrameSize = std::round(qreal(frameSize) * scaleFactor);
			const bool isLeft = (nativeLocalPos.x < scaledFrameSize);
			const bool isRight = (nativeLocalPos.x >= (clientWidth - scaledFrameSize));
			if (dontOverrideCursor && (isTop \|\| isBottom \|\| isLeft \|\| isRight)) {
			// Return HTCLIENT instead of HTBORDER here, because the mouse is
			// inside the window now, return HTCLIENT to let the controls
			// inside our window can still capture mouse events.
			*result = (isTitleBar ? HTCAPTION : HTCLIENT);
			return true;
			if (isFixedWidth \|\| isFixedHeight) {
			if (isInLeftBorder && isInTopBorder) {
			if (isFixedWidth) {
			*result = HTTOP;
			} else {
			*result = HTLEFT;
			}
			} else if (isInRightBorder && isInTopBorder) {
			if (isFixedWidth) {
			*result = HTTOP;
			} else {
			*result = HTRIGHT;
			}
			} else if (isInRightBorder && isInBottomBorder) {
			if (isFixedWidth) {
			*result = HTBOTTOM;
			} else {
			*result = HTRIGHT;
			}
			} else if (isInLeftBorder && isInBottomBorder) {
			if (isFixedWidth) {
			*result = HTBOTTOM;
			} else {
			*result = HTLEFT;
			}
			} else if (isInLeftBorder \|\| isInRightBorder) {
			if (isFixedWidth) {
			*result = HTCLIENT;
			} else {
			*result = isInLeftBorder ? HTLEFT : HTRIGHT;
			}
			} else if (isInTopBorder \|\| isInBottomBorder) {
			if (isFixedHeight) {
			*result = HTCLIENT;
			} else {
			*result = isInTopBorder ? HTTOP : HTBOTTOM;
			}
			} else {
			*result = HTCLIENT;
			}
			if (isTop) {
			if (isLeft) {
			return true;
			} else {
			if (isInTopBorder) {
			if (isInLeftBorder) {
			*result = HTTOPLEFT;
			return true;
			}
			if (isRight) {
			if (isInRightBorder) {
			*result = HTTOPRIGHT;
			return true;
			}
			*result = HTTOP;
			return true;
			}
			if (isBottom) {
			if (isLeft) {
			if (isInBottomBorder) {
			if (isInLeftBorder) {
			*result = HTBOTTOMLEFT;
			return true;
			}
			if (isRight) {
			if (isInRightBorder) {
			*result = HTBOTTOMRIGHT;
			return true;
			}
			*result = HTBOTTOM;
			return true;
			}
			if (isLeft) {
			if (isInLeftBorder) {
			*result = HTLEFT;
			return true;
			}
			if (isRight) {
			if (isInRightBorder) {
			*result = HTRIGHT;
			return true;
			}
			}
			if (isTitleBar) {
			if (isInTitleBar) {
			*result = HTCAPTION;
			return true;
			}
			@@ -1899,8 +2058,24 @@
			// implement an elaborate client-area preservation technique, and
			// simply return 0, which means "preserve the entire old client area
			// and align it with the upper-left corner of our new client area".

			const auto clientRect = wParam ? &(reinterpret_cast<LPNCCALCSIZE_PARAMS>(lParam))->rgrc[0]
			: reinterpret_cast<LPRECT>(lParam);
			[[maybe_unused]] const auto &flickerReducer = qScopeGuard([this]() {
			// When we receive this message, it means the window size has changed
			// already, and it seems this message always come before any client
			// area size notifications (eg. WM_WINDOWPOSCHANGED and WM_SIZE). Let
			// D3D/VK paint immediately to let user see the latest result as soon
			// as possible.
			const auto &isTargetSurface = [](const QSurface::SurfaceType st) {
			return st != QSurface::RasterSurface && st != QSurface::OpenGLSurface &&
			st != QSurface::RasterGLSurface && st != QSurface::OpenVGSurface;
			};
			if (m_windowHandle && isTargetSurface(m_windowHandle->surfaceType()) &&
			isDwmCompositionEnabled() && DynamicApis::instance().pDwmFlush) {
			DynamicApis::instance().pDwmFlush();
			}
			});
			if (isSystemBorderEnabled()) {
			// Store the original top margin before the default window procedure applies the
			// default frame.
			@@ -1913,9 +2088,9 @@
			// that's also how most applications customize their title bars on Windows. It's
			// totally OK but since we want to preserve as much original frame as possible,
			// we can't use that solution.
			const LRESULT hitTestResult = ::DefWindowProcW(hWnd, WM_NCCALCSIZE, wParam, lParam);
			if ((hitTestResult != HTERROR) && (hitTestResult != HTNOWHERE)) {
			*result = hitTestResult;
			const LRESULT originalResult = ::DefWindowProcW(hWnd, WM_NCCALCSIZE, wParam, lParam);
			if (originalResult != 0) {
			*result = originalResult;
			return true;
			}
			// Re-apply the original top from before the size of the default frame was
			@@ -1929,7 +2104,7 @@
			clientRect->top = originalTop;
			}

			const bool max = IsMaximized(hWnd);
			const bool max = isMaximized(hWnd);
			const bool full = isFullScreen(hWnd);
			// We don't need this correction when we're fullscreen. We will
			// have the WS_POPUP size, so we don't have to worry about
			@@ -2022,8 +2197,6 @@
			}
			}
			}
			// We should call this function only before the function returns.
			syncPaintEventWithDwm();
			// By returning WVR_REDRAW we can make the window resizing look
			// less broken. But we must return 0 if wParam is FALSE, according to Microsoft
			// Docs.
			@@ -2034,7 +2207,10 @@
			// of the upper-left non-client area. It's confirmed that this issue exists
			// from Windows 7 to Windows 10. Not tested on Windows 11 yet. Don't know
			// whether it exists on Windows XP to Windows Vista or not.
			*result = wParam ? WVR_REDRAW : FALSE;

			// https://github.com/chromium/chromium/blob/5d297da3cf2a642e9ace2b23fed097370bc70814/ui/views/win/hwnd_message_handler.cc#L2330
			// Do not return WVR_REDRAW otherwise child HWNDs will be mispositioned.
			*result = FALSE;
			return true;
			}

			@@ -2044,7 +2220,7 @@
			return {GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam)};
			};
			const auto getNativeGlobalPosFromKeyboard = [hWnd]() -> POINT {
			const bool maxOrFull = IsMaximized(hWnd) \|\| isFullScreen(hWnd);
			const bool maxOrFull = isMaximized(hWnd) \|\| isFullScreen(hWnd);
			const quint32 frameSize = getResizeBorderThickness(hWnd);
			const quint32 horizontalOffset =
			((maxOrFull \|\| !isSystemBorderEnabled()) ? 0 : frameSize);
			@@ -2076,9 +2252,12 @@
			switch (message) {
			case WM_RBUTTONUP: {
			const POINT nativeLocalPos = getNativePosFromMouse();
			const QPoint qtScenePos =
			QHighDpi::fromNativeLocalPosition(point2qpoint(nativeLocalPos), m_windowHandle);
			if (isInTitleBarDraggableArea(qtScenePos)) {
			const QPoint qtScenePos = QHighDpi::fromNativeLocalPosition(
			point2qpoint(nativeLocalPos), m_windowHandle.data());
			WindowAgentBase::SystemButton sysButtonType = WindowAgentBase::Unknown;
			if (isInTitleBarDraggableArea(qtScenePos) \|\|
			(isInSystemButtons(qtScenePos, &sysButtonType) &&
			sysButtonType == WindowAgentBase::WindowIcon)) {
			shouldShowSystemMenu = true;
			nativeGlobalPos = nativeLocalPos;
			::ClientToScreen(hWnd, &nativeGlobalPos);
			@@ -2126,29 +2305,84 @@
			break;
			}
			if (shouldShowSystemMenu) {
			bool triggeredByIconButton = iconButtonClickTime > 0;
			if (triggeredByIconButton) {
			// TODO: Adjust `nativeGlobalPos` to (0, realTitleBarHeight)
			// hint: use m_delgegate->mapGeometryToScene
			}
			bool res = showSystemMenu_sys(hWnd, nativeGlobalPos, broughtByKeyboard,
			m_delegate->isHostSizeFixed(m_host));
			static HHOOK mouseHook = nullptr;
			static std::optional<POINT> mouseClickPos;
			static bool mouseDoubleClicked = false;
			bool mouseHookedLocal = false;

			// Emulate the Windows SYSMENU button's behavior
			static uint32_t doubleClickTime = ::GetDoubleClickTime();
			if (triggeredByIconButton && !res &&
			::GetTickCount64() - iconButtonClickTime <= doubleClickTime) {
			POINT nativeGlobalPos;
			::GetCursorPos(&nativeGlobalPos);
			POINT nativeLocalPos = nativeGlobalPos;
			::ScreenToClient(hWnd, &nativeLocalPos);
			QPoint qtScenePos =
			QHighDpi::fromNativeLocalPosition(point2qpoint(nativeLocalPos), m_windowHandle);
			WindowAgentBase::SystemButton sysButtonType = WindowAgentBase::Unknown;
			if (isInSystemButtons(qtScenePos, &sysButtonType) &&
			sysButtonType == WindowAgentBase::WindowIcon) {
			::PostMessageW(hWnd, WM_SYSCOMMAND, SC_CLOSE, 0);
			// The menu is triggered by a click on icon button
			if (iconButtonClickTime > 0) {
			POINT menuPos{0, static_cast<LONG>(getTitleBarHeight(hWnd))};
			if (const auto tb = titleBar()) {
			auto titleBarHeight = qreal(m_delegate->mapGeometryToScene(tb).height());
			titleBarHeight *= m_windowHandle->devicePixelRatio();
			menuPos.y = qRound(titleBarHeight);
			}
			::ClientToScreen(hWnd, &menuPos);
			nativeGlobalPos = menuPos;

			// Install mouse hook
			if (!mouseHook) {
			mouseHook = ::SetWindowsHookExW(
			WH_MOUSE,
			[](int nCode, WPARAM wParam, LPARAM lParam) {
			if (nCode >= 0) {
			switch (wParam) {
			case WM_LBUTTONDBLCLK:
			mouseDoubleClicked = true;
			Q_FALLTHROUGH();

			// case WM_POINTERDOWN:

			case WM_LBUTTONDOWN: {
			auto pMouseStruct =
			reinterpret_cast<MOUSEHOOKSTRUCT *>(lParam);
			if (pMouseStruct) {
			mouseClickPos = pMouseStruct->pt;
			}
			break;
			}
			default:
			break;
			}
			}
			return ::CallNextHookEx(nullptr, nCode, wParam, lParam);
			},
			nullptr, ::GetCurrentThreadId());
			mouseHookedLocal = true;
			}
			}

			bool res =
			showSystemMenu_sys(hWnd, nativeGlobalPos, broughtByKeyboard, isHostSizeFixed());

			// Uninstall mouse hook and check if it's a double-click
			if (mouseHookedLocal) {
			::UnhookWindowsHookEx(mouseHook);

			// Emulate the Windows icon button's behavior
			if (!res && mouseClickPos.has_value()) {
			POINT nativeLocalPos = mouseClickPos.value();
			::ScreenToClient(hWnd, &nativeLocalPos);
			QPoint qtScenePos = QHighDpi::fromNativeLocalPosition(
			point2qpoint(nativeLocalPos), m_windowHandle.data());
			WindowAgentBase::SystemButton sysButtonType = WindowAgentBase::Unknown;
			if (isInSystemButtons(qtScenePos, &sysButtonType) &&
			sysButtonType == WindowAgentBase::WindowIcon) {
			iconButtonClickLevel \|= IconButtonClicked;
			if (::GetTickCount64() - iconButtonClickTime <= ::GetDoubleClickTime()) {
			iconButtonClickLevel \|= IconButtonTriggersClose;
			}
			}
			}

			if (mouseDoubleClicked) {
			iconButtonClickLevel \|= IconButtonDoubleClicked;
			}

			mouseHook = nullptr;
			mouseClickPos.reset();
			mouseDoubleClicked = false;
			}

			// QPA's internal code will handle system menu events separately, and its