From 0ec4d68600b83d41d2e48ad35d18e2a00f234619 Mon Sep 17 00:00:00 2001 From: gcontini <1121667+gcontini@users.noreply.github.com> Date: 周六, 21 9月 2019 01:34:22 +0800 Subject: [PATCH] Merge branch 'develop' of https://github.com/open-license-manager/open-license-manager into develop --- src/library/pc-identifiers.c | 34 +++++++++++++++++++++++++--------- 1 files changed, 25 insertions(+), 9 deletions(-) diff --git a/src/library/pc-identifiers.c b/src/library/pc-identifiers.c index e14c7a5..0f39760 100644 --- a/src/library/pc-identifiers.c +++ b/src/library/pc-identifiers.c @@ -16,7 +16,11 @@ #include <stdbool.h> #include <valgrind/memcheck.h> #else +#ifdef __MINGW32__ +#include <windows.h> +#else #include <Windows.h> +#endif #endif static FUNCTION_RETURN generate_disk_pc_id(PcIdentifier * identifiers, @@ -35,11 +39,11 @@ if (identifiers == NULL || *num_identifiers == 0) { result_adapterInfos = getAdapterInfos(NULL, &adapter_num); - if (result_adapterInfos != FUNC_RET_OK) { + if ((result_adapterInfos != FUNC_RET_OK) || (adapter_num == 0)) { return generate_disk_pc_id(identifiers, num_identifiers, false); } result_diskinfos = getDiskInfos(NULL, &disk_num); - if (result_diskinfos != FUNC_RET_OK) { + if ((result_diskinfos != FUNC_RET_OK) || (disk_num == 0)) { return generate_ethernet_pc_id(identifiers, num_identifiers, true); } *num_identifiers = disk_num * adapter_num; @@ -80,7 +84,11 @@ } } end: - *num_identifiers = cmin(*num_identifiers, adapter_num * disk_num); +#ifdef _MSC_VER + *num_identifiers = min(*num_identifiers, adapter_num * disk_num); +#else + *num_identifiers = cmin(*num_identifiers, adapter_num * disk_num); +#endif free(diskInfoPtr); free(adapterInfoPtr); } @@ -145,7 +153,7 @@ return result_diskinfos; } diskInfos = (DiskInfo*) malloc(disk_num * sizeof(DiskInfo)); - //memset(diskInfos,0,disk_num * sizeof(DiskInfo)); + memset(diskInfos,0,disk_num * sizeof(DiskInfo)); result_diskinfos = getDiskInfos(diskInfos, &disk_num); if (result_diskinfos != FUNC_RET_OK) { free(diskInfos); @@ -171,7 +179,7 @@ if (use_label) { if (diskInfos[i].label[0] != 0) { memset(identifiers[j], 0, sizeof(PcIdentifier)); //!!!!!!! - strncpy(identifiers[j], diskInfos[i].label, + strncpy((char*)identifiers[j], diskInfos[i].label, sizeof(PcIdentifier)); j++; } @@ -273,14 +281,15 @@ PcSignature pc_identifier_out) { //TODO base62 encoding, now uses base64 PcIdentifier concat_identifiers[2]; - char* b64_data; + char* b64_data = NULL; int b64_size = 0; - size_t concatIdentifiersSize = sizeof(PcIdentifier) * 2; + const size_t concatIdentifiersSize = sizeof(PcIdentifier) * 2; //concat_identifiers = (PcIdentifier *) malloc(concatIdentifiersSize); memcpy(&concat_identifiers[0], identifier1, sizeof(PcIdentifier)); memcpy(&concat_identifiers[1], identifier2, sizeof(PcIdentifier)); b64_data = base64(concat_identifiers, concatIdentifiersSize, &b64_size); if (b64_size > sizeof(PcSignature)) { + free(b64_data); return FUNC_RET_BUFFER_TOO_SMALL; } sprintf(pc_identifier_out, "%.4s-%.4s-%.4s-%.4s", &b64_data[0], @@ -309,6 +318,7 @@ req_buffer_size = req_buffer_size < 2 ? 2 : req_buffer_size; identifiers = (PcIdentifier *) malloc( sizeof(PcIdentifier) * req_buffer_size); + memset(identifiers, 0, sizeof(PcIdentifier) * req_buffer_size); result = generate_pc_id(identifiers, &req_buffer_size, strategy); if (result != FUNC_RET_OK) { free(identifiers); @@ -337,7 +347,7 @@ PcIdentifier identifier2_out, PcSignature pc_signature_in) { //TODO base62 encoding, now uses base64 - unsigned char * concat_identifiers; + unsigned char * concat_identifiers = NULL; char base64ids[17]; int identifiers_size; @@ -345,6 +355,7 @@ &base64ids[8], &base64ids[12]); concat_identifiers = unbase64(base64ids, 16, &identifiers_size); if (identifiers_size > sizeof(PcIdentifier) * 2) { + free(concat_identifiers); return FUNC_RET_BUFFER_TOO_SMALL; } memcpy(identifier1_out, concat_identifiers, sizeof(PcIdentifier)); @@ -377,8 +388,12 @@ //found = false; for (i = 0; i < 2; i++) { current_strategy_id = strategy_from_pc_id(user_identifiers[i]); - if (current_strategy_id == STRATEGY_UNKNOWN) { + if (current_strategy_id == STRATEGY_UNKNOWN && previous_strategy_id == STRATEGY_UNKNOWN && i==1) { + free(calculated_identifiers); + printf("Comparing pc identifiers: %d %d %d %s\n",current_strategy_id,previous_strategy_id,i, str_code); return LICENSE_MALFORMED; + } else if (current_strategy_id == STRATEGY_UNKNOWN ){ + continue; } if (current_strategy_id != previous_strategy_id) { if (calculated_identifiers != NULL) { @@ -388,6 +403,7 @@ generate_pc_id(NULL, &calc_identifiers_size, current_strategy_id); calculated_identifiers = (PcIdentifier *) malloc( sizeof(PcIdentifier) * calc_identifiers_size); + memset(calculated_identifiers, 0, sizeof(PcIdentifier) * calc_identifiers_size); generate_pc_id(calculated_identifiers, &calc_identifiers_size, current_strategy_id); } -- Gitblit v1.9.1