From 10d16f7b6d963c83fa6a0b32a757c16c70623689 Mon Sep 17 00:00:00 2001
From: Jan Willamowius <jan@willamowius.de>
Date: 周一, 22 4月 2019 01:39:28 +0800
Subject: [PATCH] pass by reference as performance optimization
---
src/tools/license-generator/license-generator.cpp | 27 ++++++++++++++-------------
1 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/src/tools/license-generator/license-generator.cpp b/src/tools/license-generator/license-generator.cpp
index ce456cc..954e563 100644
--- a/src/tools/license-generator/license-generator.cpp
+++ b/src/tools/license-generator/license-generator.cpp
@@ -7,6 +7,7 @@
#include <iostream>
#include <string.h>
#include <iostream>
+#include <string.h>
#include <boost/date_time.hpp>
#include <boost/program_options.hpp>
#include <boost/algorithm/string.hpp>
@@ -70,13 +71,13 @@
}
vector<FullLicenseInfo> LicenseGenerator::parseLicenseInfo(
- po::variables_map vm) {
+ const po::variables_map& vm) {
string begin_date = FullLicenseInfo::UNUSED_TIME;
string end_date = FullLicenseInfo::UNUSED_TIME;
if (vm.count("expire_date")) {
const std::string dt_end = vm["expire_date"].as<string>();
try {
- end_date = normalize_date(dt_end.c_str());
+ end_date = normalize_date(dt_end);
char curdate[20];
time_t curtime = time(NULL);
strftime(curdate, 20, "%Y-%m-%d", localtime(&curtime));
@@ -90,7 +91,7 @@
if (vm.count("begin_date")) {
const std::string begin_date_str = vm["begin_date"].as<string>();
try {
- begin_date = normalize_date(begin_date_str.c_str());
+ begin_date = normalize_date(begin_date_str);
} catch (invalid_argument &e) {
cerr << endl << "Begin date not recognized: " << begin_date_str
<< " Please enter a valid date in format YYYYMMDD" << endl;
@@ -152,7 +153,7 @@
int LicenseGenerator::generateLicense(int argc, const char **argv) {
po::options_description visibleOptions = configureProgramOptions();
- //positional options must be addedd to standard options
+ //positional options must be added to standard options
po::options_description allOptions;
allOptions.add(visibleOptions).add_options()("product",
po::value<vector<string>>(), "product names");
@@ -190,22 +191,22 @@
const std::string formats[] = { "%4u-%2u-%2u", "%4u/%2u/%2u", "%4u%2u%2u" };
const size_t formats_n = 3;
-string LicenseGenerator::normalize_date(const char * s) {
+string LicenseGenerator::normalize_date(const std::string& sDate) {
+ if(sDate.size()<8)
+ throw invalid_argument("Date string too small for known formats");
unsigned int year, month, day;
- int chread;
bool found = false;
for (size_t i = 0; i < formats_n && !found; ++i) {
- chread = sscanf(s, formats[i].c_str(), &year, &month, &day);
- if (chread == 3) {
+ const int chread = sscanf(sDate.c_str(),formats[i].c_str(),&year,&month,&day);
+ if(chread==3) {
found = true;
+ break;
}
}
- if (!found) {
- throw invalid_argument("Date not recognized.");
- }
+ if(!found)
+ throw invalid_argument("Date string did not match a known format");
ostringstream oss;
- oss << year << "-" << setfill('0') << std::setw(2) << month << "-" << day;
- //delete (facet);
+ oss << year << "-" << setfill('0') << std::setw(2) << month << "-" << setfill('0') << std::setw(2) << day;
return oss.str();
}
}
--
Gitblit v1.9.1