From 3661672789c2fe5e691f36898022a9fceeb37118 Mon Sep 17 00:00:00 2001 From: Gabriele Contini <contini.mailing@gmail.com> Date: 周六, 14 12月 2019 20:12:41 +0800 Subject: [PATCH] fix codacy warnings --- src/library/licensecc.cpp | 21 ++++++++++++++++++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/src/library/licensecc.cpp b/src/library/licensecc.cpp index dfce497..ff57cb3 100644 --- a/src/library/licensecc.cpp +++ b/src/library/licensecc.cpp @@ -5,22 +5,35 @@ // Copyright : BSD //============================================================================ +#define __STDC_WANT_LIB_EXT1__ 1 #include <fstream> #include <stdio.h> +#include <string.h> #include <stdlib.h> #include <cstring> #include <iostream> #include <licensecc/datatypes.h> #include <licensecc/licensecc.h> +#include <licensecc_properties.h> #include "limits/license_verifier.hpp" +#include "base/StringUtils.h" #include "LicenseReader.hpp" +#include "pc-identifiers.h" using namespace std; void print_error(char out_buffer[256], LicenseInfo* licenseInfo) {} -void identify_pc(IDENTIFICATION_STRATEGY pc_id_method, char chbuffer[PC_IDENTIFIER_SIZE + 1]) {} +bool identify_pc(IDENTIFICATION_STRATEGY pc_id_method, char* chbuffer, size_t bufSize) { + FUNCTION_RETURN result = FUNC_RET_BUFFER_TOO_SMALL; + if (bufSize >= sizeof(PcSignature)) { + PcSignature identifier_out; + result = generate_user_pc_signature(identifier_out, pc_id_method); + strncpy(chbuffer, identifier_out, bufSize); + } + return result == FUNC_RET_OK; +} static void mergeLicenses(const vector<LicenseInfo>& licenses, LicenseInfo* license_out) { if (license_out != nullptr) { @@ -43,8 +56,10 @@ const license::LicenseReader lr = license::LicenseReader(licenseLocation); vector<license::FullLicenseInfo> licenses; string project; - if (callerInformation != nullptr && strlen(callerInformation->project_name) > 0) { - project = string(callerInformation->project_name); + size_t str_size; + if (callerInformation != nullptr && + (str_size = license::mstrnlen_s(callerInformation->project_name, sizeof callerInformation->project_name)) > 0) { + project = string(callerInformation->project_name, str_size); } else { project = string(LCC_PROJECT_NAME); } -- Gitblit v1.9.1