From 4467a957a498b93dbcaefbad97df24b43dfbc99d Mon Sep 17 00:00:00 2001
From: gcontini <1121667+gcontini@users.noreply.github.com>
Date: 周日, 08 3月 2020 22:16:09 +0800
Subject: [PATCH] fix tests

---
 src/library/os/linux/os-linux.c |  221 +++++++++++--------------------------------------------
 1 files changed, 45 insertions(+), 176 deletions(-)

diff --git a/src/library/os/linux/os-linux.c b/src/library/os/linux/os-linux.c
index 79ec0e5..1dc23cb 100644
--- a/src/library/os/linux/os-linux.c
+++ b/src/library/os/linux/os-linux.c
@@ -1,31 +1,16 @@
-#include <stdio.h>
-#include <ctype.h>
-#include <stdlib.h>
-#include <unistd.h>
-
-#include <valgrind/memcheck.h>
 #include <paths.h>
-
-#include <stdlib.h>
-#include <stddef.h>
-#include <string.h>
-#include <unistd.h>
-#include <sys/ioctl.h>
 #include <sys/stat.h>
+#include <stdio.h>
 #include "../os.h"
-#include "public-key.h"
 #include "../../base/logger.h"
-
-#include <openssl/evp.h>
-#include <openssl/bio.h>
-#include <openssl/pem.h>
-#include <openssl/err.h>
 
 #include <mntent.h>
 #include <dirent.h>
-#include <stdio.h>
-
 #include <sys/utsname.h>
+#ifdef _DEBUG
+#include <valgrind/memcheck.h>
+#endif
+
 #ifdef USE_DBUS
 #include <dbus-1.0/dbus/dbus.h>
 #endif
@@ -36,24 +21,22 @@
  *@param uuid uuid as read in /dev/disk/by-uuid
  *@param buffer_out: unsigned char buffer[8] output buffer for result
  */
-static void parseUUID(const char *uuid, unsigned char* buffer_out,
-		unsigned int out_size) {
-	size_t len;
+static void parseUUID(const char *uuid, unsigned char *buffer_out, unsigned int out_size) {
 	unsigned int i, j;
-	char * hexuuid;
+	char *hexuuid;
 	unsigned char cur_character;
-	//remove characters not in hex set
-	len = strlen(uuid);
-	hexuuid = (char *) malloc(sizeof(char) * strlen(uuid));
+	// remove characters not in hex set
+	size_t len = strlen(uuid);
+	hexuuid = (char *)malloc(sizeof(char) * len);
 	memset(buffer_out, 0, out_size);
-	memset(hexuuid, 0, sizeof(char) * strlen(uuid));
+	memset(hexuuid, 0, sizeof(char) * len);
 
 	for (i = 0, j = 0; i < len; i++) {
 		if (isxdigit(uuid[i])) {
 			hexuuid[j] = uuid[i];
 			j++;
 		} else {
-			//skip
+			// skip
 			continue;
 		}
 	}
@@ -70,7 +53,7 @@
 }
 
 #define MAX_UNITS 20
-FUNCTION_RETURN getDiskInfos(DiskInfo * diskInfos, size_t * disk_info_size) {
+FUNCTION_RETURN getDiskInfos(DiskInfo *diskInfos, size_t *disk_info_size) {
 	struct stat mount_stat, sym_stat;
 	/*static char discard[1024];
 	 char device[64], name[64], type[64];
@@ -79,11 +62,11 @@
 	struct mntent *ent;
 
 	int maxDrives, currentDrive, i, drive_found;
-	__ino64_t *statDrives;
-	DiskInfo *tmpDrives;
-	FILE *aFile;
-	DIR *disk_by_uuid_dir, *disk_by_label;
-	struct dirent *dir;
+	__ino64_t *statDrives = NULL;
+	DiskInfo *tmpDrives = NULL;
+	FILE *aFile = NULL;
+	DIR *disk_by_uuid_dir = NULL, *disk_by_label = NULL;
+	struct dirent *dir = NULL;
 	FUNCTION_RETURN result;
 
 	if (diskInfos != NULL) {
@@ -91,26 +74,25 @@
 		tmpDrives = diskInfos;
 	} else {
 		maxDrives = MAX_UNITS;
-		tmpDrives = (DiskInfo *) malloc(sizeof(DiskInfo) * maxDrives);
+		tmpDrives = (DiskInfo *)malloc(sizeof(DiskInfo) * maxDrives);
 	}
 	memset(tmpDrives, 0, sizeof(DiskInfo) * maxDrives);
-	statDrives = (__ino64_t *) malloc(maxDrives * sizeof(__ino64_t ));
-	memset(statDrives, 0, sizeof(__ino64_t ) * maxDrives);
-	;
+	statDrives = (__ino64_t *)malloc(maxDrives * sizeof(__ino64_t));
+	memset(statDrives, 0, sizeof(__ino64_t) * maxDrives);
 
 	aFile = setmntent("/proc/mounts", "r");
 	if (aFile == NULL) {
 		/*proc not mounted*/
+		free(tmpDrives);
+		free(statDrives);
 		return FUNC_RET_ERROR;
 	}
 
 	currentDrive = 0;
 	while (NULL != (ent = getmntent(aFile))) {
-		if ((strncmp(ent->mnt_type, "ext", 3) == 0
-				|| strncmp(ent->mnt_type, "vfat", 4) == 0
-				|| strncmp(ent->mnt_type, "ntfs", 4) == 0)
-				&& ent->mnt_fsname != NULL
-				&& strncmp(ent->mnt_fsname, "/dev/", 5) == 0) {
+		if ((strncmp(ent->mnt_type, "ext", 3) == 0 || strncmp(ent->mnt_type, "xfs", 3) == 0 ||
+			 strncmp(ent->mnt_type, "vfat", 4) == 0 || strncmp(ent->mnt_type, "ntfs", 4) == 0) &&
+			ent->mnt_fsname != NULL && strncmp(ent->mnt_fsname, "/dev/", 5) == 0) {
 			if (stat(ent->mnt_fsname, &mount_stat) == 0) {
 				drive_found = -1;
 				for (i = 0; i < currentDrive; i++) {
@@ -120,8 +102,8 @@
 				}
 				if (drive_found == -1) {
 					LOG_DEBUG("mntent: %s %s %d\n", ent->mnt_fsname, ent->mnt_dir,
-							(unsigned long int)mount_stat.st_ino);
-					strcpy(tmpDrives[currentDrive].device, ent->mnt_fsname);
+							  (unsigned long int)mount_stat.st_ino);
+					strncpy(tmpDrives[currentDrive].device, ent->mnt_fsname, 255 - 1);
 					statDrives[currentDrive] = mount_stat.st_ino;
 					drive_found = currentDrive;
 					currentDrive++;
@@ -139,7 +121,7 @@
 	if (diskInfos == NULL) {
 		*disk_info_size = currentDrive;
 		free(tmpDrives);
-		result = FUNC_RET_OK;
+		result = (currentDrive > 0) ? FUNC_RET_OK : FUNC_RET_NOT_AVAIL;
 	} else if (*disk_info_size >= currentDrive) {
 		disk_by_uuid_dir = opendir("/dev/disk/by-uuid");
 		if (disk_by_uuid_dir == NULL) {
@@ -155,17 +137,12 @@
 			if (stat(cur_dir, &sym_stat) == 0) {
 				for (i = 0; i < currentDrive; i++) {
 					if (sym_stat.st_ino == statDrives[i]) {
-						parseUUID(dir->d_name, tmpDrives[i].disk_sn,
-								sizeof(tmpDrives[i].disk_sn));
+						parseUUID(dir->d_name, tmpDrives[i].disk_sn, sizeof(tmpDrives[i].disk_sn));
 #ifdef _DEBUG
 						VALGRIND_CHECK_VALUE_IS_DEFINED(tmpDrives[i].device);
 
-						LOG_DEBUG("uuid %d %s %02x%02x%02x%02x\n", i,
-								tmpDrives[i].device,
-								tmpDrives[i].disk_sn[0],
-								tmpDrives[i].disk_sn[1],
-								tmpDrives[i].disk_sn[2],
-								tmpDrives[i].disk_sn[3]);
+						LOG_DEBUG("uuid %d %s %02x%02x%02x%02x\n", i, tmpDrives[i].device, tmpDrives[i].disk_sn[0],
+								  tmpDrives[i].disk_sn[1], tmpDrives[i].disk_sn[2], tmpDrives[i].disk_sn[3]);
 #endif
 					}
 				}
@@ -181,9 +158,8 @@
 				if (stat(cur_dir, &sym_stat) == 0) {
 					for (i = 0; i < currentDrive; i++) {
 						if (sym_stat.st_ino == statDrives[i]) {
-							strncpy(tmpDrives[i].label, dir->d_name, 255);
-							printf("label %d %s %s\n", i, tmpDrives[i].label,
-									tmpDrives[i].device);
+							strncpy(tmpDrives[i].label, dir->d_name, 255 - 1);
+							printf("label %d %s %s\n", i, tmpDrives[i].label, tmpDrives[i].device);
 						}
 					}
 				}
@@ -213,30 +189,18 @@
 	return result;
 }
 
-void os_initialize() {
-	static int initialized = 0;
-	if (initialized == 0) {
-		initialized = 1;
-		ERR_load_ERR_strings();
-		ERR_load_crypto_strings();
-		OpenSSL_add_all_algorithms();
-	}
-}
-
-static void _getCpuid(unsigned int* p, unsigned int ax) {
-	__asm __volatile
-	( "movl %%ebx, %%esi\n\t"
-			"cpuid\n\t"
-			"xchgl %%ebx, %%esi"
-			: "=a" (p[0]), "=S" (p[1]),
-			"=c" (p[2]), "=d" (p[3])
-			: "0" (ax)
-	);
+static void _getCpuid(unsigned int *p, unsigned int ax) {
+	__asm __volatile(
+		"movl %%ebx, %%esi\n\t"
+		"cpuid\n\t"
+		"xchgl %%ebx, %%esi"
+		: "=a"(p[0]), "=S"(p[1]), "=c"(p[2]), "=d"(p[3])
+		: "0"(ax));
 }
 
 FUNCTION_RETURN getCpuId(unsigned char identifier[6]) {
 	unsigned int i;
-	unsigned int cpuinfo[4] = { 0, 0, 0, 0 };
+	unsigned int cpuinfo[4] = {0, 0, 0, 0};
 	_getCpuid(cpuinfo, 0);
 	for (i = 0; i < 3; i++) {
 		identifier[i * 2] = cpuinfo[i] & 0xFF;
@@ -245,28 +209,7 @@
 	return FUNC_RET_OK;
 }
 
-VIRTUALIZATION getVirtualization() {
-//http://www.ibiblio.org/gferg/ldp/GCC-Inline-Assembly-HOWTO.html
-//
-//bool rc = true;
-	/*__asm__ (
-	 "push   %edx\n"
-	 "push   %ecx\n"
-	 "push   %ebx\n"
-	 "mov    %eax, 'VMXh'\n"
-	 "mov    %ebx, 0\n" // any value but not the MAGIC VALUE
-	 "mov    %ecx, 10\n"// get VMWare version
-	 "mov    %edx, 'VX'\n"// port number
-	 "in     %eax, dx\n"// read port on return EAX returns the VERSION
-	 "cmp    %ebx, 'VMXh'\n"// is it a reply from VMWare?
-	 "setz   [rc] \n"// set return value
-	 "pop    %ebx \n"
-	 "pop    %ecx \n"
-	 "pop    %edx \n"
-	 );*/
 
-	return NONE;
-}
 
 FUNCTION_RETURN getMachineName(unsigned char identifier[6]) {
 	static struct utsname u;
@@ -280,7 +223,7 @@
 
 FUNCTION_RETURN getOsSpecificIdentifier(unsigned char identifier[6]) {
 #if USE_DBUS
-	char* dbus_id = dbus_get_local_machine_id();
+	char *dbus_id = dbus_get_local_machine_id();
 	if (dbus_id == NULL) {
 		return FUNC_RET_ERROR;
 	}
@@ -294,7 +237,7 @@
 
 FUNCTION_RETURN getModuleName(char buffer[MAX_PATH]) {
 	FUNCTION_RETURN result;
-	char path[MAX_PATH] = { 0 };
+	char path[MAX_PATH] = {0};
 	char proc_path[MAX_PATH], pidStr[64];
 	pid_t pid = getpid();
 	sprintf(pidStr, "%d", pid);
@@ -302,7 +245,7 @@
 	strcat(proc_path, pidStr);
 	strcat(proc_path, "/exe");
 
-	int ch = readlink(proc_path, path, MAX_PATH);
+	int ch = readlink(proc_path, path, MAX_PATH - 1);
 	if (ch != -1) {
 		path[ch] = '\0';
 		strncpy(buffer, path, ch);
@@ -310,79 +253,5 @@
 	} else {
 		result = FUNC_RET_ERROR;
 	}
-	return result;
-}
-
-static void free_resources(EVP_PKEY* pkey, EVP_MD_CTX* mdctx) {
-	if (pkey) {
-		EVP_PKEY_free(pkey);
-	}
-	if (mdctx) {
-		EVP_MD_CTX_destroy(mdctx);
-	}
-}
-
-FUNCTION_RETURN verifySignature(const char* stringToVerify,
-		const char* signatureB64) {
-	EVP_MD_CTX *mdctx = NULL;
-	const char *pubKey = PUBLIC_KEY;
-	int func_ret = 0;
-
-	BIO* bio = BIO_new_mem_buf((void*) (pubKey), strlen(pubKey));
-	RSA *rsa = PEM_read_bio_RSAPublicKey(bio, NULL, NULL, NULL);
-	BIO_free(bio);
-	if (rsa == NULL) {
-		LOG_ERROR("Error reading public key");
-		return FUNC_RET_ERROR;
-	}
-	EVP_PKEY *pkey = EVP_PKEY_new();
-	EVP_PKEY_assign_RSA(pkey, rsa);
-
-	/*BIO* bo = BIO_new(BIO_s_mem());
-	 BIO_write(bo, pubKey, strlen(pubKey));
-	 RSA *key = 0;
-	 PEM_read_bio_RSAPublicKey(bo, &key, 0, 0);
-	 BIO_free(bo);*/
-
-//RSA* rsa = EVP_PKEY_get1_RSA( key );
-//RSA * pubKey = d2i_RSA_PUBKEY(NULL, <der encoded byte stream pointer>, <num bytes>);
-	unsigned char buffer[512];
-	BIO* b64 = BIO_new(BIO_f_base64());
-	BIO* encoded_signature = BIO_new_mem_buf((void *) signatureB64,
-			strlen(signatureB64));
-	BIO* biosig = BIO_push(b64, encoded_signature);
-	BIO_set_flags(biosig, BIO_FLAGS_BASE64_NO_NL); //Do not use newlines to flush buffer
-	unsigned int len = BIO_read(biosig, (void *) buffer, strlen(signatureB64));
-//Can test here if len == decodeLen - if not, then return an error
-	buffer[len] = 0;
-
-	BIO_free_all(biosig);
-
-	/* Create the Message Digest Context */
-	if (!(mdctx = EVP_MD_CTX_create())) {
-		free_resources(pkey, mdctx);
-		LOG_ERROR("Error creating context");
-		return FUNC_RET_ERROR;
-	}
-	if (1 != EVP_DigestVerifyInit(mdctx, NULL, EVP_sha256(), NULL, pkey)) {
-		LOG_ERROR("Error initializing digest");
-		free_resources(pkey, mdctx);
-		return FUNC_RET_ERROR;
-	}
-	int en = strlen(stringToVerify);
-	func_ret = EVP_DigestVerifyUpdate(mdctx, stringToVerify, en);
-	if (1 != func_ret) {
-		LOG_ERROR("Error verifying digest %d", func_ret);
-		free_resources(pkey, mdctx);
-		return FUNC_RET_ERROR;
-	}
-	FUNCTION_RETURN result;
-	func_ret = EVP_DigestVerifyFinal(mdctx, buffer, len);
-	if (1 != func_ret) {
-		LOG_ERROR("Error verifying digest %d", func_ret);
-	}
-	result = (1 == func_ret ? FUNC_RET_OK : FUNC_RET_ERROR);
-
-	free_resources(pkey, mdctx);
 	return result;
 }

--
Gitblit v1.9.1