From 7c2489cc3dc798484e11a449fd0e305210de901b Mon Sep 17 00:00:00 2001
From: gcontini <1121667+gcontini@users.noreply.github.com>
Date: 周六, 14 12月 2019 20:12:41 +0800
Subject: [PATCH] fix codacy warnings
---
src/library/base/logger.c | 17 +++++++++--------
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/library/base/logger.c b/src/library/base/logger.c
index 4ee8354..30db85d 100644
--- a/src/library/base/logger.c
+++ b/src/library/base/logger.c
@@ -4,8 +4,9 @@
#include <string.h>
#include <stdarg.h>
#include <time.h>
-#include <unistd.h>
+
#ifdef __unix__
+#include <unistd.h>
#define MAX_PATH 255
#else
#include <windows.h>
@@ -25,26 +26,26 @@
static void getLogFname(char* logpath) {
#ifdef __unix__
- char const *folder = getenv("TMPDIR");
+ const char *folder = getenv("TMPDIR");
if (folder == 0) {
folder = "/tmp";
}
- strcpy(logpath, folder);
- strcat(logpath, "/open-license.log");
+ strncpy(logpath, folder, MAX_PATH);
+ strncat(logpath, "/open-license.log", MAX_PATH - strlen(logpath));
#else
- int plen=GetTempPath(MAX_PATH,logpath);
+ const int plen = GetTempPath(MAX_PATH, logpath);
if(plen == 0) {
fprintf(stderr, "Error getting temporary directory path");
}
- strcat(logpath,"open-license.log");
+ strncat(logpath, "open-license.log", MAX_PATH - strlen(logpath));
#endif
}
-void _log(char* format, ...) {
- char logpath[MAX_PATH];
+void _log(const char* format, ...) {
va_list args;
char * buffer;
if (logFile == NULL) {
+ char logpath[MAX_PATH];
getLogFname(logpath);
logFile = fopen(logpath, "a");
if (logFile == NULL) {
--
Gitblit v1.9.1