From 8ad56e8eda4a63e9a81c275e4eb26e9239237ad4 Mon Sep 17 00:00:00 2001 From: gcontini <1121667+gcontini@users.noreply.github.com> Date: 周六, 28 11月 2020 09:31:41 +0800 Subject: [PATCH] replace strncpy with a more safe alternative --- src/library/base/logger.cpp | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/library/base/logger.cpp b/src/library/base/logger.cpp index 580d1cf..fdd5033 100644 --- a/src/library/base/logger.cpp +++ b/src/library/base/logger.cpp @@ -29,7 +29,7 @@ static void getLogFname(char* logpath) { #ifdef __unix__ const char *folder = getenv("TMPDIR"); - if (folder == 0) { + if (folder == nullptr) { folder = "/tmp"; } strncpy(logpath, folder, MAX_PATH); @@ -51,13 +51,11 @@ getLogFname(logpath); logFile = fopen(logpath, "a"); if (logFile == NULL) { - //what shall we do here? return; } } buffer = (char *) malloc(sizeof(char) * strlen(format) + 64); timenow(buffer); - sprintf(&buffer[strlen(buffer) - 1], "-[%d]-", getpid()); strcat(buffer, format); va_start(args, format); vfprintf(logFile, buffer, args); -- Gitblit v1.9.1