From 8bbef2865455754425a84b86680a89bff8aa7691 Mon Sep 17 00:00:00 2001
From: gcontini <1121667+gcontini@users.noreply.github.com>
Date: 周六, 19 10月 2019 08:50:45 +0800
Subject: [PATCH] issue #64 , issue #56 (part)

---
 test/library/LicenseReader_test.cpp |  103 ++++++++++++++++++++++++++++++++++-----------------
 1 files changed, 68 insertions(+), 35 deletions(-)

diff --git a/test/library/LicenseReader_test.cpp b/test/library/LicenseReader_test.cpp
index af1b619..2198ab3 100644
--- a/test/library/LicenseReader_test.cpp
+++ b/test/library/LicenseReader_test.cpp
@@ -1,32 +1,49 @@
-#define BOOST_TEST_MODULE license_reader_test
-//#define BOOST_TEST_MAIN
-//#define BOOST_TEST_DYN_LINK
+#define BOOST_TEST_MODULE "test_license_reader"
+#include <boost/assert.hpp>
+#include <boost/test/tools/old/interface.hpp>
+#include <boost/test/unit_test_suite.hpp>
+#include <iostream>
+#include <vector>
+
+#include "../../src/library/api/datatypes.h"
+#include "../../src/library/base/EventRegistry.h"
+#include "../../src/library/os/os.h"
+
+
 #include <boost/test/unit_test.hpp>
-#include "../../src/library/LicenseReader.h"
-#include <build_properties.h>
 #include <stdlib.h>
 
-using namespace license;
+#include <build_properties.h>
+#include "../../src/library/LicenseReader.hpp"
 
+namespace test {
+using namespace license;
+using namespace std;
+/**
+ * Read license at fixed location
+ */
 BOOST_AUTO_TEST_CASE( read_single_file ) {
-	const char * licLocation =
-	PROJECT_TEST_SRC_DIR "/library/test_reader.ini";
-	const LicenseLocation location = { licLocation, NULL, false };
-	LicenseReader licenseReader(location);
+	const char *licLocation = PROJECT_TEST_SRC_DIR "/library/test_reader.ini";
+
+	const LicenseLocation location = { licLocation, nullptr };
+	LicenseReader licenseReader(&location);
 	vector<FullLicenseInfo> licenseInfos;
-	EventRegistry registry = licenseReader.readLicenses("PrODUCT",
+	const EventRegistry registry = licenseReader.readLicenses("PrODUCT",
 			licenseInfos);
 	BOOST_CHECK(registry.isGood());
 	BOOST_CHECK_EQUAL(1, licenseInfos.size());
 }
 
+/**
+ * Test the error return if the product code is not found in the license
+ */
 BOOST_AUTO_TEST_CASE( product_not_licensed ) {
-	const char * licLocation =
+	const char *licLocation =
 	PROJECT_TEST_SRC_DIR "/library/test_reader.ini";
-	const LicenseLocation location = { licLocation, NULL, false };
-	LicenseReader licenseReader(location);
+	const LicenseLocation location = { licLocation, nullptr };
+	LicenseReader licenseReader(&location);
 	vector<FullLicenseInfo> licenseInfos;
-	EventRegistry registry = licenseReader.readLicenses("PRODUCT-NOT",
+	const EventRegistry registry = licenseReader.readLicenses("PRODUCT-NOT",
 			licenseInfos);
 	BOOST_CHECK(!registry.isGood());
 	BOOST_CHECK_EQUAL(0, licenseInfos.size());
@@ -35,13 +52,16 @@
 			registry.getLastFailure()->event_type);
 }
 
+/**
+ * Test the error code if the license file is specified but doesn't exists
+ */
 BOOST_AUTO_TEST_CASE( file_not_found ) {
-	const char * licLocation = PROJECT_TEST_SRC_DIR "/library/not_found.ini";
+	const char *licLocation = PROJECT_TEST_SRC_DIR "/library/not_found.ini";
 	//const char * envName = "MYVAR";
-	const LicenseLocation location = { licLocation, NULL, false };
-	LicenseReader licenseReader(location);
+	const LicenseLocation location = { licLocation, nullptr };
+	LicenseReader licenseReader(&location);
 	vector<FullLicenseInfo> licenseInfos;
-	EventRegistry registry = licenseReader.readLicenses("PRODUCT",
+	const EventRegistry registry = licenseReader.readLicenses("PRODUCT",
 			licenseInfos);
 	BOOST_CHECK(!registry.isGood());
 	BOOST_CHECK_EQUAL(0, licenseInfos.size());
@@ -50,12 +70,15 @@
 			registry.getLastFailure()->event_type);
 }
 
+/**
+ * Test the error code if the license default environment variable isn't specified
+ */
 BOOST_AUTO_TEST_CASE( env_var_not_defined ) {
-	const char * envName = "MYVAR";
-	const LicenseLocation location = { NULL, envName, false };
-	LicenseReader licenseReader(location);
+	UNSETENV(LICENSE_LOCATION_ENV_VAR);
+	const LicenseLocation location = { nullptr, nullptr };
+	LicenseReader licenseReader(&location);
 	vector<FullLicenseInfo> licenseInfos;
-	EventRegistry registry = licenseReader.readLicenses("PRODUCT",
+	const EventRegistry registry = licenseReader.readLicenses("PRODUCT",
 			licenseInfos);
 	BOOST_CHECK(!registry.isGood());
 	BOOST_CHECK_EQUAL(0, licenseInfos.size());
@@ -64,16 +87,26 @@
 			registry.getLastFailure()->event_type);
 }
 
-BOOST_AUTO_TEST_CASE( read_env_var ) {
-	char str[MAX_PATH];
-	strcpy(str,"LIC_VAR=" PROJECT_TEST_SRC_DIR "/library/test_reader.ini");
-	putenv(str);
-	const LicenseLocation location = { NULL, "LIC_VAR", false };
-	LicenseReader licenseReader(location);
-	vector<FullLicenseInfo> licenseInfos;
-	EventRegistry registry = licenseReader.readLicenses("PrODUCT",
-			licenseInfos);
-	BOOST_CHECK(registry.isGood());
-	BOOST_CHECK_EQUAL(1, licenseInfos.size());
-}
+/**
+ * Test the error code if the license default environment variable is
+ * specified but points to a non existent file.
+ */
+BOOST_AUTO_TEST_CASE( env_var_point_to_wrong_file ) {
+	const char *environment_variable_value =
+	PROJECT_TEST_SRC_DIR "/this/file/doesnt/exist";
+	SETENV(LICENSE_LOCATION_ENV_VAR, environment_variable_value)
 
+	const LicenseLocation location = { nullptr, nullptr };
+	LicenseReader licenseReader(&location);
+	vector<FullLicenseInfo> licenseInfos;
+	const EventRegistry registry = licenseReader.readLicenses("PRODUCT",
+			licenseInfos);
+	cout << registry << endl;
+	BOOST_CHECK(!registry.isGood());
+	BOOST_CHECK_EQUAL(0, licenseInfos.size());
+	BOOST_ASSERT(registry.getLastFailure()!=NULL);
+	BOOST_CHECK_EQUAL(LICENSE_FILE_NOT_FOUND,
+			registry.getLastFailure()->event_type);
+	UNSETENV(LICENSE_LOCATION_ENV_VAR);
+}
+} /* namespace test*/

--
Gitblit v1.9.1