From 907a46213e5ca3e741744f67ad71966b70b89e38 Mon Sep 17 00:00:00 2001
From: gcontini <1121667+gcontini@users.noreply.github.com>
Date: 周六, 05 12月 2020 23:38:40 +0800
Subject: [PATCH] fix Codacy warnings
---
src/library/LicenseReader.cpp | 22 ++++++++++------------
1 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/src/library/LicenseReader.cpp b/src/library/LicenseReader.cpp
index 9aa53ab..4d2792c 100644
--- a/src/library/LicenseReader.cpp
+++ b/src/library/LicenseReader.cpp
@@ -22,28 +22,26 @@
#include <stdlib.h>
#include <math.h>
-#include <public_key.h>
-#include <licensecc_properties.h>
#include <licensecc/licensecc.h>
#include "base/base.h"
-#include "pc-identifiers.h"
#include "LicenseReader.hpp"
-#include "base/StringUtils.h"
+#include "base/string_utils.h"
#include "base/logger.h"
#include "locate/LocatorFactory.hpp"
namespace license {
+using namespace std;
FullLicenseInfo::FullLicenseInfo(const string &source, const string &product, const string &license_signature)
: source(source),
m_project(product), //
- license_signature(license_signature) {}
+ license_signature(license_signature),
+ m_magic(0) {}
LicenseReader::LicenseReader(const LicenseLocation *licenseLocation) : licenseLocation(licenseLocation) {}
-EventRegistry LicenseReader::readLicenses(const string &product, vector<FullLicenseInfo> &licenseInfoOut) {
- vector<string> diskFiles;
+EventRegistry LicenseReader::readLicenses(const string &product, vector<FullLicenseInfo> &licenseInfoOut) const {
vector<unique_ptr<locate::LocatorStrategy>> locator_strategies;
FUNCTION_RETURN ret = locate::LocatorFactory::get_active_strategies(locator_strategies, licenseLocation);
EventRegistry eventRegistry;
@@ -64,7 +62,7 @@
CSimpleIniA ini;
for (auto it = licenseLocations.begin(); it != licenseLocations.end(); it++) {
ini.Reset();
- string license = locator->retrieve_license_content((*it).c_str());
+ const string license = locator->retrieve_license_content((*it).c_str());
const SI_Error rc = ini.LoadData(license.c_str(), license.size());
if (rc < 0) {
eventRegistry.addEvent(FILE_FORMAT_NOT_RECOGNIZED, *it);
@@ -82,7 +80,7 @@
* sw_version_to = (optional int)
* from_date = YYYY-MM-DD (optional)
* to_date = YYYY-MM-DD (optional)
- * client_signature = XXXX-XXXX-XXXX-XXXX (optional string 16)
+ * client_signature = XXXX-XXXX-XXXX (optional string 16)
* sig = XXXXXXXXXX (mandatory, 1024)
* application_data = xxxxxxxxx (optional string 16)
*/
@@ -114,13 +112,13 @@
ostringstream oss;
oss << toupper_copy(trim_copy(m_project));
for (auto &it : m_limits) {
- if (it.first != LICENSE_VERSION && it.first != LICENSE_SIGNATURE) {
+ if (it.first != LICENSE_SIGNATURE) {
oss << trim_copy(it.first) << trim_copy(it.second);
}
}
-#ifdef _DEBUG
- cout << "[" << oss.str() << "]" << endl;
+#ifndef NDEBUG
+ cout << "license to sign [" << oss.str() << "]" << endl;
#endif
return oss.str();
}
--
Gitblit v1.9.1