From 907a46213e5ca3e741744f67ad71966b70b89e38 Mon Sep 17 00:00:00 2001
From: gcontini <1121667+gcontini@users.noreply.github.com>
Date: 周六, 05 12月 2020 23:38:40 +0800
Subject: [PATCH] fix Codacy warnings
---
src/library/os/windows/os_win.cpp | 20 +++++++++++---------
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/src/library/os/windows/os_win.cpp b/src/library/os/windows/os_win.cpp
index ccb3652..73ed550 100644
--- a/src/library/os/windows/os_win.cpp
+++ b/src/library/os/windows/os_win.cpp
@@ -5,6 +5,7 @@
#include <iphlpapi.h>
#include <stdio.h>
+#include "../../base/string_utils.h"
#include "../../base/logger.h"
#include "../os.h"
using namespace std;
@@ -23,13 +24,13 @@
// http://www.ok-soft-gmbh.com/ForStackOverflow/EnumMassStorage.c
// http://stackoverflow.com/questions/3098696/same-code-returns-diffrent-result-on-windows7-32-bit-system
-#define MAX_UNITS 30
+#define MAX_UNITS 40
// bug check return with diskinfos == null func_ret_ok
FUNCTION_RETURN getDiskInfos(std::vector<DiskInfo>& diskInfos) {
DWORD fileMaxLen;
- size_t ndrives = 0;
+ size_t ndrives = 0, drives_scanned = 0;
DWORD fileFlags;
- char volName[MAX_PATH], fileSysName[MAX_PATH];
+ char volName[MAX_PATH];
DWORD volSerial = 0;
const DWORD dwSize = MAX_PATH;
char szLogicalDrives[MAX_PATH] = {0};
@@ -40,22 +41,21 @@
if (dwResult > 0) {
return_value = FUNC_RET_OK;
char* szSingleDrive = szLogicalDrives;
- while (*szSingleDrive && ndrives < MAX_UNITS) {
+ while (*szSingleDrive && drives_scanned < MAX_UNITS) {
// get the next drive
UINT driveType = GetDriveType(szSingleDrive);
if (driveType == DRIVE_FIXED) {
+ char fileSysName[MAX_PATH];
BOOL success = GetVolumeInformation(szSingleDrive, volName, MAX_PATH, &volSerial, &fileMaxLen,
&fileFlags, fileSysName, MAX_PATH);
if (success) {
LOG_DEBUG("drive: %s,volume Name: %s, Volume Serial: 0x%x,Filesystem: %s", szSingleDrive, volName,
volSerial, fileSysName);
- DiskInfo diskInfo;
- memset(&diskInfo, 0, sizeof(diskInfo));
+ DiskInfo diskInfo = {};
diskInfo.id = (int)ndrives;
diskInfo.label_initialized = true;
- strncpy(diskInfo.device, volName, min(std::size_t{MAX_PATH}, sizeof(volName)) - 1);
- strncpy(diskInfo.label, fileSysName,
- min(sizeof(diskInfos[ndrives].label), sizeof(fileSysName)) - 1);
+ mstrlcpy(diskInfo.device, volName, min(std::size_t{MAX_PATH}, sizeof(volName)));
+ mstrlcpy(diskInfo.label, fileSysName, min(sizeof(diskInfos[ndrives].label), sizeof(fileSysName)));
memcpy(diskInfo.disk_sn, &volSerial, sizeof(DWORD));
diskInfo.sn_initialized = true;
diskInfo.preferred = (szSingleDrive[0] == 'C');
@@ -67,6 +67,8 @@
} else {
LOG_DEBUG("This volume is not fixed : %s, type: %d", szSingleDrive);
}
+ szSingleDrive += strlen(szSingleDrive) + 1;
+ drives_scanned++;
}
}
if (diskInfos.size() > 0) {
--
Gitblit v1.9.1