From 9c33ad84278353286bbb4118cd11ca3fcfec439a Mon Sep 17 00:00:00 2001 From: gcontini <1121667+gcontini@users.noreply.github.com> Date: 周六, 31 10月 2020 23:36:25 +0800 Subject: [PATCH] codacy cleanup --- src/library/os/linux/execution_environment.cpp | 14 ++++++-------- 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/library/os/linux/execution_environment.cpp b/src/library/os/linux/execution_environment.cpp index 75520eb..1ca0cd0 100644 --- a/src/library/os/linux/execution_environment.cpp +++ b/src/library/os/linux/execution_environment.cpp @@ -1,9 +1,10 @@ /* - * virtualization.cpp + * execution_environment.cpp * * Created on: Dec 15, 2019 * Author: GC */ +#define __STDC_WANT_LIB_EXT1__1 #include <paths.h> #include <sys/stat.h> #include <unistd.h> @@ -31,10 +32,10 @@ char path[MAX_PATH] = {0}; char proc_path[MAX_PATH], pidStr[64]; pid_t pid = getpid(); - sprintf(pidStr, "%d", pid); - strcpy(proc_path, "/proc/"); - strcat(proc_path, pidStr); - strcat(proc_path, "/cgroup"); + snprintf(pidStr, sizeof(pidStr), "%d", pid); + strncpy(proc_path, "/proc/", sizeof(proc_path)); + strncat(proc_path, pidStr, sizeof(proc_path)); + strncpy(proc_path, "/cgroup", sizeof(proc_path)); FILE *fp; char *line = NULL; @@ -48,9 +49,6 @@ } while ((read = getline(&line, &len, fp)) != -1 && result == 0) { - // line[len]=0; - // printf("Retrieved line of length %zu:\n", read); - // printf("%s", line); if (strstr(line, "docker") != NULL) { result = CONTAINER_TYPE::DOCKER; } -- Gitblit v1.9.1