From f91f5aae33291486780c9c03d4f2a1b94a89ba06 Mon Sep 17 00:00:00 2001
From: Jan Willamowius <jan@willamowius.de>
Date: 周日, 21 4月 2019 23:58:42 +0800
Subject: [PATCH] leave room fr terminating nul byte

---
 test/functional/volid_test.cpp |   87 ++++++++++++++++++++++++++-----------------
 1 files changed, 53 insertions(+), 34 deletions(-)

diff --git a/test/functional/volid_test.cpp b/test/functional/volid_test.cpp
index de17e53..2de9a04 100644
--- a/test/functional/volid_test.cpp
+++ b/test/functional/volid_test.cpp
@@ -1,11 +1,12 @@
 #define BOOST_TEST_MODULE standard_license_test
 //#define BOOST_TEST_MAIN
-#define BOOST_TEST_DYN_LINK
+//#undef BOOST_TEST_DYN_LINK
 #include <boost/test/unit_test.hpp>
 #include <fstream>
+#include <stdio.h>
 #include <cstring>
-#include "../../../src/license-generator/license-generator.h"
-#include "../../../src/library/api/license++.h"
+#include "../../src/tools/license-generator/license-generator.h"
+#include "../../src/library/api/license++.h"
 #include <build_properties.h>
 #include <boost/filesystem.hpp>
 #include "../../src/library/ini/SimpleIni.h"
@@ -21,11 +22,14 @@
 	PcSignature identifier_out;
 
 	IDENTIFICATION_STRATEGY strategy = IDENTIFICATION_STRATEGY::ETHERNET;
+	BOOST_TEST_CHECKPOINT("Before generate");
 	FUNCTION_RETURN generate_ok = generate_user_pc_signature(identifier_out,
 			strategy);
-	BOOST_ASSERT(generate_ok == FUNCTION_RETURN::OK);
+	BOOST_ASSERT(generate_ok == FUNCTION_RETURN::FUNC_RET_OK);
 	cout << "Identifier:" << identifier_out << endl;
-	vector<string> extraArgs = { "-s", identifier_out };
+	vector<string> extraArgs;
+    extraArgs.push_back("-s");
+    extraArgs.push_back(identifier_out);
 	generate_license(licLocation, extraArgs);
 
 	LicenseInfo license;
@@ -38,7 +42,7 @@
 	BOOST_CHECK_EQUAL(license.has_expiry, false);
 	BOOST_CHECK_EQUAL(license.linked_to_pc, true);
 }
-
+			  
 static void generate_reference_file(const string& idfileLocation,
 		IDENTIFICATION_STRATEGY strategies[], int num_strategies) {
 	ofstream idfile(idfileLocation);
@@ -46,8 +50,13 @@
 	for (int i = 0; i < num_strategies; i++) {
 		FUNCTION_RETURN generate_ok = generate_user_pc_signature(identifier_out,
 				strategies[i]);
-		BOOST_ASSERT(generate_ok == FUNCTION_RETURN::OK);
-		idfile << identifier_out << endl;
+        BOOST_ASSERT(generate_ok == FUNC_RET_OK);
+		if (generate_ok != FUNC_RET_OK){
+			BOOST_ERROR("Generating identifier for strategy " << strategies[i] << " failed with: " << generate_ok);
+            idfile << "0000-0000-0000-0000" << endl;
+		}
+        else
+            idfile << identifier_out << endl;
 	}
 	idfile.close();
 }
@@ -55,46 +64,56 @@
 BOOST_AUTO_TEST_CASE(generated_identifiers_stability) {
 	const string idfileLocation(PROJECT_TEST_TEMP_DIR "/identifiers_file");
 	IDENTIFICATION_STRATEGY strategies[] =
-			{ IDENTIFICATION_STRATEGY::DEFAULT,
-					IDENTIFICATION_STRATEGY::DISK_LABEL,
-					IDENTIFICATION_STRATEGY::DISK_NUM,
-					IDENTIFICATION_STRATEGY::ETHERNET };
+			{ DEFAULT,
+					DISK_LABEL,
+					DISK_NUM,
+					ETHERNET };
 	const int num_strategies = sizeof(strategies) / sizeof(strategies[0]);
 	std::ifstream test_idfile_exist(idfileLocation);
-	if (!test_idfile_exist.good()) {
-		generate_reference_file(idfileLocation, strategies, num_strategies);
-	}
-	std::ifstream is(idfileLocation);
-	std::istream_iterator<string> start(is), end;
-	std::vector<string> reference_signatures(start, end);
-	BOOST_CHECK_EQUAL(reference_signatures.size(), num_strategies);
-	PcSignature generated_identifier;
-	BOOST_CHECKPOINT("Generating current signatures and comparing with past");
+    if (!test_idfile_exist.good()){
+        generate_reference_file(idfileLocation, strategies, num_strategies);
+    }
+    else{
+        std::istream_iterator<string> start(test_idfile_exist), end;
+        std::vector<string> reference_signatures(start, end);
+        test_idfile_exist.close();
+        if (reference_signatures.size() != num_strategies ||
+            std::find(reference_signatures.begin(), reference_signatures.end(), "0000-0000-0000-0000") != reference_signatures.end())
+            generate_reference_file(idfileLocation, strategies, num_strategies);
+    }
+    std::ifstream is(idfileLocation);
+    std::istream_iterator<string> start(is), end;
+    std::vector<string> reference_signatures(start, end);
+	BOOST_TEST_CHECKPOINT("Generating current signatures and comparing with past");
 	for (int i = 0; i < num_strategies; i++) {
+        PcSignature generated_identifier;
 		FUNCTION_RETURN generate_ok = generate_user_pc_signature(
 				generated_identifier, strategies[i]);
-		BOOST_ASSERT(generate_ok == FUNCTION_RETURN::OK);
-		if (memcmp(generated_identifier, reference_signatures[i].c_str(),
-				sizeof(PcSignature))) {
-			string message = string("pc signature compare fail: strategy:")
-					+ to_string(strategies[i]) + " generated: ["
+		BOOST_ASSERT(generate_ok == FUNCTION_RETURN::FUNC_RET_OK);
+        if (generate_ok != FUNC_RET_OK){
+			BOOST_ERROR("Generating identifier for strategy " << strategies[i] << " failed with: " << generate_ok);
+            continue;
+        }
+		if (reference_signatures[i] != generated_identifier) {
+			string message = string("pc signature compare fail: strategy: ")
+					+ to_string(static_cast<long long>(strategies[i])) + " generated: ["
 					+ generated_identifier + "] reference: ["
 					+ reference_signatures[i] + "]";
-			BOOST_FAIL(message);
+			BOOST_ERROR(message);
 		}
 	}
-
-	BOOST_CHECKPOINT("Verifying signatures");
+	BOOST_TEST_CHECKPOINT("Verifying signatures");
 	for (int j = 0; j < 100; j++) {
 		for (unsigned int i = 0; i < reference_signatures.size(); i++) {
+            if (reference_signatures[i] == "0000-0000-0000-0000")
+                continue;
 			PcSignature pcsig;
-			memcpy(pcsig, reference_signatures[i].c_str(), sizeof(PcSignature));
+			strncpy(pcsig, reference_signatures[i].c_str(),
+					sizeof(PcSignature)-1);
 			EVENT_TYPE val_result = validate_pc_signature(pcsig);
-			string message = string("pc signature verification strategy:")
-					+ to_string(i) + " generated: [" + generated_identifier
-					+ "] reference: [" + reference_signatures[i] + "]";
-			BOOST_CHECKPOINT("Verifying signature: ");
+			BOOST_TEST_CHECKPOINT("Verifying signature: ");
 			BOOST_CHECK_EQUAL(val_result, LICENSE_OK);
 		}
 	}
 }
+

--
Gitblit v1.9.1