From 326b23bf678301a72cb9d67ac64347dd5ce49a37 Mon Sep 17 00:00:00 2001 From: Yuhang Zhao <zhaoyuhang@rankyee.com> Date: 周一, 18 12月 2023 14:27:11 +0800 Subject: [PATCH] optimize mac again --- src/core/contexts/cocoawindowcontext.mm | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/core/contexts/cocoawindowcontext.mm b/src/core/contexts/cocoawindowcontext.mm index 86f8597..a8673b8 100644 --- a/src/core/contexts/cocoawindowcontext.mm +++ b/src/core/contexts/cocoawindowcontext.mm @@ -217,6 +217,12 @@ return it.value(); } + static inline void releaseWindowProxy(const WId windowId) { + if (const auto proxy = g_proxyList()->take(windowId)) { + delete proxy; + } + } + class CocoaWindowEventFilter : public QObject { public: explicit CocoaWindowEventFilter(AbstractWindowContext *context, QObject *parent = nullptr); @@ -355,9 +361,7 @@ } CocoaWindowContext::~CocoaWindowContext() { - if (const auto proxy = g_proxyList()->take(windowId)) { - delete proxy; - } + releaseWindowProxy(windowId); } QString CocoaWindowContext::key() const { @@ -379,6 +383,7 @@ } void CocoaWindowContext::winIdChanged(QWindow *oldWindow, bool destroyed) { + releaseWindowProxy(windowId); windowId = m_windowHandle->winId(); ensureWindowProxy(windowId)->setSystemTitleBarVisible(false); cocoaWindowEventFilter = std::make_unique<CocoaWindowEventFilter>(this, this); -- Gitblit v1.9.1