From 40d73269371a9e2b142eb2be2bd2f70aff6346d2 Mon Sep 17 00:00:00 2001
From: Sine Striker <trueful@163.com>
Date: 周日, 25 2月 2024 04:13:02 +0800
Subject: [PATCH] Better workaround for win10 top border issue
---
src/widgets/widgetwindowagent_win.cpp | 191 +++++++++++++++++++++--------------------------
1 files changed, 85 insertions(+), 106 deletions(-)
diff --git a/src/widgets/widgetwindowagent_win.cpp b/src/widgets/widgetwindowagent_win.cpp
index 9e49d38..13af840 100644
--- a/src/widgets/widgetwindowagent_win.cpp
+++ b/src/widgets/widgetwindowagent_win.cpp
@@ -1,3 +1,7 @@
+// Copyright (C) 2023-2024 Stdware Collections (https://www.github.com/stdware)
+// Copyright (C) 2021-2023 wangwenx190 (Yuhang Zhao)
+// SPDX-License-Identifier: Apache-2.0
+
#include "widgetwindowagent_p.h"
#include <QtCore/QDebug>
@@ -5,136 +9,112 @@
#include <QtGui/QPainter>
#include <QWKCore/qwindowkit_windows.h>
-#include <QWKCore/private/nativeeventfilter_p.h>
+#include <QWKCore/private/qwkglobal_p.h>
+#include <QWKCore/private/windows10borderhandler_p.h>
namespace QWK {
-#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER)
+#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDERS)
+ // https://github.com/qt/qtbase/blob/e26a87f1ecc40bc8c6aa5b889fce67410a57a702/src/plugins/platforms/windows/qwindowsbackingstore.cpp#L42
+ // In QtWidgets applications, when repainting happens, QPA at the last calls
+ // QWindowsBackingStore::flush() to draw the contents of the buffer to the screen, we need to
+ // call GDI drawing the top border after that.
- class WidgetBorderHandler;
+ // After debugging, we know that there are two situations that will lead to repaint.
+ //
+ // 1. Windows sends a WM_PAINT message, after which Qt immediately generates a QExposeEvent or
+ // QResizeEvent and send it to the corresponding QWidgetWindow instance, calling "flush" at the
+ // end of its handler.
+ //
+ // 2. When a timer or user input triggers Qt to repaint spontaneously, the corresponding
+ // QWidget receives a QEvent::UpdateRequest event and also calls "flush" at the end of its
+ // handler.
+ //
+ // The above two cases are mutually exclusive, so we just need to intercept the two events
+ // separately and draw the border area after the "flush" is called.
- class WidgetBorderHandler : public QObject, public NativeEventFilter, public SharedEventFilter {
+ // https://github.com/qt/qtbase/blob/e26a87f1ecc40bc8c6aa5b889fce67410a57a702/src/plugins/platforms/windows/qwindowswindow.cpp#L2440
+ // Note that we can not draw the border right after WM_PAINT comes or right before the WndProc
+ // returns, because Qt calls BeginPaint() and EndPaint() itself. We should make sure that we
+ // draw the top border between these two calls, otherwise some display exceptions may arise.
+
+ class WidgetBorderHandler : public QObject, public Windows10BorderHandler {
public:
- explicit WidgetBorderHandler(QWidget *widget, AbstractWindowContext *ctx)
- : QObject(ctx), widget(widget), ctx(ctx) {
+ explicit WidgetBorderHandler(QWidget *widget, AbstractWindowContext *ctx,
+ QObject *parent = nullptr)
+ : QObject(parent), Windows10BorderHandler(ctx), widget(widget) {
widget->installEventFilter(this);
- ctx->installNativeEventFilter(this);
- ctx->installSharedEventFilter(this);
-
- updateGeometry();
- }
-
- inline bool isNormalWindow() const {
- return !(widget->windowState() &
- (Qt::WindowMinimized | Qt::WindowMaximized | Qt::WindowFullScreen));
- }
-
- void updateGeometry() {
- if (isNormalWindow()) {
- widget->setContentsMargins({
- 0,
- ctx->property("borderThickness").toInt(),
- 0,
- 0,
- });
- } else {
- widget->setContentsMargins({});
+ // First update
+ if (ctx->windowId()) {
+ setupNecessaryAttributes();
}
+ WidgetBorderHandler::updateGeometry();
+ }
+
+ void updateGeometry() override {
+ widget->setContentsMargins(isNormalWindow() ? QMargins(0, borderThickness(), 0, 0)
+ : QMargins());
+ }
+
+ bool isWindowActive() const override {
+ return widget->isActiveWindow();
+ }
+
+ inline void forwardEventToWidgetAndDraw(QWidget *w, QEvent *event) {
+ // Let the widget paint first
+ static_cast<QObject *>(w)->event(event);
+
+ // Due to the timer or user action, Qt will repaint some regions spontaneously,
+ // even if there is no WM_PAINT message, we must wait for it to finish painting
+ // and then update the top border area.
+ drawBorder();
+ }
+
+ inline void forwardEventToWindowAndDraw(QWindow *window, QEvent *event) {
+ // Let Qt paint first
+ static_cast<QObject *>(window)->event(event);
+
+ // Upon receiving the WM_PAINT message, Qt will repaint the entire view, and we
+ // must wait for it to finish painting before drawing this top border area.
+ drawBorder();
}
protected:
- bool nativeEventFilter(const QByteArray &eventType, void *message,
- QT_NATIVE_EVENT_RESULT_TYPE *result) override {
- Q_UNUSED(eventType)
- const auto msg = static_cast<const MSG *>(message);
- switch (msg->message) {
- case WM_DPICHANGED: {
- updateGeometry();
- break;
- }
-
- case WM_THEMECHANGED:
- case WM_SYSCOLORCHANGE:
- case WM_DWMCOLORIZATIONCOLORCHANGED: {
- widget->update();
- break;
- }
-
- case WM_SETTINGCHANGE: {
- if (!msg->wParam && msg->lParam &&
- std::wcscmp(reinterpret_cast<LPCWSTR>(msg->lParam), L"ImmersiveColorSet") ==
- 0) {
- widget->update();
- }
- break;
- }
-# if 0
- case WM_ACTIVATE: {
- if (LOWORD(msg->wParam) == WA_INACTIVE) {
- // 绐楀彛澶卞幓婵�娲荤姸鎬�
- } else {
- // 绐楀彛琚縺娲�
- }
- break;
- }
-# endif
-
- default:
- break;
- }
- return false;
- }
-
bool sharedEventFilter(QObject *obj, QEvent *event) override {
Q_UNUSED(obj)
auto window = widget->windowHandle();
- if (event->type() == QEvent::Expose) {
- // Qt will absolutely send a QExposeEvent to the QWindow when it receives a
- // WM_PAINT message. When the control flow enters the expose handler, Qt must
- // have already called BeginPaint() and it's the best time for us to draw the
- // top border.
- auto ee = static_cast<QExposeEvent *>(event);
- if (isNormalWindow() && window->isExposed() && !ee->region().isNull()) {
- // Friend class helping to call `event`
- class HackedWindow : public QWindow {
- public:
- friend class QWK::WidgetBorderHandler;
- };
+ switch (event->type()) {
+ case QEvent::Expose: {
+ // Qt will absolutely send a QExposeEvent or QResizeEvent to the QWindow when it
+ // receives a WM_PAINT message. When the control flow enters the expose handler,
+ // Qt must have already called BeginPaint() and it's the best time for us to
+ // draw the top border.
- // Let Qt paint first
- static_cast<HackedWindow *>(window)->event(event);
-
- // Upon receiving the WM_PAINT message, Qt will redraw the entire view, and we
- // must wait for it to finish redrawing before drawing this top border area
- ctx->virtual_hook(AbstractWindowContext::DrawWindows10BorderHook2, nullptr);
- return true;
+ // Since a QExposeEvent will be sent immediately after the QResizeEvent, we can
+ // simply ignore it.
+ auto ee = static_cast<QExposeEvent *>(event);
+ if (window->isExposed() && isNormalWindow() && !ee->region().isNull()) {
+ forwardEventToWindowAndDraw(window, event);
+ return true;
+ }
+ break;
}
+ default:
+ break;
}
- return false;
+ return Windows10BorderHandler::sharedEventFilter(obj, event);
}
bool eventFilter(QObject *obj, QEvent *event) override {
Q_UNUSED(obj)
+
switch (event->type()) {
case QEvent::UpdateRequest: {
if (!isNormalWindow())
break;
-
- // Friend class helping to call `event`
- class HackedWidget : public QWidget {
- public:
- friend class QWK::WidgetBorderHandler;
- };
-
- // Let the widget paint first
- static_cast<HackedWidget *>(widget)->event(event);
-
- // Due to the timer or user action, Qt will redraw some regions spontaneously,
- // even if there is no WM_PAINT message, we must wait for it to finish redrawing
- // and then update the upper border area
- ctx->virtual_hook(AbstractWindowContext::DrawWindows10BorderHook2, nullptr);
+ forwardEventToWidgetAndDraw(widget, event);
return true;
}
@@ -156,14 +136,13 @@
}
QWidget *widget;
- AbstractWindowContext *ctx;
};
void WidgetWindowAgentPrivate::setupWindows10BorderWorkaround() {
// Install painting hook
auto ctx = context.get();
- if (ctx->property("needBorderPainter").toBool()) {
- std::ignore = new WidgetBorderHandler(hostWidget, ctx);
+ if (ctx->windowAttribute(QStringLiteral("win10-border-needed")).toBool()) {
+ borderHandler = std::make_unique<WidgetBorderHandler>(hostWidget, ctx);
}
}
#endif
--
Gitblit v1.9.1