From 6b2d31247dc2c2804e571b31a71c8a423c1db9d4 Mon Sep 17 00:00:00 2001 From: Sine Striker <trueful@163.com> Date: 周二, 26 12月 2023 01:44:03 +0800 Subject: [PATCH] Totally fix top border issue on Win10 for QtWidgets --- src/core/contexts/win32windowcontext.cpp | 331 ++++++++++++++++++++++++++++++------------------------ 1 files changed, 184 insertions(+), 147 deletions(-) diff --git a/src/core/contexts/win32windowcontext.cpp b/src/core/contexts/win32windowcontext.cpp index 4ea0b5a..bf25bdb 100644 --- a/src/core/contexts/win32windowcontext.cpp +++ b/src/core/contexts/win32windowcontext.cpp @@ -5,6 +5,7 @@ #include <QtCore/QHash> #include <QtCore/QScopeGuard> #include <QtCore/QTimer> +#include <QtCore/QDateTime> #include <QtGui/QGuiApplication> #include <QtGui/QPainter> #include <QtGui/QPalette> @@ -26,10 +27,6 @@ #include "qwkglobal_p.h" #include "qwkwindowsextra_p.h" -#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) -Q_DECLARE_METATYPE(QMargins) -#endif - namespace QWK { // The thickness of an auto-hide taskbar in pixels. @@ -49,59 +46,25 @@ // Original Qt window proc function static WNDPROC g_qtWindowProc = nullptr; + static inline bool +#if !QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER) + constexpr +#endif + + isSystemBorderEnabled() { + return +#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER) + isWin10OrGreater() +#else + false +#endif + ; + } + static inline void triggerFrameChange(HWND hwnd) { ::SetWindowPos(hwnd, nullptr, 0, 0, 0, 0, SWP_NOACTIVATE | SWP_NOMOVE | SWP_NOSIZE | SWP_NOZORDER | SWP_NOOWNERZORDER | SWP_FRAMECHANGED); - } - - static inline quint32 getDpiForWindow(HWND hwnd) { - const DynamicApis &apis = DynamicApis::instance(); - if (apis.pGetDpiForWindow) { // Win10 - return apis.pGetDpiForWindow(hwnd); - } else if (apis.pGetDpiForMonitor) { // Win8.1 - HMONITOR monitor = ::MonitorFromWindow(hwnd, MONITOR_DEFAULTTONEAREST); - UINT dpiX{0}; - UINT dpiY{0}; - apis.pGetDpiForMonitor(monitor, MDT_EFFECTIVE_DPI, &dpiX, &dpiY); - return dpiX; - } else { // Win2K - HDC hdc = ::GetDC(nullptr); - const int dpiX = ::GetDeviceCaps(hdc, LOGPIXELSX); - // const int dpiY = ::GetDeviceCaps(hdc, LOGPIXELSY); - ::ReleaseDC(nullptr, hdc); - return quint32(dpiX); - } - } - - static inline quint32 getSystemMetricsForDpi(int index, quint32 dpi) { - const DynamicApis &apis = DynamicApis::instance(); - if (apis.pGetSystemMetricsForDpi) { - return ::GetSystemMetricsForDpi(index, dpi); - } - return ::GetSystemMetrics(index); - } - - static inline quint32 getWindowFrameBorderThickness(HWND hwnd) { - const DynamicApis &apis = DynamicApis::instance(); - if (UINT result = 0; SUCCEEDED(apis.pDwmGetWindowAttribute( - hwnd, _DWMWA_VISIBLE_FRAME_BORDER_THICKNESS, &result, sizeof(result)))) { - return result; - } - return getSystemMetricsForDpi(SM_CXBORDER, getDpiForWindow(hwnd)); - } - - static inline quint32 getResizeBorderThickness(HWND hwnd) { - const quint32 dpi = getDpiForWindow(hwnd); - return getSystemMetricsForDpi(SM_CXSIZEFRAME, dpi) + - getSystemMetricsForDpi(SM_CXPADDEDBORDER, dpi); - } - - static inline quint32 getTitleBarHeight(HWND hwnd) { - const quint32 dpi = getDpiForWindow(hwnd); - return getSystemMetricsForDpi(SM_CYCAPTION, dpi) + - getSystemMetricsForDpi(SM_CXSIZEFRAME, dpi) + - getSystemMetricsForDpi(SM_CXPADDEDBORDER, dpi); } static void setInternalWindowFrameMargins(QWindow *window, const QMargins &margins) { @@ -548,7 +511,7 @@ static inline void addManagedWindow(QWindow *window, HWND hWnd, Win32WindowContext *ctx) { const auto margins = [hWnd]() -> QMargins { const auto titleBarHeight = int(getTitleBarHeight(hWnd)); - if (isWin10OrGreater()) { + if (isSystemBorderEnabled()) { return {0, -titleBarHeight, 0, 0}; } else { const auto frameSize = int(getResizeBorderThickness(hWnd)); @@ -643,6 +606,7 @@ } case DrawWindows10BorderHook: { +#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER) if (!windowId) return; @@ -653,7 +617,7 @@ const auto hwnd = reinterpret_cast<HWND>(windowId); QPen pen; - pen.setWidth(getWindowFrameBorderThickness(hwnd) * 2); + pen.setWidth(int(getWindowFrameBorderThickness(hwnd)) * 2); const bool dark = isDarkThemeActive() && isDarkWindowFrameEnabled(hwnd); if (m_delegate->isWindowActive(m_host)) { @@ -673,7 +637,7 @@ } painter.save(); - // We needs anti-aliasing to give us better result. + // We need antialiasing to give us better result. painter.setRenderHint(QPainter::Antialiasing); painter.setPen(pen); @@ -682,6 +646,33 @@ QPoint{m_windowHandle->width(), 0} }); painter.restore(); +#endif + return; + } + + case DrawWindows10BorderHook2: { +#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER) + if (!m_windowHandle) + return; + + // https://github.com/microsoft/terminal/blob/71a6f26e6ece656084e87de1a528c4a8072eeabd/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L1025 + // https://docs.microsoft.com/en-us/windows/win32/dwm/customframe#extending-the-client-frame + // Draw a black rectangle to make Windows native top border show + + auto hWnd = reinterpret_cast<HWND>(windowId); + HDC hdc = ::GetDC(hWnd); + RECT windowRect{}; + ::GetClientRect(hWnd, &windowRect); + RECT rcTopBorder = { + 0, + 0, + RECT_WIDTH(windowRect), + int(getWindowFrameBorderThickness(hWnd)), + }; + ::FillRect(hdc, &rcTopBorder, + reinterpret_cast<HBRUSH>(::GetStockObject(BLACK_BRUSH))); + ::ReleaseDC(hWnd, hdc); +#endif return; } @@ -691,12 +682,29 @@ AbstractWindowContext::virtual_hook(id, data); } - bool Win32WindowContext::needBorderPainter() const { - return isWin10OrGreater() && !isWin11OrGreater(); - } + QVariant Win32WindowContext::windowAttribute(const QString &key) const { + if (key == QStringLiteral("title-bar-rect")) { + if (!m_windowHandle) + return {}; - int Win32WindowContext::borderThickness() const { - return getWindowFrameBorderThickness(reinterpret_cast<HWND>(windowId)); + auto hwnd = reinterpret_cast<HWND>(windowId); + RECT frame{}; + ::AdjustWindowRectExForDpi(&frame, ::GetWindowLongPtrW(hwnd, GWL_STYLE), FALSE, 0, + getDpiForWindow(hwnd)); + return QVariant::fromValue(rect2qrect(frame)); + } + + if (key == QStringLiteral("win10-border-needed")) { + return isSystemBorderEnabled() && !isWin11OrGreater(); + } + + if (key == QStringLiteral("border-thickness")) { + return m_windowHandle + ? int(getWindowFrameBorderThickness(reinterpret_cast<HWND>(windowId))) + : 0; + } + + return AbstractWindowContext::windowAttribute(key); } void Win32WindowContext::winIdChanged() { @@ -714,30 +722,20 @@ auto winId = m_windowHandle->winId(); auto hWnd = reinterpret_cast<HWND>(winId); -#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER) - if (!isWin10OrGreater()) -#endif - { - static constexpr const MARGINS margins = {1, 1, 1, 1}; - DynamicApis::instance().pDwmExtendFrameIntoClientArea(hWnd, &margins); + if (!isSystemBorderEnabled()) { + setWindowAttribute(QStringLiteral("extra-margins"), + QVariant::fromValue(QMargins(1, 1, 1, 1))); } -#if !QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER) { auto style = ::GetWindowLongPtrW(hWnd, GWL_STYLE); - ::SetWindowLongPtrW(hWnd, GWL_STYLE, style | WS_THICKFRAME | WS_CAPTION); - } +#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER) + ::SetWindowLongPtrW(hWnd, GWL_STYLE, style & (~WS_SYSMENU)); +#else + ::SetWindowLongPtrW(hWnd, GWL_STYLE, + (style | WS_THICKFRAME | WS_CAPTION) & (~WS_SYSMENU)); #endif - -#if QT_VERSION < QT_VERSION_CHECK(6, 5, 0) - for (const auto attr : { - _DWMWA_USE_IMMERSIVE_DARK_MODE_BEFORE_20H1, - _DWMWA_USE_IMMERSIVE_DARK_MODE, - }) { - const BOOL enable = TRUE; - DynamicApis::instance().pDwmSetWindowAttribute(hWnd, attr, &enable, sizeof(enable)); } -#endif // Add managed window addManagedWindow(m_windowHandle, hWnd, this); @@ -791,7 +789,7 @@ msg.wParam = wParam; msg.lParam = lParam; QT_NATIVE_EVENT_RESULT_TYPE res = 0; - if (dispatch(QByteArrayLiteral("windows_generic_MSG"), &msg, &res)) { + if (nativeDispatch(QByteArrayLiteral("windows_generic_MSG"), &msg, &res)) { *result = LRESULT(res); return true; } @@ -801,11 +799,46 @@ bool Win32WindowContext::windowAttributeChanged(const QString &key, const QVariant &attribute, const QVariant &oldAttribute) { + Q_UNUSED(oldAttribute) + const auto hwnd = reinterpret_cast<HWND>(m_windowHandle->winId()); const DynamicApis &apis = DynamicApis::instance(); - static constexpr const MARGINS extendMargins = {-1, -1, -1, -1}; - static const auto defaultMargins = - isWin10OrGreater() ? MARGINS{0, 0, 0, 0} : MARGINS{1, 1, 1, 1}; + static constexpr const MARGINS extendedMargins = {-1, -1, -1, -1}; + const auto &restoreMargins = [this, &apis, hwnd]() { + auto margins = qmargins2margins( + m_windowAttributes.value(QStringLiteral("extra-margins")).value<QMargins>()); + apis.pDwmExtendFrameIntoClientArea(hwnd, &margins); + }; + + if (key == QStringLiteral("extra-margins")) { + auto margins = qmargins2margins(attribute.value<QMargins>()); + DynamicApis::instance().pDwmExtendFrameIntoClientArea(hwnd, &margins); + return true; + } + + if (key == QStringLiteral("dark-mode")) { + if (!isWin101809OrGreater()) { + return false; + } + + BOOL enable = attribute.toBool(); + if (isWin101903OrGreater()) { + apis.pSetPreferredAppMode(enable ? PAM_AUTO : PAM_DEFAULT); + } else { + apis.pAllowDarkModeForApp(enable); + } + for (const auto attr : { + _DWMWA_USE_IMMERSIVE_DARK_MODE_BEFORE_20H1, + _DWMWA_USE_IMMERSIVE_DARK_MODE, + }) { + apis.pDwmSetWindowAttribute(hwnd, attr, &enable, sizeof(enable)); + } + + apis.pFlushMenuThemes(); + return true; + } + + // For Win11 or later if (key == QStringLiteral("mica")) { if (!isWin11OrGreater()) { return false; @@ -813,7 +846,7 @@ if (attribute.toBool()) { // We need to extend the window frame into the whole client area to be able // to see the blurred window background. - apis.pDwmExtendFrameIntoClientArea(hwnd, &extendMargins); + apis.pDwmExtendFrameIntoClientArea(hwnd, &extendedMargins); if (isWin1122H2OrGreater()) { // Use official DWM API to enable Mica, available since Windows 11 22H2 // (10.0.22621). @@ -835,17 +868,19 @@ const BOOL enable = FALSE; apis.pDwmSetWindowAttribute(hwnd, _DWMWA_MICA_EFFECT, &enable, sizeof(enable)); } - apis.pDwmExtendFrameIntoClientArea(hwnd, &defaultMargins); + restoreMargins(); } return true; - } else if (key == QStringLiteral("mica-alt")) { + } + + if (key == QStringLiteral("mica-alt")) { if (!isWin1122H2OrGreater()) { return false; } if (attribute.toBool()) { // We need to extend the window frame into the whole client area to be able // to see the blurred window background. - apis.pDwmExtendFrameIntoClientArea(hwnd, &extendMargins); + apis.pDwmExtendFrameIntoClientArea(hwnd, &extendedMargins); // Use official DWM API to enable Mica Alt, available since Windows 11 22H2 // (10.0.22621). const _DWM_SYSTEMBACKDROP_TYPE backdropType = _DWMSBT_TABBEDWINDOW; @@ -855,60 +890,65 @@ const _DWM_SYSTEMBACKDROP_TYPE backdropType = _DWMSBT_AUTO; apis.pDwmSetWindowAttribute(hwnd, _DWMWA_SYSTEMBACKDROP_TYPE, &backdropType, sizeof(backdropType)); - apis.pDwmExtendFrameIntoClientArea(hwnd, &defaultMargins); + restoreMargins(); } return true; - } else if (key == QStringLiteral("acrylic-material")) { - if (!isWin10OrGreater()) { + } + + if (key == QStringLiteral("acrylic-material")) { + if (!isWin11OrGreater()) { return false; } - if (attribute.userType() == QMetaType::QColor) { - // We need to extend the window frame into the whole client area to be able - // to see the blurred window background. - apis.pDwmExtendFrameIntoClientArea(hwnd, &extendMargins); - if (isWin11OrGreater()) { - const _DWM_SYSTEMBACKDROP_TYPE backdropType = _DWMSBT_TRANSIENTWINDOW; - apis.pDwmSetWindowAttribute(hwnd, _DWMWA_SYSTEMBACKDROP_TYPE, &backdropType, - sizeof(backdropType)); - } else { - auto gradientColor = attribute.value<QColor>(); - - ACCENT_POLICY policy{}; - policy.dwAccentState = ACCENT_ENABLE_ACRYLICBLURBEHIND; - policy.dwAccentFlags = ACCENT_ENABLE_ACRYLIC_WITH_LUMINOSITY; - // This API expects the #AABBGGRR format. - policy.dwGradientColor = - DWORD(qRgba(gradientColor.blue(), gradientColor.green(), - gradientColor.red(), gradientColor.alpha())); - WINDOWCOMPOSITIONATTRIBDATA wcad{}; - wcad.Attrib = WCA_ACCENT_POLICY; - wcad.pvData = &policy; - wcad.cbData = sizeof(policy); - apis.pSetWindowCompositionAttribute(hwnd, &wcad); - } - } else { - if (isWin11OrGreater()) { - const _DWM_SYSTEMBACKDROP_TYPE backdropType = _DWMSBT_AUTO; - apis.pDwmSetWindowAttribute(hwnd, _DWMWA_SYSTEMBACKDROP_TYPE, &backdropType, - sizeof(backdropType)); - } else { - ACCENT_POLICY policy{}; - policy.dwAccentState = ACCENT_DISABLED; - policy.dwAccentFlags = ACCENT_NONE; - WINDOWCOMPOSITIONATTRIBDATA wcad{}; - wcad.Attrib = WCA_ACCENT_POLICY; - wcad.pvData = &policy; - wcad.cbData = sizeof(policy); - apis.pSetWindowCompositionAttribute(hwnd, &wcad); - } - apis.pDwmExtendFrameIntoClientArea(hwnd, &defaultMargins); - } - return true; - } else if (key == QStringLiteral("dwm-blur")) { if (attribute.toBool()) { // We need to extend the window frame into the whole client area to be able // to see the blurred window background. - apis.pDwmExtendFrameIntoClientArea(hwnd, &extendMargins); + apis.pDwmExtendFrameIntoClientArea(hwnd, &extendedMargins); + + const _DWM_SYSTEMBACKDROP_TYPE backdropType = _DWMSBT_TRANSIENTWINDOW; + apis.pDwmSetWindowAttribute(hwnd, _DWMWA_SYSTEMBACKDROP_TYPE, &backdropType, + sizeof(backdropType)); + + // PRIVATE API REFERENCE: + // QColor gradientColor = {}; + // ACCENT_POLICY policy{}; + // policy.dwAccentState = ACCENT_ENABLE_ACRYLICBLURBEHIND; + // policy.dwAccentFlags = ACCENT_ENABLE_ACRYLIC_WITH_LUMINOSITY; + // // This API expects the #AABBGGRR format. + // policy.dwGradientColor = + // DWORD(qRgba(gradientColor.blue(), gradientColor.green(), + // gradientColor.red(), gradientColor.alpha())); + // WINDOWCOMPOSITIONATTRIBDATA wcad{}; + // wcad.Attrib = WCA_ACCENT_POLICY; + // wcad.pvData = &policy; + // wcad.cbData = sizeof(policy); + // apis.pSetWindowCompositionAttribute(hwnd, &wcad); + } else { + const _DWM_SYSTEMBACKDROP_TYPE backdropType = _DWMSBT_AUTO; + apis.pDwmSetWindowAttribute(hwnd, _DWMWA_SYSTEMBACKDROP_TYPE, &backdropType, + sizeof(backdropType)); + + // PRIVATE API REFERENCE: + // ACCENT_POLICY policy{}; + // policy.dwAccentState = ACCENT_DISABLED; + // policy.dwAccentFlags = ACCENT_NONE; + // WINDOWCOMPOSITIONATTRIBDATA wcad{}; + // wcad.Attrib = WCA_ACCENT_POLICY; + // wcad.pvData = &policy; + // wcad.cbData = sizeof(policy); + // apis.pSetWindowCompositionAttribute(hwnd, &wcad); + + restoreMargins(); + } + return true; + } + + if (key == QStringLiteral("dwm-blur")) { + // TODO: Optimize + // Currently not available!!! + if (attribute.toBool()) { + // We need to extend the window frame into the whole client area to be able + // to see the blurred window background. + apis.pDwmExtendFrameIntoClientArea(hwnd, &extendedMargins); if (isWin8OrGreater()) { ACCENT_POLICY policy{}; policy.dwAccentState = ACCENT_ENABLE_BLURBEHIND; @@ -940,7 +980,7 @@ bb.dwFlags = DWM_BB_ENABLE; apis.pDwmEnableBlurBehindWindow(hwnd, &bb); } - apis.pDwmExtendFrameIntoClientArea(hwnd, &defaultMargins); + restoreMargins(); } return true; } @@ -1472,8 +1512,7 @@ int frameSize = getResizeBorderThickness(hWnd); bool isTop = (nativeLocalPos.y < frameSize); -#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER) - if (isWin10OrGreater()) { + if (isSystemBorderEnabled()) { // This will handle the left, right and bottom parts of the frame // because we didn't change them. LRESULT originalHitTestResult = ::DefWindowProcW(hWnd, WM_NCHITTEST, 0, lParam); @@ -1515,9 +1554,7 @@ } *result = HTCLIENT; return true; - } else -#endif - { + } else { if (full) { *result = HTCLIENT; return true; @@ -1603,7 +1640,7 @@ break; } - if (!isWin10OrGreater()) { + if (!isSystemBorderEnabled()) { switch (message) { case WM_NCUAHDRAWCAPTION: case WM_NCUAHDRAWFRAME: { @@ -1667,7 +1704,6 @@ Q_UNUSED(message) Q_UNUSED(this) -#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER) // Windows鏄牴鎹繖涓秷鎭殑杩斿洖鍊兼潵璁剧疆绐楀彛鐨勫鎴峰尯锛堢獥鍙d腑鐪熸鏄剧ず鐨勫唴瀹癸級 // 鍜岄潪瀹㈡埛鍖猴紙鏍囬鏍忋�佺獥鍙h竟妗嗐�佽彍鍗曟爮鍜岀姸鎬佹爮绛塛indows绯荤粺鑷鎻愪緵鐨勯儴鍒� // 锛屼笉杩囧浜嶲t鏉ヨ锛岄櫎浜嗘爣棰樻爮鍜岀獥鍙h竟妗嗭紝闈炲鎴峰尯鍩烘湰涔熼兘鏄嚜缁樼殑锛夌殑鑼� @@ -1755,7 +1791,7 @@ // and align it with the upper-left corner of our new client area". const auto clientRect = wParam ? &(reinterpret_cast<LPNCCALCSIZE_PARAMS>(lParam))->rgrc[0] : reinterpret_cast<LPRECT>(lParam); - if (isWin10OrGreater()) { + if (isSystemBorderEnabled()) { // Store the original top margin before the default window procedure applies the // default frame. const LONG originalTop = clientRect->top; @@ -1782,6 +1818,7 @@ // technique to bring the top border back. clientRect->top = originalTop; } + const bool max = IsMaximized(hWnd); const bool full = isFullScreen(hWnd); // We don't need this correction when we're fullscreen. We will @@ -1796,7 +1833,7 @@ // a window when it's maximized unless you restore it). const quint32 frameSize = getResizeBorderThickness(hWnd); clientRect->top += frameSize; - if (!isWin10OrGreater()) { + if (!isSystemBorderEnabled()) { clientRect->bottom -= frameSize; clientRect->left += frameSize; clientRect->right -= frameSize; @@ -1875,7 +1912,6 @@ } } } -#endif // We should call this function only before the function returns. syncPaintEventWithDwm(); // By returning WVR_REDRAW we can make the window resizing look @@ -1900,10 +1936,11 @@ const auto getNativeGlobalPosFromKeyboard = [hWnd]() -> POINT { const bool maxOrFull = IsMaximized(hWnd) || isFullScreen(hWnd); const quint32 frameSize = getResizeBorderThickness(hWnd); - const quint32 horizontalOffset = ((maxOrFull || !isWin10OrGreater()) ? 0 : frameSize); + const quint32 horizontalOffset = + ((maxOrFull || !isSystemBorderEnabled()) ? 0 : frameSize); const auto verticalOffset = [hWnd, maxOrFull, frameSize]() -> quint32 { const quint32 titleBarHeight = getTitleBarHeight(hWnd); - if (!isWin10OrGreater()) { + if (!isSystemBorderEnabled()) { return titleBarHeight; } if (isWin11OrGreater()) { -- Gitblit v1.9.1