From 77bce901860548cd84c1680672ec75fbd6184cf8 Mon Sep 17 00:00:00 2001 From: Sine Striker <trueful@163.com> Date: ćšć, 22 2æ 2024 15:40:09 +0800 Subject: [PATCH] Add new winIdChange event filter --- src/core/contexts/abstractwindowcontext.cpp | 44 +++++++++++--------------------------------- 1 files changed, 11 insertions(+), 33 deletions(-) diff --git a/src/core/contexts/abstractwindowcontext.cpp b/src/core/contexts/abstractwindowcontext.cpp index 8fa851a..3b441c0 100644 --- a/src/core/contexts/abstractwindowcontext.cpp +++ b/src/core/contexts/abstractwindowcontext.cpp @@ -7,34 +7,12 @@ #include <QtGui/QPen> #include <QtGui/QPainter> #include <QtGui/QScreen> -#include <memory> #include "qwkglobal_p.h" namespace QWK { namespace { - - class WinIdChangeEventFilter : public QObject { - public: - explicit WinIdChangeEventFilter(QObject *widget, AbstractWindowContext *ctx, - QObject *parent = nullptr) - : QObject(parent), ctx(ctx) { - widget->installEventFilter(this); - } - - protected: - bool eventFilter(QObject *obj, QEvent *event) override { - Q_UNUSED(obj) - if (event->type() == QEvent::WinIdChange) { - ctx->notifyWinIdChange(); - } - return false; - } - - protected: - AbstractWindowContext *ctx; - }; class WindowEventFilter : public QObject { public: @@ -77,16 +55,10 @@ } m_host = host; m_delegate.reset(delegate); - m_winIdChangeEventFilter = std::make_unique<WinIdChangeEventFilter>(host, this); + m_winIdChangeEventFilter.reset(delegate->createWinIdEventFilter(host, this)); m_windowEventFilter = std::make_unique<WindowEventFilter>(m_windowHandle, this); - - m_windowHandle = m_delegate->hostWindow(m_host); - if (m_windowHandle) { - winIdChanged(); - } + notifyWinIdChange(); } - - bool AbstractWindowContext::setHitTestVisible(const QObject *obj, bool visible) { Q_ASSERT(obj); @@ -259,15 +231,21 @@ } void AbstractWindowContext::notifyWinIdChange() { - auto windowEventFilter = static_cast<WindowEventFilter *>(m_windowEventFilter.get()); - windowEventFilter->setWindow(nullptr); + auto oldWinId = m_windowId; + m_windowId = m_winIdChangeEventFilter->winId(); // In Qt6, after QWidget::close() is called, the related QWindow's all surfaces and the // platform window will be removed, and the WinId will be set to 0. After that, when the // QWidget is shown again, the whole things will be recreated again. // As a result, we must update our WindowContext each time the WinId changes. m_windowHandle = m_delegate->hostWindow(m_host); - winIdChanged(); + + auto windowEventFilter = static_cast<WindowEventFilter *>(m_windowEventFilter.get()); + windowEventFilter->setWindow(nullptr); + + if (oldWinId != m_windowId) { + winIdChanged(m_windowId, oldWinId); + } if (m_windowHandle) { windowEventFilter->setWindow(m_windowHandle); -- Gitblit v1.9.1