From 7e132b345cc2b2515838c387a76ccc9f29705ba6 Mon Sep 17 00:00:00 2001
From: Sine Striker <trueful@163.com>
Date: 周二, 19 12月 2023 03:12:59 +0800
Subject: [PATCH] Add fallback to qt window context

---
 src/core/contexts/cocoawindowcontext.mm |   33 ++++++++++++++++++++-------------
 1 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/src/core/contexts/cocoawindowcontext.mm b/src/core/contexts/cocoawindowcontext.mm
index 86f8597..76ff231 100644
--- a/src/core/contexts/cocoawindowcontext.mm
+++ b/src/core/contexts/cocoawindowcontext.mm
@@ -5,6 +5,8 @@
 
 #include <QtGui/QGuiApplication>
 
+#include "qwkglobal_p.h"
+
 namespace QWK {
 
     struct NSWindowProxy {
@@ -217,6 +219,12 @@
         return it.value();
     }
 
+    static inline void releaseWindowProxy(const WId windowId) {
+        if (const auto proxy = g_proxyList()->take(windowId)) {
+            delete proxy;
+        }
+    }
+
     class CocoaWindowEventFilter : public QObject {
     public:
         explicit CocoaWindowEventFilter(AbstractWindowContext *context, QObject *parent = nullptr);
@@ -255,13 +263,10 @@
         QWindow *window = m_context->window();
         WindowItemDelegate *delegate = m_context->delegate();
         auto me = static_cast<const QMouseEvent *>(event);
-#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
-        QPoint scenePos = me->scenePosition().toPoint();
-        QPoint globalPos = me->globalPosition().toPoint();
-#else
-        QPoint scenePos = me->windowPos().toPoint();
-        QPoint globalPos = me->screenPos().toPoint();
-#endif
+
+        QPoint scenePos = getMouseEventScenePos(me);
+        QPoint globalPos = getMouseEventGlobalPos(me);
+
         bool inTitleBar = m_context->isInTitleBarDraggableArea(scenePos);
         switch (type) {
             case QEvent::MouseButtonPress: {
@@ -275,7 +280,6 @@
                             event->accept();
                             return true;
                         }
-                        m_windowStatus = WaitingRelease;
                         break;
                     }
                     case Qt::RightButton: {
@@ -285,6 +289,7 @@
                     default:
                         break;
                 }
+                m_windowStatus = WaitingRelease;
                 break;
             }
 
@@ -355,9 +360,7 @@
     }
 
     CocoaWindowContext::~CocoaWindowContext() {
-        if (const auto proxy = g_proxyList()->take(windowId)) {
-            delete proxy;
-        }
+        releaseWindowProxy(windowId);
     }
 
     QString CocoaWindowContext::key() const {
@@ -378,11 +381,15 @@
         AbstractWindowContext::virtual_hook(id, data);
     }
 
-    void CocoaWindowContext::winIdChanged(QWindow *oldWindow, bool destroyed) {
+    void CocoaWindowContext::winIdChanged(QWindow *oldWindow) {
+        releaseWindowProxy(windowId);
+        if (!m_windowHandle) {
+            return;
+        }
+        
         windowId = m_windowHandle->winId();
         ensureWindowProxy(windowId)->setSystemTitleBarVisible(false);
         cocoaWindowEventFilter = std::make_unique<CocoaWindowEventFilter>(this, this);
-        return true;
     }
 
 }

--
Gitblit v1.9.1