From a51b5688e1c33d3ce96b48c869603b00f908f513 Mon Sep 17 00:00:00 2001 From: Sine Striker <trueful@163.com> Date: 周三, 13 12月 2023 04:16:37 +0800 Subject: [PATCH] Make better code structure for border handlers --- src/core/contexts/win32windowcontext.cpp | 420 ++++++++++++++++++++++++++++++++++++++++++++++++----------- 1 files changed, 342 insertions(+), 78 deletions(-) diff --git a/src/core/contexts/win32windowcontext.cpp b/src/core/contexts/win32windowcontext.cpp index 2168e44..a706835 100644 --- a/src/core/contexts/win32windowcontext.cpp +++ b/src/core/contexts/win32windowcontext.cpp @@ -4,9 +4,13 @@ #include <QtCore/QHash> #include <QtCore/QScopeGuard> +#include <QtCore/QTimer> #include <QtGui/QGuiApplication> #include <QtGui/QPainter> +#include <QtGui/QPalette> +#include <QtGui/QStyleHints> +#include <QtCore/private/qwinregistry_p.h> #include <QtCore/private/qsystemlibrary_p.h> #include <QtGui/private/qhighdpiscaling_p.h> #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) @@ -22,9 +26,9 @@ #include <shellscalingapi.h> #include <dwmapi.h> #include <timeapi.h> -#include <versionhelpers.h> -#include "nativeeventfilter.h" +#include "nativeeventfilter_p.h" +#include "qwkglobal_p.h" #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) Q_DECLARE_METATYPE(QMargins) @@ -32,8 +36,42 @@ namespace QWK { + enum _DWMWINDOWATTRIBUTE { + // [set] BOOL, Allows the use of host backdrop brushes for the window. + _DWMWA_USE_HOSTBACKDROPBRUSH = 17, + + // Undocumented, the same with DWMWA_USE_IMMERSIVE_DARK_MODE, but available on systems + // before Win10 20H1. + _DWMWA_USE_IMMERSIVE_DARK_MODE_BEFORE_20H1 = 19, + + // [set] BOOL, Allows a window to either use the accent color, or dark, according to the + // user Color Mode preferences. + _DWMWA_USE_IMMERSIVE_DARK_MODE = 20, + + // [set] WINDOW_CORNER_PREFERENCE, Controls the policy that rounds top-level window corners + _DWMWA_WINDOW_CORNER_PREFERENCE = 33, + + // [get] UINT, width of the visible border around a thick frame window + _DWMWA_VISIBLE_FRAME_BORDER_THICKNESS = 37, + + // [get, set] SYSTEMBACKDROP_TYPE, Controls the system-drawn backdrop material of a window, + // including behind the non-client area. + _DWMWA_SYSTEMBACKDROP_TYPE = 38, + + // Undocumented, use this value to enable Mica material on Win11 21H2. You should use + // DWMWA_SYSTEMBACKDROP_TYPE instead on Win11 22H2 and newer. + _DWMWA_MICA_EFFECT = 1029 + }; + // The thickness of an auto-hide taskbar in pixels. - static constexpr const auto kAutoHideTaskBarThickness = quint8{2}; + static constexpr const quint8 kAutoHideTaskBarThickness = 2; + + QWK_USED static constexpr const struct { + const uint32_t activeLight = MAKE_RGBA_COLOR(110, 110, 110, 255); // #6E6E6E + const uint32_t activeDark = MAKE_RGBA_COLOR(51, 51, 51, 255); // #333333 + const uint32_t inactiveLight = MAKE_RGBA_COLOR(167, 167, 167, 255); // #A7A7A7 + const uint32_t inactiveDark = MAKE_RGBA_COLOR(61, 61, 62, 255); // #3D3D3E + } kWindowsColorSet; // hWnd -> context using WndProcHash = QHash<HWND, Win32WindowContext *>; @@ -53,23 +91,30 @@ } g_hook{}; struct DynamicApis { -// template <typename T> -// struct DefaultFunc; -// -// template <typename Return, typename... Args> -// struct DefaultFunc<Return(QT_WIN_CALLBACK *)(Args...)> { -// static Return STDAPICALLTYPE func(Args...) { -// return Return{}; -// } -// }; -// -// #define DYNAMIC_API_DECLARE(NAME) decltype(&::NAME) p##NAME = -// DefaultFunc<decltype(&::NAME)>::func + static const DynamicApis &instance() { + static const DynamicApis inst{}; + return inst; + } + + // template <typename T> + // struct DefaultFunc; + // + // template <typename Return, typename... Args> + // struct DefaultFunc<Return(QT_WIN_CALLBACK *)(Args...)> { + // static Return STDAPICALLTYPE func(Args...) { + // return Return{}; + // } + // }; + // + // #define DYNAMIC_API_DECLARE(NAME) decltype(&::NAME) p##NAME = + // DefaultFunc<decltype(&::NAME)>::func + #define DYNAMIC_API_DECLARE(NAME) decltype(&::NAME) p##NAME = nullptr DYNAMIC_API_DECLARE(DwmFlush); DYNAMIC_API_DECLARE(DwmIsCompositionEnabled); DYNAMIC_API_DECLARE(DwmGetCompositionTimingInfo); + DYNAMIC_API_DECLARE(DwmGetWindowAttribute); DYNAMIC_API_DECLARE(GetDpiForWindow); DYNAMIC_API_DECLARE(GetSystemMetricsForDpi); DYNAMIC_API_DECLARE(GetDpiForMonitor); @@ -79,6 +124,7 @@ #undef DYNAMIC_API_DECLARE + private: DynamicApis() { #define DYNAMIC_API_RESOLVE(DLL, NAME) \ p##NAME = reinterpret_cast<decltype(p##NAME)>(DLL.resolve(#NAME)) @@ -94,6 +140,7 @@ DYNAMIC_API_RESOLVE(dwmapi, DwmFlush); DYNAMIC_API_RESOLVE(dwmapi, DwmIsCompositionEnabled); DYNAMIC_API_RESOLVE(dwmapi, DwmGetCompositionTimingInfo); + DYNAMIC_API_RESOLVE(dwmapi, DwmGetWindowAttribute); QSystemLibrary winmm(QStringLiteral("winmm")); DYNAMIC_API_RESOLVE(winmm, timeGetDevCaps); @@ -105,12 +152,6 @@ ~DynamicApis() = default; - static const DynamicApis &instance() { - static const DynamicApis inst{}; - return inst; - } - - private: Q_DISABLE_COPY_MOVE(DynamicApis) }; @@ -195,23 +236,22 @@ } static inline bool isWin8OrGreater() { - static const bool result = ::IsWindows8OrGreater(); + static const bool result = IsWindows8OrGreater_Real(); return result; } static inline bool isWin8Point1OrGreater() { - static const bool result = ::IsWindows8Point1OrGreater(); + static const bool result = IsWindows8Point1OrGreater_Real(); return result; } static inline bool isWin10OrGreater() { - static const bool result = ::IsWindows10OrGreater(); + static const bool result = IsWindows10OrGreater_Real(); return result; } static inline bool isWin11OrGreater() { - static const bool result = ::IsWindowsVersionOrGreater(HIBYTE(_WIN32_WINNT_WIN10), - LOBYTE(_WIN32_WINNT_WIN10), 22000); + static const bool result = IsWindows11OrGreater_Real(); return result; } @@ -225,6 +265,72 @@ } BOOL enabled = FALSE; return SUCCEEDED(apis.pDwmIsCompositionEnabled(&enabled)) && enabled; + } + + static inline bool isWindowFrameBorderColorized() { + const QWinRegistryKey registry(HKEY_CURRENT_USER, LR"(Software\Microsoft\Windows\DWM)"); + if (!registry.isValid()) { + return false; + } + const auto value = registry.dwordValue(L"ColorPrevalence"); + if (!value.second) { + return false; + } + return value.first; + } + + static inline bool isDarkThemeActive() { +#if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0) + return QGuiApplication::styleHints()->colorScheme() == Qt::ColorScheme::Dark; +#else + const QWinRegistryKey registry( + HKEY_CURRENT_USER, LR"(Software\Microsoft\Windows\CurrentVersion\Themes\Personalize)"); + if (!registry.isValid()) { + return false; + } + const auto value = registry.dwordValue(L"AppsUseLightTheme"); + if (!value.second) { + return false; + } + return !value.first; +#endif + } + + static inline bool isDarkWindowFrameEnabled(HWND hwnd) { + BOOL enabled = FALSE; + const DynamicApis &apis = DynamicApis::instance(); + if (SUCCEEDED(apis.pDwmGetWindowAttribute(hwnd, _DWMWA_USE_IMMERSIVE_DARK_MODE, &enabled, + sizeof(enabled)))) { + return enabled; + } else if (SUCCEEDED(apis.pDwmGetWindowAttribute(hwnd, + _DWMWA_USE_IMMERSIVE_DARK_MODE_BEFORE_20H1, + &enabled, sizeof(enabled)))) { + return enabled; + } else { + return false; + } + } + + static inline QColor getAccentColor() { +#if QT_VERSION >= QT_VERSION_CHECK(6, 6, 0) + return QGuiApplication::palette().color(QPalette::Accent); +#else + const QWinRegistryKey registry(HKEY_CURRENT_USER, LR"(Software\Microsoft\Windows\DWM)"); + if (!registry.isValid()) { + return {}; + } + const auto value = registry.dwordValue(L"AccentColor"); + if (!value.second) { + return {}; + } + // The retrieved value is in the #AABBGGRR format, we need to + // convert it to the #AARRGGBB format which Qt expects. + const QColor abgr = QColor::fromRgba(value.first); + if (!abgr.isValid()) { + return {}; + } + return QColor::fromRgb(abgr.blue(), abgr.green(), abgr.red(), abgr.alpha()); +#endif } static inline void triggerFrameChange(HWND hwnd) { @@ -246,43 +352,49 @@ } else { // Win2K HDC hdc = ::GetDC(nullptr); const int dpiX = ::GetDeviceCaps(hdc, LOGPIXELSX); - const int dpiY = ::GetDeviceCaps(hdc, LOGPIXELSY); + // const int dpiY = ::GetDeviceCaps(hdc, LOGPIXELSY); ::ReleaseDC(nullptr, hdc); return quint32(dpiX); } } - static inline quint32 getResizeBorderThickness(HWND hwnd) { + static inline quint32 getSystemMetricsForDpi(int index, quint32 dpi) { const DynamicApis &apis = DynamicApis::instance(); if (apis.pGetSystemMetricsForDpi) { - const quint32 dpi = getDpiForWindow(hwnd); - return apis.pGetSystemMetricsForDpi(SM_CXSIZEFRAME, dpi) + - apis.pGetSystemMetricsForDpi(SM_CXPADDEDBORDER, dpi); - } else { - return ::GetSystemMetrics(SM_CXSIZEFRAME) + ::GetSystemMetrics(SM_CXPADDEDBORDER); + return ::GetSystemMetricsForDpi(index, dpi); } + return ::GetSystemMetrics(index); + } + + static inline quint32 getWindowFrameBorderThickness(HWND hwnd) { + const DynamicApis &apis = DynamicApis::instance(); + if (UINT result = 0; SUCCEEDED(apis.pDwmGetWindowAttribute( + hwnd, _DWMWA_VISIBLE_FRAME_BORDER_THICKNESS, &result, sizeof(result)))) { + return result; + } + return getSystemMetricsForDpi(SM_CXBORDER, getDpiForWindow(hwnd)); + } + + static inline quint32 getResizeBorderThickness(HWND hwnd) { + const quint32 dpi = getDpiForWindow(hwnd); + return getSystemMetricsForDpi(SM_CXSIZEFRAME, dpi) + + getSystemMetricsForDpi(SM_CXPADDEDBORDER, dpi); } static inline quint32 getTitleBarHeight(HWND hwnd) { - const auto captionHeight = [hwnd]() -> int { - const DynamicApis &apis = DynamicApis::instance(); - if (apis.pGetSystemMetricsForDpi) { - const quint32 dpi = getDpiForWindow(hwnd); - return apis.pGetSystemMetricsForDpi(SM_CYCAPTION, dpi); - } else { - return ::GetSystemMetrics(SM_CYCAPTION); - } - }(); - return captionHeight + getResizeBorderThickness(hwnd); + const quint32 dpi = getDpiForWindow(hwnd); + return getSystemMetricsForDpi(SM_CYCAPTION, dpi) + + getSystemMetricsForDpi(SM_CXSIZEFRAME, dpi) + + getSystemMetricsForDpi(SM_CXPADDEDBORDER, dpi); } - static inline void updateInternalWindowFrameMargins(HWND hwnd, QWindow *window) { + static void updateInternalWindowFrameMargins(HWND hwnd, QWindow *window) { const auto margins = [hwnd]() -> QMargins { - const int titleBarHeight = getTitleBarHeight(hwnd); + const auto titleBarHeight = int(getTitleBarHeight(hwnd)); if (isWin10OrGreater()) { return {0, -titleBarHeight, 0, 0}; } else { - const int frameSize = getResizeBorderThickness(hwnd); + const auto frameSize = int(getResizeBorderThickness(hwnd)); return {-frameSize, -titleBarHeight, -frameSize, -frameSize}; } }(); @@ -342,7 +454,7 @@ #endif } - static inline void syncPaintEventWithDwm() { + static void syncPaintEventWithDwm() { // No need to sync with DWM if DWM composition is disabled. if (!isDwmCompositionEnabled()) { return; @@ -387,9 +499,9 @@ apis.ptimeEndPeriod(ms_granularity); } - static inline void showSystemMenu2(HWND hWnd, const POINT &pos, const bool selectFirstEntry, - const bool fixedSize) { - const HMENU hMenu = ::GetSystemMenu(hWnd, FALSE); + static void showSystemMenu2(HWND hWnd, const POINT &pos, const bool selectFirstEntry, + const bool fixedSize) { + HMENU hMenu = ::GetSystemMenu(hWnd, FALSE); if (!hMenu) { // The corresponding window doesn't have a system menu, most likely due to the // lack of the "WS_SYSMENU" window style. This situation should not be treated @@ -478,7 +590,8 @@ case HTBORDER: return Win32WindowContext::FixedBorder; default: - break; // unreachable + // unreachable + break; } return Win32WindowContext::Outside; } @@ -671,41 +784,88 @@ } QString Win32WindowContext::key() const { - return "win32"; + return QStringLiteral("win32"); } void Win32WindowContext::virtual_hook(int id, void *data) { switch (id) { + case CentralizeHook: { + const auto hwnd = reinterpret_cast<HWND>(m_windowHandle->winId()); + moveToDesktopCenter(hwnd); + return; + } + case ShowSystemMenuHook: { - const auto &pos = *reinterpret_cast<const QPoint *>(data); - auto winId = m_windowHandle->winId(); - auto hWnd = reinterpret_cast<HWND>(winId); - showSystemMenu2(hWnd, {pos.x(), pos.y()}, false, + const auto &pos = *static_cast<const QPoint *>(data); + auto hWnd = reinterpret_cast<HWND>(m_windowHandle->winId()); + showSystemMenu2(hWnd, qpoint2point(pos), false, m_delegate->isHostSizeFixed(m_host)); return; } - case NeedsDrawBordersHook: { - auto &result = *reinterpret_cast<bool *>(data); - result = isWin10OrGreater() && !isWin11OrGreater(); + + case DefaultColorsHook: { + auto &map = *static_cast<QMap<QString, QColor> *>(data); + map.clear(); + map.insert(QStringLiteral("activeLight"), kWindowsColorSet.activeLight); + map.insert(QStringLiteral("activeDark"), kWindowsColorSet.activeDark); + map.insert(QStringLiteral("inactiveLight"), kWindowsColorSet.inactiveLight); + map.insert(QStringLiteral("inactiveDark"), kWindowsColorSet.inactiveDark); return; } - case DrawBordersHook: { - auto a = reinterpret_cast<void **>(data); - auto &painter = *reinterpret_cast<QPainter *>(a[0]); - auto &rect = *reinterpret_cast<const QRect *>(a[1]); - auto ®ion = *reinterpret_cast<const QRegion *>(a[2]); - qDebug() << "paint" << &painter << rect << region; + case DrawWindows10BorderHook: { + auto args = static_cast<void **>(data); + auto &painter = *static_cast<QPainter *>(args[0]); + const auto &rect = *static_cast<const QRect *>(args[1]); + const auto ®ion = *static_cast<const QRegion *>(args[2]); + const auto hwnd = reinterpret_cast<HWND>(m_windowHandle->winId()); - // TODO: Draw border - // ... + QPen pen; + pen.setWidth(getWindowFrameBorderThickness(hwnd) * 2); + const bool dark = isDarkThemeActive() && isDarkWindowFrameEnabled(hwnd); + if (m_delegate->isWindowActive(m_host)) { + if (isWindowFrameBorderColorized()) { + pen.setColor(getAccentColor()); + } else { + static QColor frameBorderActiveColorLight(kWindowsColorSet.activeLight); + static QColor frameBorderActiveColorDark(kWindowsColorSet.activeDark); + pen.setColor(dark ? frameBorderActiveColorDark + : frameBorderActiveColorLight); + } + } else { + static QColor frameBorderInactiveColorLight(kWindowsColorSet.inactiveLight); + static QColor frameBorderInactiveColorDark(kWindowsColorSet.inactiveDark); + pen.setColor(dark ? frameBorderInactiveColorDark + : frameBorderInactiveColorLight); + } + painter.save(); + + // ### TODO: do we need to enable or disable it? + painter.setRenderHint(QPainter::Antialiasing); + + painter.setPen(pen); + painter.drawLine(QLine{ + QPoint{0, 0}, + QPoint{m_windowHandle->width(), 0} + }); + painter.restore(); + } + + default: { + // unreachable break; } - default: - break; } AbstractWindowContext::virtual_hook(id, data); + } + + bool Win32WindowContext::needBorderPainter() const { + return isWin10OrGreater() && !isWin11OrGreater(); + } + + int Win32WindowContext::borderThickness() const { + return getWindowFrameBorderThickness(reinterpret_cast<HWND>(windowId)); } bool Win32WindowContext::setupHost() { @@ -768,18 +928,22 @@ return true; } + // Whether to show system menu if (systemMenuHandler(hWnd, message, wParam, lParam, result)) { + return true; + } + + if (themeStuffHandler(hWnd, message, wParam, lParam, result)) { return true; } return false; // Not handled } - static constexpr const auto kMessageTag = WPARAM(0xF1C9ADD4); - - static inline constexpr bool isTaggedMessage(WPARAM wParam) { - return (wParam == kMessageTag); - } + QWK_USED static constexpr const struct { + const WPARAM wParam = MAKEWPARAM(44500, 61897); + const LPARAM lParam = MAKELPARAM(62662, 44982); // Not used. Reserve for future use. + } kMessageTag; static inline quint64 getKeyState() { quint64 result = 0; @@ -819,7 +983,7 @@ // wParam is always ignored in mouse leave messages, but here we // give them a special tag to be able to distinguish which messages // are sent by ourselves. - return kMessageTag; + return kMessageTag.wParam; } const quint64 keyState = getKeyState(); if ((myMsg >= WM_NCXBUTTONDOWN) && (myMsg <= WM_NCXBUTTONDBLCLK)) { @@ -897,6 +1061,7 @@ SEND_MESSAGE(hWnd, WM_MOUSELEAVE, wParamNew, lParamNew); break; default: + // unreachable break; } @@ -919,7 +1084,7 @@ LPARAM lParam, LRESULT *result) { switch (message) { case WM_MOUSELEAVE: { - if (!isTaggedMessage(wParam)) { + if (wParam != kMessageTag.wParam) { // Qt will call TrackMouseEvent() to get the WM_MOUSELEAVE message when it // receives WM_MOUSEMOVE messages, and since we are converting every // WM_NCMOUSEMOVE message to WM_MOUSEMOVE message and send it back to the window @@ -1069,6 +1234,7 @@ } break; } + case WM_NCHITTEST: { // 鍘熺敓Win32绐楀彛鍙湁椤惰竟鏄湪绐楀彛鍐呴儴resize鐨勶紝鍏朵綑涓夎竟閮芥槸鍦ㄧ獥鍙� // 澶栭儴杩涜resize鐨勶紝鍏跺師鐞嗘槸锛學S_THICKFRAME杩欎釜绐楀彛鏍峰紡浼氬湪绐� @@ -1181,7 +1347,7 @@ // this is also the normal behavior of a native Win32 window (but only when the // window is not maximized/fullscreen/minimized, of course). if (isWindowNoState(hWnd)) { - static constexpr const auto kBorderSize = quint8{2}; + static constexpr const quint8 kBorderSize = 2; bool isTop = (nativeLocalPos.y <= kBorderSize); bool isLeft = nativeLocalPos.x <= kBorderSize; bool isRight = (nativeLocalPos.x >= (clientWidth - kBorderSize)); @@ -1231,7 +1397,8 @@ *result = HTCLOSE; break; default: - break; // unreachable + // unreachable + break; } } if (*result == HTNOWHERE) { @@ -1356,9 +1523,27 @@ return true; } } + + case WM_WINDOWPOSCHANGING: { + // ### FIXME: How does this problem happen and why is it solved? + // When toggling the "Show theme color in title bar and window border" setting in + // Windows Settings, or calling `DrawMenuBar()`, Windows sends a message of + // WM_WINDOWPOSCHANGING with flags 0x37. If we do not process this message, + // the client area as a whole will shift to the left, which looks very abnormal if + // we don't repaint it. This exception disappears if we add SWP_NOCOPYBITS flag. + // But I don't know what caused the problem, or why this would solve it. + const auto windowPos = reinterpret_cast<LPWINDOWPOS>(lParam); + if (windowPos->flags == + (SWP_NOSIZE | SWP_NOMOVE | SWP_NOZORDER | SWP_NOACTIVATE | SWP_FRAMECHANGED)) { + windowPos->flags |= SWP_NOCOPYBITS; + } + break; + } + default: break; } + if (!isWin10OrGreater()) { switch (message) { case WM_NCUAHDRAWCAPTION: @@ -1738,4 +1923,83 @@ return false; } + bool Win32WindowContext::themeStuffHandler(HWND hWnd, UINT message, WPARAM wParam, + LPARAM lParam, LRESULT *resul) { + switch (message) { + case WM_DPICHANGED: { + const auto dpiX = UINT(LOWORD(wParam)); + const auto dpiY = UINT(HIWORD(wParam)); + + QEvent e(QEvent::ScreenChangeInternal); + dispatch(&e); + break; + } + + case WM_THEMECHANGED: + case WM_SYSCOLORCHANGE: { + QEvent e(QEvent::UpdateRequest); + dispatch(&e); + break; + } + + case WM_DWMCOLORIZATIONCOLORCHANGED: { + const QColor color = QColor::fromRgba(wParam); + const auto blendWithOpacity = *reinterpret_cast<LPBOOL>(lParam); + + QEvent e(QEvent::UpdateRequest); + dispatch(&e); + break; + } + + case WM_SETTINGCHANGE: { + if (!wParam && lParam && + std::wcscmp(reinterpret_cast<LPCWSTR>(lParam), L"ImmersiveColorSet") == 0) { + const QColor color = getAccentColor(); + } + + QEvent e(QEvent::UpdateRequest); + dispatch(&e); + break; + } + + case WM_SIZE: { + const bool max = wParam == SIZE_MAXIMIZED; + const bool min = wParam == SIZE_MINIMIZED; + const bool full = isFullScreen(hWnd); + + Qt::WindowStates states{}; + if (max) { + states |= Qt::WindowMaximized; + } + if (min) { + states |= Qt::WindowMinimized; + } + if (full) { + states |= Qt::WindowFullScreen; + } + + QTimer::singleShot(0, this, [this, states] { + QWindowStateChangeEvent e(states); + dispatch(&e); + }); + break; + } + + case WM_ACTIVATE: { + const auto state = LOWORD(wParam); + const bool active = state == WA_ACTIVE || state == WA_CLICKACTIVE; + Q_UNUSED(state) + + QTimer::singleShot(0, this, [this, active] { + QEvent e(active ? QEvent::WindowActivate : QEvent::WindowDeactivate); + dispatch(&e); + }); + break; + } + default: + break; + } + return false; + } + } -- Gitblit v1.9.1