From c8a5a82994e513acb00ba0e1f0b882ccbb18a6db Mon Sep 17 00:00:00 2001
From: Sine Striker <trueful@163.com>
Date: 周二, 26 12月 2023 05:15:47 +0800
Subject: [PATCH] clean code
---
src/quick/quickwindowagent_win.cpp | 57 ++++++++++++++++++++++++++++++++++++++++++---------------
1 files changed, 42 insertions(+), 15 deletions(-)
diff --git a/src/quick/quickwindowagent_win.cpp b/src/quick/quickwindowagent_win.cpp
index 15418e2..46e72e3 100644
--- a/src/quick/quickwindowagent_win.cpp
+++ b/src/quick/quickwindowagent_win.cpp
@@ -3,17 +3,25 @@
#include <QtQuick/QQuickPaintedItem>
#include <QtQuick/private/qquickitem_p.h>
-#include <QWKCore/private/nativeeventfilter_p.h>
+#include <QWKCore/qwindowkit_windows.h>
namespace QWK {
- class BorderItem : public QQuickPaintedItem, public NativeEventFilter {
- Q_OBJECT
+#if QWINDOWKIT_CONFIG(ENABLE_WINDOWS_SYSTEM_BORDER)
+ // TODO: Find a way to draw native border
+ // We haven't found a way to place hooks in the Quick program and call the GDI API to draw
+ // the native border area so that we'll use the emulated drawn border for now.
+
+ class BorderItem : public QQuickPaintedItem,
+ public NativeEventFilter,
+ public SharedEventFilter {
public:
explicit BorderItem(QQuickItem *parent, AbstractWindowContext *context);
~BorderItem() override;
- void updateGeometry();
+ inline bool isNormalWindow() const;
+
+ inline void updateGeometry();
public:
void paint(QPainter *painter) override;
@@ -23,6 +31,8 @@
bool nativeEventFilter(const QByteArray &eventType, void *message,
QT_NATIVE_EVENT_RESULT_TYPE *result) override;
+ bool sharedEventFilter(QObject *obj, QEvent *event) override;
+
AbstractWindowContext *context;
private:
@@ -31,8 +41,7 @@
BorderItem::BorderItem(QQuickItem *parent, AbstractWindowContext *context)
: QQuickPaintedItem(parent), context(context) {
- setAntialiasing(true); // ### FIXME: do we need to enable or disable this?
- setMipmap(true); // ### FIXME: do we need to enable or disable this?
+ setAntialiasing(true); // We needs anti-aliasing to give us better result.
setFillColor({}); // Will improve the performance a little bit.
setOpaquePainting(true); // Will also improve the performance, we don't draw
// semi-transparent borders of course.
@@ -43,9 +52,11 @@
anchors->setLeft(parentPri->left());
anchors->setRight(parentPri->right());
- setZ(10);
+ setZ(9999); // Make sure our fake border always above everything in the window.
context->installNativeEventFilter(this);
+ context->installSharedEventFilter(this);
+
connect(window(), &QQuickWindow::activeChanged, this,
&BorderItem::_q_windowActivityChanged);
updateGeometry();
@@ -53,8 +64,14 @@
BorderItem::~BorderItem() = default;
+ bool BorderItem::isNormalWindow() const {
+ return !(context->window()->windowState() &
+ (Qt::WindowMinimized | Qt::WindowMaximized | Qt::WindowFullScreen));
+ }
+
void BorderItem::updateGeometry() {
- setHeight(context->property("borderThickness").toInt());
+ setHeight(context->windowAttribute(QStringLiteral("border-thickness")).toInt());
+ setVisible(isNormalWindow());
}
void BorderItem::paint(QPainter *painter) {
@@ -84,7 +101,7 @@
bool BorderItem::nativeEventFilter(const QByteArray &eventType, void *message,
QT_NATIVE_EVENT_RESULT_TYPE *result) {
Q_UNUSED(eventType)
- auto msg = reinterpret_cast<const MSG *>(message);
+ const auto msg = static_cast<const MSG *>(message);
switch (msg->message) {
case WM_THEMECHANGED:
case WM_SYSCOLORCHANGE:
@@ -94,14 +111,25 @@
}
case WM_SETTINGCHANGE: {
- if (!msg->wParam && msg->lParam &&
- std::wcscmp(reinterpret_cast<LPCWSTR>(msg->lParam), L"ImmersiveColorSet") ==
- 0) {
+ if (isImmersiveColorSetChange(msg->wParam, msg->lParam)) {
update();
}
break;
}
+ default:
+ break;
+ }
+ return false;
+ }
+
+ bool BorderItem::sharedEventFilter(QObject *obj, QEvent *event) {
+ Q_UNUSED(obj)
+ switch (event->type()) {
+ case QEvent::WindowStateChange: {
+ updateGeometry();
+ break;
+ }
default:
break;
}
@@ -115,11 +143,10 @@
void QuickWindowAgentPrivate::setupWindows10BorderWorkaround() {
// Install painting hook
auto ctx = context.get();
- if (ctx->property("needBorderPainter").toBool()) {
+ if (ctx->windowAttribute(QStringLiteral("win10-border-needed")).toBool()) {
std::ignore = new BorderItem(hostWindow->contentItem(), ctx);
}
}
+#endif
}
-
-#include "quickwindowagent_win.moc"
\ No newline at end of file
--
Gitblit v1.9.1