From c9261fbd7019264e8543507e3afaec63d55595a2 Mon Sep 17 00:00:00 2001 From: Yuhang Zhao <zhaoyuhang@rankyee.com> Date: 周三, 06 12月 2023 10:58:07 +0800 Subject: [PATCH] fix stupid code --- src/core/corewindowagent.cpp | 31 ++++++++++++++----------------- 1 files changed, 14 insertions(+), 17 deletions(-) diff --git a/src/core/corewindowagent.cpp b/src/core/corewindowagent.cpp index 54b081c..bea2239 100644 --- a/src/core/corewindowagent.cpp +++ b/src/core/corewindowagent.cpp @@ -1,6 +1,8 @@ #include "corewindowagent.h" #include "corewindowagent_p.h" +#include "qwkcoreglobal_p.h" + #ifdef Q_OS_WINDOWS # include "win32windowcontext_p.h" #else @@ -11,44 +13,39 @@ namespace QWK { - CoreWindowAgentPrivate::CoreWindowAgentPrivate() : m_eventHandler(nullptr) { + CoreWindowAgentPrivate::CoreWindowAgentPrivate() : q_ptr(nullptr), context(nullptr) { } - CoreWindowAgentPrivate::~CoreWindowAgentPrivate() { - delete m_eventHandler; - } + CoreWindowAgentPrivate::~CoreWindowAgentPrivate() = default; void CoreWindowAgentPrivate::init() { } - bool CoreWindowAgentPrivate::setup(QWindow *window, WindowItemDelegate *delegate) { - auto handler = + bool CoreWindowAgentPrivate::setup(QObject *host, WindowItemDelegate *delegate) { + auto ctx = #ifdef Q_OS_WINDOWS - new Win32WindowContext(window, delegate) + std::make_unique<Win32WindowContext>(host, delegate) #else - new QtWindowContext(window, delegate) + std::make_unique<QtWindowContext>(host, window, delegate) #endif ; - - if (!handler->setup()) { - delete handler; + if (!ctx->setup()) { return false; } - m_eventHandler = handler; + context = std::move(ctx); return true; } - CoreWindowAgent::~CoreWindowAgent() { - } + CoreWindowAgent::~CoreWindowAgent() = default; void CoreWindowAgent::showSystemMenu(const QPoint &pos) { Q_D(CoreWindowAgent); - d->m_eventHandler->showSystemMenu(pos); + d->context->showSystemMenu(pos); } void CoreWindowAgent::startSystemMove(const QPoint &pos) { Q_D(CoreWindowAgent); - auto win = d->m_eventHandler->window(); + auto win = d->context->window(); if (!win) { return; } @@ -59,7 +56,7 @@ void CoreWindowAgent::startSystemResize(Qt::Edges edges, const QPoint &pos) { Q_D(CoreWindowAgent); - auto win = d->m_eventHandler->window(); + auto win = d->context->window(); if (!win) { return; } -- Gitblit v1.9.1