From f041cd599f2ba58906958f6886b9cd25e180d0af Mon Sep 17 00:00:00 2001
From: Yuhang Zhao <zhaoyuhang@rankyee.com>
Date: 周三, 06 12月 2023 10:28:34 +0800
Subject: [PATCH] add more const
---
src/widgets/widgetitemdelegate.cpp | 37 +++++++++++++++++++++++++++----------
1 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/src/widgets/widgetitemdelegate.cpp b/src/widgets/widgetitemdelegate.cpp
index 9d338c1..6378f36 100644
--- a/src/widgets/widgetitemdelegate.cpp
+++ b/src/widgets/widgetitemdelegate.cpp
@@ -12,16 +12,16 @@
WidgetItemDelegate::~WidgetItemDelegate() = default;
- QWindow *WidgetItemDelegate::window(QObject *obj) const {
- return static_cast<QWidget *>(obj)->windowHandle();
+ QWindow *WidgetItemDelegate::window(const QObject *obj) const {
+ return static_cast<const QWidget *>(obj)->windowHandle();
}
- bool WidgetItemDelegate::isEnabled(QObject *obj) const {
- return static_cast<QWidget *>(obj)->isEnabled();
+ bool WidgetItemDelegate::isEnabled(const QObject *obj) const {
+ return static_cast<const QWidget *>(obj)->isEnabled();
}
- bool WidgetItemDelegate::isVisible(QObject *obj) const {
- return static_cast<QWidget *>(obj)->isVisible();
+ bool WidgetItemDelegate::isVisible(const QObject *obj) const {
+ return static_cast<const QWidget *>(obj)->isVisible();
}
QRect WidgetItemDelegate::mapGeometryToScene(const QObject *obj) const {
@@ -31,17 +31,34 @@
return {originPoint, size};
}
- QWindow *WidgetItemDelegate::hostWindow(QObject *host) const {
- return static_cast<QWidget *>(host)->windowHandle();
+ QWindow *WidgetItemDelegate::hostWindow(const QObject *host) const {
+ return static_cast<const QWidget *>(host)->windowHandle();
}
- bool WidgetItemDelegate::isHostSizeFixed(QObject *host) const {
+ bool WidgetItemDelegate::isHostSizeFixed(const QObject *host) const {
+ const auto widget = static_cast<const QWidget *>(host);
+ // "Qt::MSWindowsFixedSizeDialogHint" is used cross-platform actually.
+ if (widget->windowFlags() & Qt::MSWindowsFixedSizeDialogHint) {
+ return true;
+ }
+ // Caused by setFixedWidth/Height/Size().
+ const QSize minSize = widget->minimumSize();
+ const QSize maxSize = widget->maximumSize();
+ if (!minSize.isEmpty() && !maxSize.isEmpty() && (minSize == maxSize)) {
+ return true;
+ }
+ // Usually set by the user.
+ const QSizePolicy sizePolicy = widget->sizePolicy();
+ if ((sizePolicy.horizontalPolicy() == QSizePolicy::Fixed)
+ && (sizePolicy.verticalPolicy() == QSizePolicy::Fixed)) {
+ return true;
+ }
return false;
}
bool WidgetItemDelegate::resetQtGrabbedControl() const {
if (qt_button_down) {
- static constexpr const auto invalidPos = QPoint{-99999, -99999};
+ static constexpr const auto invalidPos = QPoint{std::numeric_limits<int>::lowest(), std::numeric_limits<int>::lowest()};
const auto event =
new QMouseEvent(QEvent::MouseButtonRelease, invalidPos, invalidPos, invalidPos,
Qt::LeftButton, QGuiApplication::mouseButtons() ^ Qt::LeftButton,
--
Gitblit v1.9.1