From 9dcea027f16c4ce5852da3dfc8aca284c582bd7d Mon Sep 17 00:00:00 2001
From: sola.lu <sola.lu.greentest.com.cn>
Date: 周五, 06 6月 2025 18:19:18 +0800
Subject: [PATCH] 1.注释掉custom margin，解决程序放大后，遮盖窗口底部内容的问题。
---
src/widgets/widgetwindowagent_win.cpp | 31 ++++++++++++++++++++++++-------
1 files changed, 24 insertions(+), 7 deletions(-)
diff --git a/src/widgets/widgetwindowagent_win.cpp b/src/widgets/widgetwindowagent_win.cpp
index d3e8ecd..f7501e0 100644
--- a/src/widgets/widgetwindowagent_win.cpp
+++ b/src/widgets/widgetwindowagent_win.cpp
@@ -55,8 +55,16 @@
}
void updateGeometry() override {
- widget->setContentsMargins(isNormalWindow() ? QMargins(0, borderThickness(), 0, 0)
- : QMargins());
+ // The window top border is manually painted by QWK so we want to give
+ // some margins to avoid it covering real window contents, however, we
+ // found that there are some rounding issues for the thin border and
+ // thus this small trick doesn't work very well when the DPR is not
+ // integer. So far we haven't found a perfect solution, so just don't
+ // set any margins. In theory the window content will only be covered
+ // by 1px or so, it should not be a serious issue in the real world.
+ //
+ // widget->setContentsMargins(isNormalWindow() ? QMargins(0, borderThickness(), 0, 0)
+ // : QMargins());
}
bool isWindowActive() const override {
@@ -66,7 +74,7 @@
inline void forwardEventToWidgetAndDraw(QWidget *w, QEvent *event) {
// https://github.com/qt/qtbase/blob/e26a87f1ecc40bc8c6aa5b889fce67410a57a702/src/widgets/kernel/qapplication.cpp#L3286
// Deliver the event
- if (!forwardObjectEventFilters(ctx, w, event)) {
+ if (!forwardObjectEventFilters(this, w, event)) {
// Let the widget paint first
std::ignore = static_cast<QObject *>(w)->event(event);
QCoreApplicationPrivate::setEventSpontaneous(event, false);
@@ -75,12 +83,12 @@
// Due to the timer or user action, Qt will repaint some regions spontaneously,
// even if there is no WM_PAINT message, we must wait for it to finish painting
// and then update the top border area.
- drawBorder();
+ drawBorderNative();
}
inline void forwardEventToWindowAndDraw(QWindow *window, QEvent *event) {
// https://github.com/qt/qtbase/blob/e26a87f1ecc40bc8c6aa5b889fce67410a57a702/src/widgets/kernel/qapplication.cpp#L3286
- // Deliver the event;
+ // Deliver the event
if (!forwardObjectEventFilters(ctx, window, event)) {
// Let Qt paint first
std::ignore = static_cast<QObject *>(window)->event(event);
@@ -89,7 +97,7 @@
// Upon receiving the WM_PAINT message, Qt will repaint the entire view, and we
// must wait for it to finish painting before drawing this top border area.
- drawBorder();
+ drawBorderNative();
}
protected:
@@ -105,9 +113,18 @@
// Since a QExposeEvent will be sent immediately after the QResizeEvent, we can
// simply ignore it.
+#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0))
+ struct ExposeEvent : public QExposeEvent {
+ inline const QRegion &getRegion() const { return m_region; }
+ };
+ auto ee = static_cast<ExposeEvent *>(event);
+ bool exposeRegionValid = !ee->getRegion().isNull();
+#else
auto ee = static_cast<QExposeEvent *>(event);
+ bool exposeRegionValid = !ee->region().isNull();
+#endif
auto window = widget->windowHandle();
- if (window->isExposed() && isNormalWindow() && !ee->region().isNull()) {
+ if (window->isExposed() && isNormalWindow() && exposeRegionValid) {
forwardEventToWindowAndDraw(window, event);
return true;
}
--
Gitblit v1.9.1