From 7a425ef1806183ac563507740e94b5d0a439dad3 Mon Sep 17 00:00:00 2001
From: Iztok Jeras <iztok.jeras@redpitaya.com>
Date: 摹曛, 08 10月 2015 03:00:34 +0800
Subject: [PATCH] integer parser: all functions handling a sign argument are now static, without the SCPI_ prefix

---
 libscpi/src/utils.c |   58 ++++++++++++++++++++++++++++++++++++++++++++++++++++------
 1 files changed, 52 insertions(+), 6 deletions(-)

diff --git a/libscpi/src/utils.c b/libscpi/src/utils.c
index 711782d..62de94a 100644
--- a/libscpi/src/utils.c
+++ b/libscpi/src/utils.c
@@ -69,7 +69,7 @@
 }
 
 /**
- * Converts signed/unsigned 32 bit integer value to string
+ * Converts signed/unsigned 32 bit integer value to string in specific base
  * @param val   integer value
  * @param str   converted textual representation
  * @param len   string buffer length
@@ -77,7 +77,7 @@
  * @param sign  
  * @return number of bytes written to str (without '\0')
  */
-size_t SCPI_Int32ToStr(int32_t val, char * str, size_t len, int8_t base, scpi_bool_t sign) {
+static size_t UInt32ToStrBaseSign(uint32_t val, char * str, size_t len, int8_t base, scpi_bool_t sign) {
     const char digits[] = "0123456789ABCDEF";
 
 #define ADD_CHAR(c) if (pos < len) str[pos++] = (c)
@@ -110,7 +110,7 @@
         }
 
         // add sign for numbers in base 10
-        if (sign && (val < 0) && (base == 10)) {
+        if (sign && ((int32_t) val < 0) && (base == 10)) {
             uval = -val;
             ADD_CHAR('-');
         }
@@ -134,7 +134,30 @@
 }
 
 /**
- * Converts signed/unsigned 64 bit integer value to string
+ * Converts signed 32 bit integer value to string
+ * @param val   integer value
+ * @param str   converted textual representation
+ * @param len   string buffer length
+ * @return number of bytes written to str (without '\0')
+ */
+size_t SCPI_Int32ToStr(int32_t val, char * str, size_t len) {
+    UInt32ToStrBaseSign((int32_t) val, str, len, 10, TRUE);
+}
+
+/**
+ * Converts unsigned 32 bit integer value to string in specific base
+ * @param val   integer value
+ * @param str   converted textual representation
+ * @param len   string buffer length
+ * @param base  output base
+ * @return number of bytes written to str (without '\0')
+ */
+size_t SCPI_UInt32ToStrBase(uint32_t val, char * str, size_t len, int8_t base) {
+    UInt32ToStrBaseSign(val, str, len, base, TRUE);
+}
+
+/**
+ * Converts signed/unsigned 64 bit integer value to string in specific base
  * @param val   integer value
  * @param str   converted textual representation
  * @param len   string buffer length
@@ -142,7 +165,7 @@
  * @param sign  
  * @return number of bytes written to str (without '\0')
  */
-size_t SCPI_Int64ToStr(int64_t val, char * str, size_t len, int8_t base, scpi_bool_t sign) {
+static size_t UInt64ToStrBaseSign(uint64_t val, char * str, size_t len, int8_t base, scpi_bool_t sign) {
     const char digits[] = "0123456789ABCDEF";
 
 #define ADD_CHAR(c) if (pos < len) str[pos++] = (c)
@@ -175,7 +198,7 @@
         }
 
         // add sign for numbers in base 10
-        if (sign && (val < 0) && (base == 10)) {
+        if (sign && ((int64_t) val < 0) && (base == 10)) {
             uval = -val;
             ADD_CHAR('-');
         }
@@ -199,6 +222,29 @@
 }
 
 /**
+ * Converts signed 64 bit integer value to string
+ * @param val   integer value
+ * @param str   converted textual representation
+ * @param len   string buffer length
+ * @return number of bytes written to str (without '\0')
+ */
+size_t SCPI_Int64ToStr(int64_t val, char * str, size_t len) {
+    UInt64ToStrBaseSign((int64_t) val, str, len, 10, TRUE);
+}
+
+/**
+ * Converts signed/unsigned 64 bit integer value to string in specific base
+ * @param val   integer value
+ * @param str   converted textual representation
+ * @param len   string buffer length
+ * @param base  output base
+ * @return number of bytes written to str (without '\0')
+ */
+size_t SCPI_UInt64ToStrBase(uint64_t val, char * str, size_t len, int8_t base) {
+    UInt64ToStrBaseSign(val, str, len, base, TRUE);
+}
+
+/**
  * Converts double value to string
  * @param val   double value
  * @param str   converted textual representation

--
Gitblit v1.9.1