From b2047704ad359447958203810784f4e2f3deeff5 Mon Sep 17 00:00:00 2001
From: Howard Li <bighorn@pursuitofchallenge.com>
Date: 周三, 29 4月 2020 03:23:49 +0800
Subject: [PATCH] Avoid directly clearing STB

---
 examples/test-LwIP-netconn/scpi_server.c |   69 +++++++++++++++++-----------------
 1 files changed, 35 insertions(+), 34 deletions(-)

diff --git a/examples/test-LwIP-netconn/scpi_server.c b/examples/test-LwIP-netconn/scpi_server.c
index dff5d7c..5145167 100644
--- a/examples/test-LwIP-netconn/scpi_server.c
+++ b/examples/test-LwIP-netconn/scpi_server.c
@@ -1,28 +1,29 @@
 /*-
- * Copyright (c) 2012-2013 Jan Breuer,
+ * BSD 2-Clause License
  *
- * All Rights Reserved
+ * Copyright (c) 2012-2018, Jan Breuer
+ * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
+ * modification, are permitted provided that the following conditions are met:
  *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHORS ``AS IS'' AND ANY EXPRESS OR
- * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL THE AUTHORS OR CONTRIBUTORS BE LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
- * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
- * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
- * OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
- * IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ * * Redistributions of source code must retain the above copyright notice, this
+ *   list of conditions and the following disclaimer.
+ *
+ * * Redistributions in binary form must reproduce the above copyright notice,
+ *   this list of conditions and the following disclaimer in the documentation
+ *   and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
@@ -69,8 +70,8 @@
     struct netconn *io;
     struct netconn *control_io;
     xQueueHandle evtQueue;
-    //FILE * fio;
-    //fd_set fds;
+    /* FILE * fio; */
+    /* fd_set fds; */
 } user_data_t;
 
 struct _queue_event_t {
@@ -112,7 +113,7 @@
 
 int SCPI_Error(scpi_t * context, int_fast16_t err) {
     (void) context;
-    // BEEP
+    /* BEEP */
     iprintf("**ERROR: %ld, \"%s\"\r\n", (int32_t) err, SCPI_ErrorTranslate(err));
     if (err != 0) {
         /* New error */
@@ -237,11 +238,11 @@
 
     if (netconn_accept(user_data->io_listen, &newconn) == ERR_OK) {
         if (user_data->io) {
-            // Close unwanted connection
+            /* Close unwanted connection */
             netconn_close(newconn);
             netconn_delete(newconn);
         } else {
-            // connection established
+            /* connection established */
             iprintf("***Connection established %s\r\n", inet_ntoa(newconn->pcb.ip->remote_ip));
             user_data->io = newconn;
         }
@@ -258,7 +259,7 @@
             netconn_close(newconn);
             netconn_delete(newconn);
         } else {
-            // control connection established
+            /* control connection established */
             iprintf("***Control Connection established %s\r\n", inet_ntoa(newconn->pcb.ip->remote_ip));
             user_data->control_io = newconn;
         }
@@ -268,7 +269,7 @@
 }
 
 static void closeIo(user_data_t * user_data) {
-    // connection closed
+    /* connection closed */
     netconn_close(user_data->io);
     netconn_delete(user_data->io);
     user_data->io = NULL;
@@ -276,7 +277,7 @@
 }
 
 static void closeSrqIo(user_data_t * user_data) {
-    // control connection closed
+    /* control connection closed */
     netconn_close(user_data->control_io);
     netconn_delete(user_data->control_io);
     user_data->control_io = NULL;
@@ -300,7 +301,7 @@
     if (buflen > 0) {
         SCPI_Input(&scpi_context, buf, buflen);
     } else {
-        //goto fail2;
+        /* goto fail2; */
     }
 
     netbuf_delete(inbuf);
@@ -330,9 +331,9 @@
     netbuf_data(inbuf, (void**) &buf, &buflen);
 
     if (buflen > 0) {
-        // TODO process control
+        /* TODO process control */
     } else {
-        //goto fail2;
+        /* goto fail2; */
     }
 
     netbuf_delete(inbuf);
@@ -357,7 +358,7 @@
 
     user_data.evtQueue = xQueueCreate(10, sizeof (queue_event_t));
 
-    // user_context will be pointer to socket
+    /* user_context will be pointer to socket */
     SCPI_Init(&scpi_context,
             scpi_commands,
             &scpi_interface,
@@ -374,7 +375,7 @@
     while (1) {
         waitServer(&user_data, &evt);
 
-        if (evt.cmd == SCPI_MSG_TIMEOUT) { // timeout
+        if (evt.cmd == SCPI_MSG_TIMEOUT) { /* timeout */
             SCPI_Input(&scpi_context, NULL, 0);
         }
 
@@ -409,4 +410,4 @@
 
 void scpi_server_init(void) {
     sys_thread_new("SCPI", scpi_server_thread, NULL, 2 * DEFAULT_THREAD_STACKSIZE, SCPI_THREAD_PRIO);
-}
\ No newline at end of file
+}

--
Gitblit v1.9.1