From b7e9d6858699f5ea9a23ecf6587e98e7b0e1bc28 Mon Sep 17 00:00:00 2001
From: Jan Breuer <jan.breuer@jaybee.cz>
Date: 周三, 14 10月 2015 16:49:41 +0800
Subject: [PATCH] Resolve #58: Illegal parameter value and unit test

---
 libscpi/src/utils_private.h |   36 +++++++++++++++++++++++-------------
 1 files changed, 23 insertions(+), 13 deletions(-)

diff --git a/libscpi/src/utils_private.h b/libscpi/src/utils_private.h
index ed624f3..f864004 100644
--- a/libscpi/src/utils_private.h
+++ b/libscpi/src/utils_private.h
@@ -34,8 +34,8 @@
  * 
  */
 
-#ifndef SCPI_UTILS_H
-#define	SCPI_UTILS_H
+#ifndef SCPI_UTILS_PRIVATE_H
+#define	SCPI_UTILS_PRIVATE_H
 
 #include <stdint.h>
 #include "scpi/config.h"
@@ -46,34 +46,44 @@
 #endif
 
 #if defined(__GNUC__) && (__GNUC__ >= 4)
-    #define LOCAL __attribute__((visibility ("hidden")))
+#define LOCAL __attribute__((visibility ("hidden")))
 #else
-    #define LOCAL
+#define LOCAL
 #endif
 
     char * strnpbrk(const char *str, size_t size, const char *set) LOCAL;
     scpi_bool_t compareStr(const char * str1, size_t len1, const char * str2, size_t len2) LOCAL;
-    scpi_bool_t compareStrAndNum(const char * str1, size_t len1, const char * str2, size_t len2) LOCAL;    
-    size_t longToStr(int32_t val, char * str, size_t len, int8_t base) LOCAL;
-    size_t doubleToStr(double val, char * str, size_t len) LOCAL;
-    size_t strToLong(const char * str, int32_t * val, int8_t base) LOCAL;
+    scpi_bool_t compareStrAndNum(const char * str1, size_t len1, const char * str2, size_t len2, int32_t * num) LOCAL;
+    size_t UInt32ToStrBaseSign(uint32_t val, char * str, size_t len, int8_t base, scpi_bool_t sign) LOCAL;
+    size_t UInt64ToStrBaseSign(uint64_t val, char * str, size_t len, int8_t base, scpi_bool_t sign) LOCAL;
+    size_t strBaseToInt32(const char * str, int32_t * val, int8_t base) LOCAL;
+    size_t strBaseToUInt32(const char * str, uint32_t * val, int8_t base) LOCAL;
+    size_t strBaseToInt64(const char * str, int64_t * val, int8_t base) LOCAL;
+    size_t strBaseToUInt64(const char * str, uint64_t * val, int8_t base) LOCAL;
+    size_t strToFloat(const char * str, float * val) LOCAL;
     size_t strToDouble(const char * str, double * val) LOCAL;
     scpi_bool_t locateText(const char * str1, size_t len1, const char ** str2, size_t * len2) LOCAL;
     scpi_bool_t locateStr(const char * str1, size_t len1, const char ** str2, size_t * len2) LOCAL;
     size_t skipWhitespace(const char * cmd, size_t len) LOCAL;
-    scpi_bool_t matchPattern(const char * pattern, size_t pattern_len, const char * str, size_t str_len) LOCAL;
-    scpi_bool_t matchCommand(const char * pattern, const char * cmd, size_t len) LOCAL;
+    scpi_bool_t matchPattern(const char * pattern, size_t pattern_len, const char * str, size_t str_len, int32_t * num) LOCAL;
+    scpi_bool_t matchCommand(const char * pattern, const char * cmd, size_t len, int32_t *numbers, size_t numbers_len, int32_t default_value) LOCAL;
+    scpi_bool_t composeCompoundCommand(const scpi_token_t * prev, scpi_token_t * current) LOCAL;
 
 #if !HAVE_STRNLEN
-    size_t BSD_strnlen(const char *s, size_t maxlen);
+    size_t BSD_strnlen(const char *s, size_t maxlen) LOCAL;
 #endif
 
 #if !HAVE_STRNCASECMP && !HAVE_STRNICMP
-    int OUR_strncasecmp(const char *s1, const char *s2, size_t n);
+    int OUR_strncasecmp(const char *s1, const char *s2, size_t n) LOCAL;
 #endif
 
+#ifndef min
 #define min(a, b)  (((a) < (b)) ? (a) : (b))
+#endif
+
+#ifndef max
 #define max(a, b)  (((a) > (b)) ? (a) : (b))
+#endif
 
 #if 0
 #define max(a,b) \
@@ -92,5 +102,5 @@
 }
 #endif
 
-#endif	/* SCPI_UTILS_H */
+#endif	/* SCPI_UTILS_PRIVATE_H */
 

--
Gitblit v1.9.1