From e7d3092dd149ce455eaa934cc63104b6273302f5 Mon Sep 17 00:00:00 2001
From: Jan Breuer <jan.breuer@jaybee.cz>
Date: 周一, 22 2月 2016 08:19:09 +0800
Subject: [PATCH] Add all possible units from IEEE488.2 to address some points of #26

---
 libscpi/test/test_parser.c |  315 ++++++++++++++++++++++++++++++++++++++++++++-------
 1 files changed, 269 insertions(+), 46 deletions(-)

diff --git a/libscpi/test/test_parser.c b/libscpi/test/test_parser.c
index b3c1463..580a721 100644
--- a/libscpi/test/test_parser.c
+++ b/libscpi/test/test_parser.c
@@ -45,6 +45,17 @@
     return SCPI_RES_OK;
 }
 
+static double test_sample_received = NAN;
+
+static scpi_result_t SCPI_Sample(scpi_t * context) {
+    const char * val;
+    size_t len;
+    if (!SCPI_ParamArbitraryBlock(context, &val, &len, TRUE)) return SCPI_RES_ERR;
+    if (len != sizeof(test_sample_received)) return SCPI_RES_ERR;
+    memcpy(&test_sample_received, val, sizeof(test_sample_received));
+    return SCPI_RES_OK;
+}
+
 static const scpi_command_t scpi_commands[] = {
     /* IEEE Mandated Commands (SCPI std V1999.0 4.1.1) */
     { .pattern = "*CLS", .callback = SCPI_CoreCls,},
@@ -80,6 +91,7 @@
     { .pattern = "STUB", .callback = SCPI_Stub,},
     { .pattern = "STUB?", .callback = SCPI_StubQ,},
 
+    { .pattern = "SAMple", .callback = SCPI_Sample,},
     SCPI_CMD_LIST_END
 };
 
@@ -171,25 +183,17 @@
 #define SCPI_INPUT_BUFFER_LENGTH 256
 static char scpi_input_buffer[SCPI_INPUT_BUFFER_LENGTH];
 
-static scpi_reg_val_t scpi_regs[SCPI_REG_COUNT];
-
-
-scpi_t scpi_context = {
-    .cmdlist = scpi_commands,
-    .buffer =
-    {
-        .length = SCPI_INPUT_BUFFER_LENGTH,
-        .data = scpi_input_buffer,
-    },
-    .interface = &scpi_interface,
-    .registers = scpi_regs,
-    .units = scpi_units_def,
-    .idn =
-    {"MA", "IN", NULL, "VER"},
-};
+#define SCPI_ERROR_QUEUE_SIZE 4
+static int16_t scpi_error_queue_data[SCPI_ERROR_QUEUE_SIZE];
 
 static int init_suite(void) {
-    SCPI_Init(&scpi_context);
+    SCPI_Init(&scpi_context,
+            scpi_commands,
+            &scpi_interface,
+            scpi_units_def,
+            "MA", "IN", NULL, "VER",
+            scpi_input_buffer, SCPI_INPUT_BUFFER_LENGTH,
+            scpi_error_queue_data, SCPI_ERROR_QUEUE_SIZE);
 
     return 0;
 }
@@ -408,10 +412,10 @@
     TEST_ParamInt32("#H101010", TRUE, 1052688, TRUE, 0);
     TEST_ParamInt32("#Q10", TRUE, 8, TRUE, 0);
 
-    TEST_ParamInt32("", TRUE, 0, FALSE, -109); // missing parameter
-    TEST_ParamInt32("abcd", TRUE, 0, FALSE, -104); // Data type error
-    TEST_ParamInt32("10.5V", TRUE, 0, FALSE, -138);
-    TEST_ParamInt32("10V", TRUE, 0, FALSE, -138);
+    TEST_ParamInt32("", TRUE, 0, FALSE, SCPI_ERROR_MISSING_PARAMETER); // missing parameter
+    TEST_ParamInt32("abcd", TRUE, 0, FALSE, SCPI_ERROR_DATA_TYPE_ERROR); // Data type error
+    TEST_ParamInt32("10.5V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
+    TEST_ParamInt32("10V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
 
     // test range
     TEST_ParamInt32("2147483647", TRUE, 2147483647, TRUE, 0);
@@ -447,10 +451,10 @@
     TEST_ParamUInt32("#H101010", TRUE, 1052688, TRUE, 0);
     TEST_ParamUInt32("#Q10", TRUE, 8, TRUE, 0);
 
-    TEST_ParamUInt32("", TRUE, 0, FALSE, -109); // missing parameter
-    TEST_ParamUInt32("abcd", TRUE, 0, FALSE, -104); // Data type error
-    TEST_ParamUInt32("10.5V", TRUE, 0, FALSE, -138);
-    TEST_ParamUInt32("10V", TRUE, 0, FALSE, -138);
+    TEST_ParamUInt32("", TRUE, 0, FALSE, SCPI_ERROR_MISSING_PARAMETER); // missing parameter
+    TEST_ParamUInt32("abcd", TRUE, 0, FALSE, SCPI_ERROR_DATA_TYPE_ERROR); // Data type error
+    TEST_ParamUInt32("10.5V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
+    TEST_ParamUInt32("10V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
 
     // test range
     TEST_ParamUInt32("2147483647", TRUE, 2147483647ULL, TRUE, 0);
@@ -486,10 +490,10 @@
     TEST_ParamInt64("#H101010", TRUE, 1052688, TRUE, 0);
     TEST_ParamInt64("#Q10", TRUE, 8, TRUE, 0);
 
-    TEST_ParamInt64("", TRUE, 0, FALSE, -109); // missing parameter
-    TEST_ParamInt64("abcd", TRUE, 0, FALSE, -104); // Data type error
-    TEST_ParamInt64("10.5V", TRUE, 0, FALSE, -138);
-    TEST_ParamInt64("10V", TRUE, 0, FALSE, -138);
+    TEST_ParamInt64("", TRUE, 0, FALSE, SCPI_ERROR_MISSING_PARAMETER); // missing parameter
+    TEST_ParamInt64("abcd", TRUE, 0, FALSE, SCPI_ERROR_DATA_TYPE_ERROR); // Data type error
+    TEST_ParamInt64("10.5V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
+    TEST_ParamInt64("10V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
 
     // test range
     TEST_ParamInt64("2147483647", TRUE, 2147483647LL, TRUE, 0);
@@ -527,10 +531,10 @@
     TEST_ParamUInt64("#H101010", TRUE, 1052688, TRUE, 0);
     TEST_ParamUInt64("#Q10", TRUE, 8, TRUE, 0);
 
-    TEST_ParamUInt64("", TRUE, 0, FALSE, -109); // missing parameter
-    TEST_ParamUInt64("abcd", TRUE, 0, FALSE, -104); // Data type error
-    TEST_ParamUInt64("10.5V", TRUE, 0, FALSE, -138);
-    TEST_ParamUInt64("10V", TRUE, 0, FALSE, -138);
+    TEST_ParamUInt64("", TRUE, 0, FALSE, SCPI_ERROR_MISSING_PARAMETER); // missing parameter
+    TEST_ParamUInt64("abcd", TRUE, 0, FALSE, SCPI_ERROR_DATA_TYPE_ERROR); // Data type error
+    TEST_ParamUInt64("10.5V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
+    TEST_ParamUInt64("10V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
 
     // test range
     TEST_ParamUInt64("2147483647", TRUE, 2147483647ULL, TRUE, 0);
@@ -570,10 +574,10 @@
     TEST_ParamFloat("#Q10", TRUE, 8, TRUE, 0);
     TEST_ParamFloat("#HFFFFFF", TRUE, 0xFFFFFFu, TRUE, 0);
 
-    TEST_ParamFloat("", TRUE, 0, FALSE, -109); // missing parameter
-    TEST_ParamFloat("abcd", TRUE, 0, FALSE, -104); // Data type error
-    TEST_ParamFloat("10.5V", TRUE, 0, FALSE, -138);
-    TEST_ParamFloat("10V", TRUE, 0, FALSE, -138);
+    TEST_ParamFloat("", TRUE, 0, FALSE, SCPI_ERROR_MISSING_PARAMETER); // missing parameter
+    TEST_ParamFloat("abcd", TRUE, 0, FALSE, SCPI_ERROR_DATA_TYPE_ERROR); // Data type error
+    TEST_ParamFloat("10.5V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
+    TEST_ParamFloat("10V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
 }
 
 #define TEST_ParamDouble(data, mandatory, expected_value, expected_result, expected_error_code) \
@@ -606,10 +610,10 @@
     TEST_ParamDouble("#Q10", TRUE, 8, TRUE, 0);
     TEST_ParamDouble("#HFFFFFFFF", TRUE, 0xFFFFFFFFu, TRUE, 0);
 
-    TEST_ParamDouble("", TRUE, 0, FALSE, -109); // missing parameter
-    TEST_ParamDouble("abcd", TRUE, 0, FALSE, -104); // Data type error
-    TEST_ParamDouble("10.5V", TRUE, 0, FALSE, -138);
-    TEST_ParamDouble("10V", TRUE, 0, FALSE, -138);
+    TEST_ParamDouble("", TRUE, 0, FALSE, SCPI_ERROR_MISSING_PARAMETER); // missing parameter
+    TEST_ParamDouble("abcd", TRUE, 0, FALSE, SCPI_ERROR_DATA_TYPE_ERROR); // Data type error
+    TEST_ParamDouble("10.5V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
+    TEST_ParamDouble("10V", TRUE, 0, FALSE, SCPI_ERROR_SUFFIX_NOT_ALLOWED);
 }
 
 #define TEST_ParamCharacters(data, mandatory, expected_value, expected_result, expected_error_code) \
@@ -640,7 +644,7 @@
     TEST_ParamCharacters("\"ABCD\"", TRUE, "ABCD", TRUE, 0); // TokDoubleQuoteProgramData
     TEST_ParamCharacters("\'ABCD\'", TRUE, "ABCD", TRUE, 0); // TokSingleQuoteProgramData
     TEST_ParamCharacters("#204ABCD", TRUE, "ABCD", TRUE, 0); // TokArbitraryBlockProgramData
-    TEST_ParamCharacters("#210ABCD", TRUE, "", FALSE, -151); // invalid Block Data
+    TEST_ParamCharacters("#210ABCD", TRUE, "", FALSE, SCPI_ERROR_INVALID_STRING_DATA); // invalid Block Data
 }
 
 
@@ -680,6 +684,95 @@
     TEST_ParamCopyText("\"\"", FALSE, "", 0, TRUE, 0);
 }
 
+#define TEST_ParamArbitraryBlock(data, mandatory, expected_value, expected_result, expected_error_code) \
+{                                                                                       \
+    const char * value;                                                                 \
+    size_t value_len;                                                                   \
+    scpi_bool_t result;                                                                 \
+    int16_t errCode;                                                                    \
+                                                                                        \
+    SCPI_CoreCls(&scpi_context);                                                        \
+    scpi_context.input_count = 0;                                                       \
+    scpi_context.param_list.lex_state.buffer = data;                                    \
+    scpi_context.param_list.lex_state.len = strlen(scpi_context.param_list.lex_state.buffer);\
+    scpi_context.param_list.lex_state.pos = scpi_context.param_list.lex_state.buffer;   \
+    result = SCPI_ParamArbitraryBlock(&scpi_context, &value, &value_len, mandatory);        \
+    /*printf("%.*s\r\n",  (int)value_len, value);*/                                     \
+    errCode = SCPI_ErrorPop(&scpi_context);                                             \
+    CU_ASSERT_EQUAL(result, expected_result);                                           \
+    if (expected_result) {                                                              \
+        CU_ASSERT_NSTRING_EQUAL(value, expected_value, value_len);                      \
+    }                                                                                   \
+    CU_ASSERT_EQUAL(errCode, expected_error_code);                                      \
+}
+static void testSCPI_ParamArbitraryBlock(void) {
+    TEST_ParamArbitraryBlock("#204ABCD", TRUE, "ABCD", TRUE, 0);
+    TEST_ParamArbitraryBlock("\"ABCD\"", TRUE, "", FALSE, SCPI_ERROR_DATA_TYPE_ERROR);
+}
+
+#define TEST_ParamBool(data, mandatory, expected_value, expected_result, expected_error_code) \
+{                                                                                       \
+    scpi_bool_t value;                                                                  \
+    scpi_bool_t result;                                                                 \
+    int16_t errCode;                                                                    \
+                                                                                        \
+    SCPI_CoreCls(&scpi_context);                                                        \
+    scpi_context.input_count = 0;                                                       \
+    scpi_context.param_list.lex_state.buffer = data;                                    \
+    scpi_context.param_list.lex_state.len = strlen(scpi_context.param_list.lex_state.buffer);\
+    scpi_context.param_list.lex_state.pos = scpi_context.param_list.lex_state.buffer;   \
+    result = SCPI_ParamBool(&scpi_context, &value, mandatory);                         \
+                                                                                        \
+    errCode = SCPI_ErrorPop(&scpi_context);                                             \
+    CU_ASSERT_EQUAL(result, expected_result);                                           \
+    if (expected_result) {                                                              \
+        CU_ASSERT_EQUAL(value, expected_value);                                         \
+    }                                                                                   \
+    CU_ASSERT_EQUAL(errCode, expected_error_code);                                      \
+}
+static void testSCPI_ParamBool(void) {
+    TEST_ParamBool("ON", TRUE, TRUE, TRUE, 0);
+    TEST_ParamBool("1", TRUE, TRUE, TRUE, 0);
+    TEST_ParamBool("100", TRUE, TRUE, TRUE, 0);
+    TEST_ParamBool("OFF", TRUE, FALSE, TRUE, 0);
+    TEST_ParamBool("0", TRUE, FALSE, TRUE, 0);
+    TEST_ParamBool("XYZ", TRUE, FALSE, FALSE, SCPI_ERROR_ILLEGAL_PARAMETER_VALUE);
+}
+
+#define TEST_ParamChoice(data, mandatory, expected_value, expected_result, expected_error_code) \
+{                                                                                       \
+    int32_t value;                                                                      \
+    scpi_bool_t result;                                                                 \
+    int16_t errCode;                                                                    \
+                                                                                        \
+    SCPI_CoreCls(&scpi_context);                                                        \
+    scpi_context.input_count = 0;                                                       \
+    scpi_context.param_list.lex_state.buffer = data;                                    \
+    scpi_context.param_list.lex_state.len = strlen(scpi_context.param_list.lex_state.buffer);\
+    scpi_context.param_list.lex_state.pos = scpi_context.param_list.lex_state.buffer;   \
+    result = SCPI_ParamChoice(&scpi_context, test_options, &value, mandatory);          \
+                                                                                        \
+    errCode = SCPI_ErrorPop(&scpi_context);                                             \
+    CU_ASSERT_EQUAL(result, expected_result);                                           \
+    if (expected_result) {                                                              \
+        CU_ASSERT_EQUAL(value, expected_value);                                         \
+    }                                                                                   \
+    CU_ASSERT_EQUAL(errCode, expected_error_code);                                      \
+}
+static void testSCPI_ParamChoice(void) {
+    scpi_choice_def_t test_options[] = {
+        {"OPTIONA", 1},
+        {"OPTIONB", 2},
+        {"SOURce", 3},
+        SCPI_CHOICE_LIST_END /* termination of option list */
+    };
+
+    TEST_ParamChoice("ON", TRUE, 0, FALSE, SCPI_ERROR_ILLEGAL_PARAMETER_VALUE);
+    TEST_ParamChoice("OPTIONA", TRUE, 1, TRUE, 0);
+    TEST_ParamChoice("OPTIONB", TRUE, 2, TRUE, 0);
+    TEST_ParamChoice("SOURCE", TRUE, 3, TRUE, 0);
+    TEST_ParamChoice("SOUR", TRUE, 3, TRUE, 0);
+}
 
 #define TEST_NumericListInt(data, index, expected_range, expected_from, expected_to, expected_result, expected_error_code) \
 {                                                                                       \
@@ -761,6 +854,8 @@
     TEST_NumericListDouble("(12,5:6:3)", 0, FALSE, 12, 0, SCPI_EXPR_OK, 0);
     TEST_NumericListDouble("(12,5:6:3)", 1, TRUE, 5, 6, SCPI_EXPR_OK, 0);
     TEST_NumericListDouble("(12,5:6:3)", 2, FALSE, 0, 0, SCPI_EXPR_ERROR, SCPI_ERROR_EXPRESSION_PARSING_ERROR);
+    TEST_NumericListDouble("(12,5:)", 2, FALSE, 0, 0, SCPI_EXPR_ERROR, SCPI_ERROR_EXPRESSION_PARSING_ERROR);
+    TEST_NumericListDouble("aaaa", 2, FALSE, 0, 0, SCPI_EXPR_ERROR, SCPI_ERROR_DATA_TYPE_ERROR);
 }
 
 #define NOPAREN(...) __VA_ARGS__
@@ -829,6 +924,10 @@
 
     TEST_ChannelList("(@1, 2)", 0, 1, FALSE, 1, (1), (0), SCPI_EXPR_OK, 0);
     TEST_ChannelList("(@1, 2)", 1, 1, FALSE, 0, (0), (0), SCPI_EXPR_ERROR, SCPI_ERROR_EXPRESSION_PARSING_ERROR);
+
+    TEST_ChannelList("(@1,)", 1, 1, FALSE, 0, (0), (0), SCPI_EXPR_ERROR, SCPI_ERROR_EXPRESSION_PARSING_ERROR);
+    TEST_ChannelList("(@1,2:)", 1, 1, FALSE, 0, (0), (0), SCPI_EXPR_ERROR, SCPI_ERROR_EXPRESSION_PARSING_ERROR);
+    TEST_ChannelList("abcd", 1, 1, FALSE, 0, (0), (0), SCPI_EXPR_ERROR, SCPI_ERROR_DATA_TYPE_ERROR);
 }
 
 
@@ -870,6 +969,7 @@
     TEST_ParamNumber("min", TRUE, TRUE, SCPI_NUM_MIN, 0, SCPI_UNIT_NONE, 10, TRUE, 0);
     TEST_ParamNumber("infinity", TRUE, TRUE, SCPI_NUM_INF, 0, SCPI_UNIT_NONE, 10, TRUE, 0);
     TEST_ParamNumber("minc", TRUE, TRUE, SCPI_NUM_NUMBER, 0, SCPI_UNIT_NONE, 10, FALSE, SCPI_ERROR_ILLEGAL_PARAMETER_VALUE);
+    TEST_ParamNumber("100 xyz", TRUE, FALSE, SCPI_NUM_NUMBER, 100, SCPI_UNIT_NONE, 10, FALSE, SCPI_ERROR_INVALID_SUFFIX);
 }
 
 #define TEST_Result(func, value, expected_result) \
@@ -1168,7 +1268,7 @@
     number.base = 10;\
     number.special = (_special);\
     number.unit = (_unit);\
-    if (number.special) { number.tag = (_value); } else { number.value = (_value); }\
+    if (number.special) { number.tag = (int)(_value); } else { number.value = (_value); }\
     char buffer[100 + 1];\
     size_t res_len;\
     res_len = SCPI_NumberToStr(&scpi_context, scpi_special_numbers_def, &number, buffer, 100);\
@@ -1182,8 +1282,6 @@
 }
 
 static void testErrorQueue(void) {
-    ((scpi_fifo_t *) (scpi_context.error_queue))->size = 5;
-
     SCPI_ErrorClear(&scpi_context);
     CU_ASSERT_EQUAL(SCPI_ErrorCount(&scpi_context), 0);
     SCPI_ErrorPush(&scpi_context, -1);
@@ -1211,7 +1309,127 @@
     CU_ASSERT_EQUAL(SCPI_ErrorCount(&scpi_context), 0);
 
     SCPI_ErrorClear(&scpi_context);
-    ((scpi_fifo_t *) (scpi_context.error_queue))->size = FIFO_SIZE;
+}
+
+#define TEST_INCOMPLETE_ARB(_val, _part_len) do {\
+    double val = _val;\
+    char command_text[] = "SAMple #18[DOUBLE]\r";\
+    char * command = command_text;\
+    size_t command_len = strlen(command);\
+    memcpy(command + 10, &val, sizeof(val));\
+    test_sample_received = NAN;\
+    size_t part_len = _part_len;\
+    SCPI_ErrorClear(&scpi_context);\
+    while (command_len) {\
+        part_len = part_len > command_len ? command_len : part_len;\
+        SCPI_Input(&scpi_context, command, part_len);\
+        command += part_len;\
+        command_len -= part_len;\
+    }\
+    CU_ASSERT_EQUAL(SCPI_ErrorCount(&scpi_context), 0);\
+    CU_ASSERT_EQUAL(test_sample_received, val);\
+} while(0)
+
+static void testIncompleteArbitraryParameter(void) {
+    TEST_INCOMPLETE_ARB(0.5, 19);
+    TEST_INCOMPLETE_ARB(0.5, 18);
+    TEST_INCOMPLETE_ARB(0.5, 17);
+    TEST_INCOMPLETE_ARB(0.5, 16);
+    TEST_INCOMPLETE_ARB(0.5, 15);
+    TEST_INCOMPLETE_ARB(0.5, 14);
+    TEST_INCOMPLETE_ARB(0.5, 13);
+    TEST_INCOMPLETE_ARB(0.5, 12);
+    TEST_INCOMPLETE_ARB(0.5, 11);
+    TEST_INCOMPLETE_ARB(0.5, 10);
+    TEST_INCOMPLETE_ARB(0.5, 9);
+    TEST_INCOMPLETE_ARB(0.5, 8);
+    TEST_INCOMPLETE_ARB(0.5, 7);
+    TEST_INCOMPLETE_ARB(0.5, 6);
+    TEST_INCOMPLETE_ARB(0.5, 5);
+    TEST_INCOMPLETE_ARB(0.5, 4);
+    TEST_INCOMPLETE_ARB(0.5, 3);
+    TEST_INCOMPLETE_ARB(0.5, 2);
+    TEST_INCOMPLETE_ARB(0.5, 1);
+
+    TEST_INCOMPLETE_ARB(0.501220703125, 19);
+    TEST_INCOMPLETE_ARB(0.501220703125, 18);
+    TEST_INCOMPLETE_ARB(0.501220703125, 17);
+    TEST_INCOMPLETE_ARB(0.501220703125, 16);
+    TEST_INCOMPLETE_ARB(0.501220703125, 15);
+    TEST_INCOMPLETE_ARB(0.501220703125, 14);
+    TEST_INCOMPLETE_ARB(0.501220703125, 13);
+    TEST_INCOMPLETE_ARB(0.501220703125, 12);
+    TEST_INCOMPLETE_ARB(0.501220703125, 11);
+    TEST_INCOMPLETE_ARB(0.501220703125, 10);
+    TEST_INCOMPLETE_ARB(0.501220703125, 9);
+    TEST_INCOMPLETE_ARB(0.501220703125, 8);
+    TEST_INCOMPLETE_ARB(0.501220703125, 7);
+    TEST_INCOMPLETE_ARB(0.501220703125, 6);
+    TEST_INCOMPLETE_ARB(0.501220703125, 5);
+    TEST_INCOMPLETE_ARB(0.501220703125, 4);
+    TEST_INCOMPLETE_ARB(0.501220703125, 3);
+    TEST_INCOMPLETE_ARB(0.501220703125, 2);
+    TEST_INCOMPLETE_ARB(0.501220703125, 1);
+
+    TEST_INCOMPLETE_ARB(0.500000024214387, 19);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 18);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 17);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 16);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 15);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 14);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 13);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 12);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 11);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 10);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 9);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 8);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 7);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 6);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 5);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 4);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 3);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 2);
+    TEST_INCOMPLETE_ARB(0.500000024214387, 1);
+}
+
+#define TEST_INCOMPLETE_TEXT(_text, _part_len) do {\
+    char command_text[] = "TEXT? \"\", \"" _text "\"\r";\
+    char * command = command_text;\
+    size_t command_len = strlen(command);\
+    output_buffer_clear();\
+    size_t part_len = _part_len;\
+    SCPI_ErrorClear(&scpi_context);\
+    while (command_len) {\
+        part_len = part_len > command_len ? command_len : part_len;\
+        SCPI_Input(&scpi_context, command, part_len);\
+        command += part_len;\
+        command_len -= part_len;\
+    }\
+    CU_ASSERT_EQUAL(SCPI_ErrorCount(&scpi_context), 0);\
+    CU_ASSERT_STRING_EQUAL("\"" _text "\"\r\n", output_buffer);\
+} while(0)
+
+static void testIncompleteTextParameter(void) {
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 20);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 19);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 18);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 17);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 16);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 15);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 14);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 13);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 12);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 11);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 10);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 9);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 8);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 7);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 6);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 5);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 4);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 3);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 2);
+    TEST_INCOMPLETE_TEXT("AbcdEfgh", 1);
 }
 
 int main() {
@@ -1238,6 +1456,9 @@
             || (NULL == CU_add_test(pSuite, "SCPI_ParamDouble", testSCPI_ParamDouble))
             || (NULL == CU_add_test(pSuite, "SCPI_ParamCharacters", testSCPI_ParamCharacters))
             || (NULL == CU_add_test(pSuite, "SCPI_ParamCopyText", testSCPI_ParamCopyText))
+            || (NULL == CU_add_test(pSuite, "SCPI_ParamArbitraryBlock", testSCPI_ParamArbitraryBlock))
+            || (NULL == CU_add_test(pSuite, "SCPI_ParamBool", testSCPI_ParamBool))
+            || (NULL == CU_add_test(pSuite, "SCPI_ParamChoice", testSCPI_ParamChoice))
             || (NULL == CU_add_test(pSuite, "Commands handling", testCommandsHandling))
             || (NULL == CU_add_test(pSuite, "Error handling", testErrorHandling))
             || (NULL == CU_add_test(pSuite, "IEEE 488.2 Mandatory commands", testIEEE4882))
@@ -1261,6 +1482,8 @@
             || (NULL == CU_add_test(pSuite, "SCPI_ResultArray", testResultArray))
             || (NULL == CU_add_test(pSuite, "SCPI_NumberToStr", testNumberToStr))
             || (NULL == CU_add_test(pSuite, "SCPI_ErrorQueue", testErrorQueue))
+            || (NULL == CU_add_test(pSuite, "Incomplete arbitrary parameter", testIncompleteArbitraryParameter))
+            || (NULL == CU_add_test(pSuite, "Incomplete text parameter", testIncompleteTextParameter))
             ) {
         CU_cleanup_registry();
         return CU_get_error();

--
Gitblit v1.9.1